flutter update-packages --force-upgrade + analyzer fix by goderbauer · Pull Request #108198 · flutter/flutter

goderbauer · 2022-07-22T22:07:02Z

First commit is result of flutter update-packages --force-upgrade.
Second commit is the fix for the analyzer errors (#108184).
Third commit fixes newly surfaced avoid_redundant_argument_values warnings.

goderbauer · 2022-07-22T22:16:50Z

Looks like the analyzer found some new different warnings now. I'll fix those up in a sec.

goderbauer · 2022-07-22T22:37:50Z

The analyzer check is happy now. 🎊

jmagman

LGTM!

jmagman · 2022-07-22T22:45:05Z

jmagman · 2022-07-23T01:20:56Z

Need to rebase onto #107984 which rolled archive.

…er/flutter#108198)

* 2142b2e Roll Flutter Engine from cd7e2ec4037b to c31036f2381c (1 revision) (flutter/flutter#108299) * 178e444 Revert "Add optional flag to determine assertiveness level in aria announcement for flutter web" (flutter/flutter#108262) * 8a7b359 flutter update-packages --force-upgrade + analyzer fix (flutter/flutter#108198) * b3f5d3f Roll Flutter Engine from c31036f2381c to 54b0ac3059bf (1 revision) (flutter/flutter#108302) * 2f4299a [flutter_tools] Remove unused parameter when connected DAP to VM Service (flutter/flutter#108285) * e74b9b5 Migrate InputDecorator to Material 3 (flutter/flutter#107943) * e3b851a Fix Tamil DateTime representation of AM/PM (flutter/flutter#108185) * 43d6e2b Roll Flutter Engine from 54b0ac3059bf to 705072522c00 (4 revisions) (flutter/flutter#108308) * 6929ad1 Roll Flutter Engine from 705072522c00 to 3964cf62cdf8 (1 revision) (flutter/flutter#108316) * 5f67b47 [iOS] Update template icons (flutter/flutter#107873) * 606954d Added iconSize parameter in ButtonStyle (flutter/flutter#108268) * b3814c7 Roll Flutter Engine from 3964cf62cdf8 to 7f8925b1f6f3 (2 revisions) (flutter/flutter#108320) * ca6cecf Upgrade Gradle and AGP versions to 7.5/7.2 and migrate examples/tests (flutter/flutter#108197) * d155bc1 Revert "Upgrade Gradle and AGP versions to 7.5/7.2 and migrate examples/tests (#108197)" (flutter/flutter#108349) * 4056d3f Explain the "patching" protocol in `KeyMessageManager.keyMessageHandler` and add an example (flutter/flutter#105280) * b035ef1 [flutter_tools] Remove more shuffles (flutter/flutter#107759) * be14858 Roll Flutter Engine from 7f8925b1f6f3 to 8eca26d130a2 (1 revision) (flutter/flutter#108326) * 3eb638f Roll Flutter Engine from 8eca26d130a2 to f1f9b4de82b6 (5 revisions) (flutter/flutter#108350) * 401b556 Roll Flutter Engine from f1f9b4de82b6 to 11d927ac3e9b (2 revisions) (flutter/flutter#108353) * 925bee9 Roll Flutter Engine from 11d927ac3e9b to 5dcaeae6561b (1 revision) (flutter/flutter#108356) * 5d31b07 [flutter_tools] [dap] Ensure DAP sends app.stop/app.detach during terminate (flutter/flutter#108310) * c8b5d10 Roll Flutter Engine from 5dcaeae6561b to 89e117b89c63 (1 revision) (flutter/flutter#108367) * e3d08fb Hide the debug banner in the PopupMenuButton example (flutter/flutter#108324)

…hive#6147) * 2142b2e Roll Flutter Engine from cd7e2ec4037b to c31036f2381c (1 revision) (flutter/flutter#108299) * 178e444 Revert "Add optional flag to determine assertiveness level in aria announcement for flutter web" (flutter/flutter#108262) * 8a7b359 flutter update-packages --force-upgrade + analyzer fix (flutter/flutter#108198) * b3f5d3f Roll Flutter Engine from c31036f2381c to 54b0ac3059bf (1 revision) (flutter/flutter#108302) * 2f4299a [flutter_tools] Remove unused parameter when connected DAP to VM Service (flutter/flutter#108285) * e74b9b5 Migrate InputDecorator to Material 3 (flutter/flutter#107943) * e3b851a Fix Tamil DateTime representation of AM/PM (flutter/flutter#108185) * 43d6e2b Roll Flutter Engine from 54b0ac3059bf to 705072522c00 (4 revisions) (flutter/flutter#108308) * 6929ad1 Roll Flutter Engine from 705072522c00 to 3964cf62cdf8 (1 revision) (flutter/flutter#108316) * 5f67b47 [iOS] Update template icons (flutter/flutter#107873) * 606954d Added iconSize parameter in ButtonStyle (flutter/flutter#108268) * b3814c7 Roll Flutter Engine from 3964cf62cdf8 to 7f8925b1f6f3 (2 revisions) (flutter/flutter#108320) * ca6cecf Upgrade Gradle and AGP versions to 7.5/7.2 and migrate examples/tests (flutter/flutter#108197) * d155bc1 Revert "Upgrade Gradle and AGP versions to 7.5/7.2 and migrate examples/tests (#108197)" (flutter/flutter#108349) * 4056d3f Explain the "patching" protocol in `KeyMessageManager.keyMessageHandler` and add an example (flutter/flutter#105280) * b035ef1 [flutter_tools] Remove more shuffles (flutter/flutter#107759) * be14858 Roll Flutter Engine from 7f8925b1f6f3 to 8eca26d130a2 (1 revision) (flutter/flutter#108326) * 3eb638f Roll Flutter Engine from 8eca26d130a2 to f1f9b4de82b6 (5 revisions) (flutter/flutter#108350) * 401b556 Roll Flutter Engine from f1f9b4de82b6 to 11d927ac3e9b (2 revisions) (flutter/flutter#108353) * 925bee9 Roll Flutter Engine from 11d927ac3e9b to 5dcaeae6561b (1 revision) (flutter/flutter#108356) * 5d31b07 [flutter_tools] [dap] Ensure DAP sends app.stop/app.detach during terminate (flutter/flutter#108310) * c8b5d10 Roll Flutter Engine from 5dcaeae6561b to 89e117b89c63 (1 revision) (flutter/flutter#108367) * e3d08fb Hide the debug banner in the PopupMenuButton example (flutter/flutter#108324)

goderbauer requested a review from Piinks as a code owner July 22, 2022 22:07

flutter-dashboardBot added the c: contributor-productivity Team-specific productivity, code health, technical debt. label Jul 22, 2022

goderbauer requested a review from jmagman July 22, 2022 22:08

goderbauer mentioned this pull request Jul 22, 2022
Run update-packages --force-upgrade #108178
Closed
8 tasks

goderbauer force-pushed the upgrade branch from 19b854d to e5af265Compare July 22, 2022 22:24

flutter-dashboardBot added a: tests "flutter test", flutter_test, or one of our tests framework flutter/packages/flutter repository. See also f: labels. tool Affects the "flutter" command-line tool. See also t: labels. labels Jul 22, 2022

jmagman approved these changes Jul 22, 2022
View reviewed changes

Comment threaddev/bots/analyze.dart Outdated
jmagmanJul 22, 2022
Copy link
Copy Markdown
Member
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉

RockerFlower mentioned this pull request Jul 24, 2022
[iOS] Update template icons #107873
Merged
8 tasks

goderbauer added 3 commits July 25, 2022 09:25

Fix analyzer problem
2695534

fix new avoid_redundant_argument_values warnings
24a6264

flutter update-packages --force-upgrade
be893af

goderbauer force-pushed the upgrade branch from e5af265 to be893afCompare July 25, 2022 16:29

goderbauer added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 25, 2022

goderbauer merged commit 8a7b359 into flutter:masterJul 25, 2022

goderbauer deleted the upgrade branch July 25, 2022 17:10

engine-flutter-autoroll mentioned this pull request Jul 25, 2022
Roll Flutter from bbec650b64bc to 8a7b35933c5d (177 revisions) flutter/packages#2373
Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 25, 2022
8a7b359flutter update-packages --force-upgrade + analyzer fix (flutt…
46b53e7
…er/flutter#108198)

engine-flutter-autoroll mentioned this pull request Jul 25, 2022
Roll Flutter from bbec650b64bc to b3f5d3f854b7 (178 revisions) flutter/packages#2374
Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 25, 2022
8a7b359flutter update-packages --force-upgrade + analyzer fix (flutt…
4db3ba0
…er/flutter#108198)

engine-flutter-autoroll mentioned this pull request Jul 25, 2022
Roll Flutter from bbec650b64bc to 2f4299ad354d (179 revisions) flutter/packages#2375
Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 25, 2022
8a7b359flutter update-packages --force-upgrade + analyzer fix (flutt…
9197fd9
…er/flutter#108198)

engine-flutter-autoroll mentioned this pull request Jul 25, 2022
Roll Flutter from bbec650b64bc to e74b9b5bef46 (180 revisions) flutter/packages#2376
Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 25, 2022
8a7b359flutter update-packages --force-upgrade + analyzer fix (flutt…
aafa3b4
…er/flutter#108198)

engine-flutter-autoroll mentioned this pull request Jul 25, 2022
Roll Flutter from bbec650b64bc to e3b851a63413 (181 revisions) flutter/packages#2378
Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 25, 2022
8a7b359flutter update-packages --force-upgrade + analyzer fix (flutt…
b0c2b62
…er/flutter#108198)

engine-flutter-autoroll mentioned this pull request Jul 25, 2022
Roll Flutter from bbec650b64bc to 43d6e2b11385 (182 revisions) flutter/packages#2379
Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 25, 2022
8a7b359flutter update-packages --force-upgrade + analyzer fix (flutt…
2731314
…er/flutter#108198)

christopherfujino mentioned this pull request Jul 25, 2022
Roll pub packages #108200
Closed

This was referenced Jul 26, 2022
Roll Flutter from fa39206a2a34 to e3d08fb6d325 (23 revisions) flutter-team-archive/plugins#6147
Merged
Roll Flutter from bbec650b64bc to e3d08fb6d325 (197 revisions) flutter/packages#2383
Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Jul 26, 2022
8a7b359flutter update-packages --force-upgrade + analyzer fix (flutt…
da4bf21
…er/flutter#108198)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 26, 2022
8a7b359flutter update-packages --force-upgrade + analyzer fix (flutt…
80e0930
…er/flutter#108198)

engine-flutter-autoroll mentioned this pull request Jul 26, 2022
Roll Flutter from bbec650b64bc to 2f551d30086a (198 revisions) flutter/packages#2384
Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 26, 2022
8a7b359flutter update-packages --force-upgrade + analyzer fix (flutt…
0c31892
…er/flutter#108198)

engine-flutter-autoroll mentioned this pull request Jul 26, 2022
Roll Flutter from bbec650b64bc to 527ee1d7286e (199 revisions) flutter/packages#2387
Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 26, 2022
8a7b359flutter update-packages --force-upgrade + analyzer fix (flutt…
ff49d2e
…er/flutter#108198)

engine-flutter-autoroll mentioned this pull request Jul 26, 2022
Roll Flutter from bbec650b64bc to 87938cec4426 (200 revisions) flutter/packages#2389
Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 26, 2022
8a7b359flutter update-packages --force-upgrade + analyzer fix (flutt…
42ad924
…er/flutter#108198)

engine-flutter-autoroll mentioned this pull request Jul 26, 2022
Roll Flutter from bbec650b64bc to e05ae3cac799 (202 revisions) flutter/packages#2390
Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 26, 2022
8a7b359flutter update-packages --force-upgrade + analyzer fix (flutt…
9635480
…er/flutter#108198)

engine-flutter-autoroll mentioned this pull request Jul 26, 2022
Roll Flutter from bbec650b64bc to fe16c206ea19 (203 revisions) flutter/packages#2391
Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 26, 2022
8a7b359flutter update-packages --force-upgrade + analyzer fix (flutt…
599fbb8
…er/flutter#108198)

camsim99 pushed a commit to camsim99/flutter that referenced this pull request Aug 10, 2022
flutter update-packages --force-upgrade + analyzer fix (flutter#108198)
64ab64e

Navigation Menu

Uh oh!

flutter update-packages --force-upgrade + analyzer fix - #108198

flutter update-packages --force-upgrade + analyzer fix#108198
goderbauer merged 3 commits into
flutter:masterfrom
goderbauer:upgrade

goderbauer commented Jul 22, 2022•
edited
Loading

Uh oh!

goderbauer commented Jul 22, 2022

Uh oh!

goderbauer commented Jul 22, 2022

Uh oh!

jmagman left a comment

Uh oh!

jmagmanJul 22, 2022

Uh oh!

jmagman commented Jul 23, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

goderbauer commented Jul 22, 2022• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

goderbauer commented Jul 22, 2022

Uh oh!

goderbauer commented Jul 22, 2022

Uh oh!

jmagman left a comment

Choose a reason for hiding this comment

Uh oh!

jmagmanJul 22, 2022

Choose a reason for hiding this comment

Uh oh!

jmagman commented Jul 23, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

goderbauer commented Jul 22, 2022•
edited
Loading