Skip to content

Deprecate these old APIs - #116793

Merged
auto-submit[bot] merged 1 commit into
flutter:masterfrom
Hixie:deprecations
Apr 6, 2023
Merged

Deprecate these old APIs#116793
auto-submit[bot] merged 1 commit into
flutter:masterfrom
Hixie:deprecations

Conversation

@Hixie

@HixieHixie commented Dec 9, 2022

Copy link
Copy Markdown
Contributor

Upstream clients have been updated now.

@flutter-dashboardflutter-dashboardBot added a: tests "flutter test", flutter_test, or one of our tests a: text input Entering text in a text field or keyboard related problems d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos documentation p: cupertino_ui cupertino_ui package in flutter/packages f: scrolling Viewports, list views, slivers, etc. framework flutter/packages/flutter repository. See also f: labels. c: contributor-productivity Team-specific productivity, code health, technical debt. labels Dec 9, 2022
@Hixie
Hixieforce-pushed the deprecations branch 2 times, most recently from bcc7bd4 to 0f62a17CompareDecember 11, 2022 05:06
@Hixie
Hixieforce-pushed the deprecations branch 5 times, most recently from 0a92b35 to f10a45bCompareFebruary 17, 2023 21:30
@Hixie
Hixieforce-pushed the deprecations branch 5 times, most recently from 68d5eb0 to 4636bc2CompareMarch 22, 2023 23:32
@goderbauer

goderbauer commented Mar 31, 2023

Copy link
Copy Markdown
Member

go_router has been fixed up here (landed): flutter/packages#3599
fix for pigeon has been suggested here (pending feedback): flutter/packages#3600

I'll close my attempt of doing the same thing at #123812.

@Hixie

Hixie commented Mar 31, 2023

Copy link
Copy Markdown
ContributorAuthor

Fixes #108327

@goderbauergoderbauer mentioned this pull request Mar 31, 2023
Merged
@Hixie
Hixieforce-pushed the deprecations branch 2 times, most recently from 2d79423 to f87b973CompareApril 2, 2023 02:19
@goderbauer

goderbauer commented Apr 3, 2023

Copy link
Copy Markdown
Member

The pigeon fix rolled in with #124031. I would expect that rebasing this will turn all checks green now.

@HixieHixie added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 4, 2023
@auto-submit

auto-submitBot commented Apr 4, 2023

Copy link
Copy Markdown
Contributor

auto label is removed for flutter/flutter, pr: 116793, due to - The status or check suite Mac framework_tests_libraries has failed. Please fix the issues identified (or deflake) before re-applying this label.

@auto-submitauto-submitBot removed the autosubmit Merge PR when tree becomes green via auto submit App label Apr 4, 2023
@Hixie
Hixie marked this pull request as ready for review April 5, 2023 05:01
@Hixie
Hixieforce-pushed the deprecations branch 2 times, most recently from cac0bfc to 327d204CompareApril 5, 2023 05:03
@HixieHixie added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 5, 2023
@auto-submitauto-submitBot removed the autosubmit Merge PR when tree becomes green via auto submit App label Apr 5, 2023
@auto-submit

auto-submitBot commented Apr 5, 2023

Copy link
Copy Markdown
Contributor

auto label is removed for flutter/flutter, pr: 116793, due to - The status or check suite ci.yaml validation has failed. Please fix the issues identified (or deflake) before re-applying this label.

@goderbauergoderbauer added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 5, 2023
@auto-submit

auto-submitBot commented Apr 5, 2023

Copy link
Copy Markdown
Contributor

auto label is removed for flutter/flutter, pr: 116793, due to - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label.

@auto-submitauto-submitBot removed the autosubmit Merge PR when tree becomes green via auto submit App label Apr 5, 2023
@Hixie
Hixieforce-pushed the deprecations branch 2 times, most recently from d776cf1 to 65062c3CompareApril 6, 2023 00:17
@HixieHixie added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 6, 2023
@auto-submitauto-submitBot removed the autosubmit Merge PR when tree becomes green via auto submit App label Apr 6, 2023
@auto-submit

auto-submitBot commented Apr 6, 2023

Copy link
Copy Markdown
Contributor

auto label is removed for flutter/flutter, pr: 116793, due to - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label.

@Hixie
Deprecate these old APIs
56eb73d
Upstream clients have been updated now.
@goderbauergoderbauer added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 6, 2023
@auto-submit
auto-submitBot merged commit 806c1f8 into flutter:masterApr 6, 2023
This was referenced Apr 6, 2023
Closed
Merged
@engine-flutter-autorollengine-flutter-autoroll mentioned this pull request Apr 7, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 7, 2023
@engine-flutter-autoroll
806c1f8Deprecate these old APIs (flutter/flutter#116793)
54cb140
exaby73 pushed a commit to NevercodeHQ/flutter that referenced this pull request Apr 17, 2023
@Hixie@exaby73
Deprecate these old APIs (flutter#116793)
0931402
Deprecate these old APIs
@goderbauergoderbauer mentioned this pull request May 8, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023
@engine-flutter-autoroll
806c1f8Deprecate these old APIs (flutter/flutter#116793)
b52fb72
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023
@engine-flutter-autoroll
806c1f8Deprecate these old APIs (flutter/flutter#116793)
a1e351e
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@goderbauergoderbauergoderbauer approved these changes

Assignees

No one assigned

Labels

a: tests"flutter test", flutter_test, or one of our testsa: text inputEntering text in a text field or keyboard related problemsautosubmitMerge PR when tree becomes green via auto submit Appc: contributor-productivityTeam-specific productivity, code health, technical debt.d: api docsIssues with https://api.flutter.dev/d: examplesSample code and demosf: scrollingViewports, list views, slivers, etc.frameworkflutter/packages/flutter repository. See also f: labels.p: cupertino_uicupertino_ui package in flutter/packages

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Hixie@goderbauer