Uh oh!
There was an error while loading. Please reload this page.
Revert "[web:tools] always use CanvasKit from the cache when building web apps (#93002)" - #117693
Merged
Merged
Conversation
mdebbar
commented
Dec 28, 2022
ContributorAuthor
@eyebrowsoffire in order for this to fully work, we need to change our engine build so that the canvaskit files are generated in |
eyebrowsoffire
commented
Dec 28, 2022
Contributor
Sounds good to me. It sounds like @zanderso has some notes on that PR and so we'll wait on merging this until those are resolved. |
christopherfujino
commented
Jan 19, 2023
Contributor
@mdebbar are you still planning to land this? |
mdebbar
marked this pull request as draft
January 30, 2023 22:45
… web apps (flutter#93002)" This reverts commit 7737893.
mdebbar
marked this pull request as ready for review
March 3, 2023 21:26
mdebbar
commented
Mar 3, 2023
ContributorAuthor
cc @yjbanov I would love to get your review on this one since you are the author of the PR being reverted. |
yjbanov
reviewed
Mar 7, 2023
yjbanov
left a comment
Contributor
There was a problem hiding this comment.
I think you missed a spot. Otherwise, LGTM.
| @override | ||
| Future<void> build(Environment environment) async { | ||
| // TODO(yjbanov): https://github.com/flutter/flutter/issues/52588 |
Contributor
There was a problem hiding this comment.
There's a similar TODO here that also needs to be cleaned up:
ContributorAuthor
There was a problem hiding this comment.
Ah, that TODO was added in a different PR than the one I'm reverting. That's why I didn't catch it.
I also made other changes:
- Use the new
Artifacts.canvasKitPathto accurately locate the canvaskit files. - Stop removing the
/flutter_web_sdk/segment from paths inbin/cache(it's not needed anymore after Skwasm Renderer - initial implementation flutter-team-archive/engine#39072).
@yjbanov PTAL :)
engine-flutter-autoroll added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 9, 2023
…building web apps (#93002)" (flutter/flutter#117693)
engine-flutter-autoroll added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 10, 2023
…building web apps (#93002)" (flutter/flutter#117693)
engine-flutter-autoroll added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 10, 2023
…building web apps (#93002)" (flutter/flutter#117693)
engine-flutter-autoroll added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 10, 2023
…building web apps (#93002)" (flutter/flutter#117693)
hannah-hyj pushed a commit
to hannah-hyj/flutter
that referenced
this pull request
Mar 11, 2023
… web apps (flutter#93002)" (flutter#117693) Revert "[web:tools] always use CanvasKit from the cache when building web apps (flutter#93002)"
engine-flutter-autoroll added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 11, 2023
…building web apps (#93002)" (flutter/flutter#117693)
engine-flutter-autoroll added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 12, 2023
…building web apps (#93002)" (flutter/flutter#117693)
engine-flutter-autoroll added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 10, 2023
…building web apps (#93002)" (flutter/flutter#117693)
engine-flutter-autoroll added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 10, 2023
…building web apps (#93002)" (flutter/flutter#117693)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 7737893.
Now that CanvasKit is built from sources, let's revert #93002 so that the locally built CanvasKit is copied to the app's
build/web/folder.Depends on flutter-team-archive/engine#38448
Part of #118799