Skip to content

Correctly propagate verbosity to subtasks in flutter.gradle - #117897

Merged
auto-submit[bot] merged 5 commits into
flutter:masterfrom
mraleph:propagate-verbosity
Jan 4, 2023
Merged

Correctly propagate verbosity to subtasks in flutter.gradle#117897
auto-submit[bot] merged 5 commits into
flutter:masterfrom
mraleph:propagate-verbosity

Conversation

@mraleph

@mralephmraleph commented Jan 3, 2023

Copy link
Copy Markdown
Member

The code used to say verbose isVerbose() when configuring a subtask. This does not mean what the author intended it to mean - it was simply doing an equivalent of verbose = verbose, setting verbose to its own value. The code should prefix isVerbose with this to get the intended behaviour.

Discovered when trying to debug #116616

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

@christopherfujinochristopherfujino left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, I can see you really shaved this yak, thanks so much :)

@goderbauergoderbauer added the tool Affects the "flutter" command-line tool. See also t: labels. label Jan 3, 2023
@christopherfujinochristopherfujino added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 3, 2023
@auto-submitauto-submitBot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jan 3, 2023
@auto-submit

Copy link
Copy Markdown
Contributor

auto label is removed for flutter/flutter, pr: 117897, Failed to merge pr#: 117897 with Pull request could not be merged: Required status check "ci.yaml validation" is expected..

@mraleph
mralephforce-pushed the propagate-verbosity branch from 7acc655 to ad2a0beCompareJanuary 4, 2023 08:04
@mralephmraleph added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 4, 2023
@auto-submit

Copy link
Copy Markdown
Contributor

auto label is removed for flutter/flutter, pr: 117897, due to - The status or check suite Linux analyze has failed. Please fix the issues identified (or deflake) before re-applying this label.

@auto-submitauto-submitBot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jan 4, 2023
@mralephmraleph added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 4, 2023
@auto-submit

Copy link
Copy Markdown
Contributor

auto label is removed for flutter/flutter, pr: 117897, due to - The status or check suite Linux analyze has failed. Please fix the issues identified (or deflake) before re-applying this label.

@auto-submitauto-submitBot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jan 4, 2023
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmitMerge PR when tree becomes green via auto submit ApptoolAffects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@mraleph@christopherfujino@goderbauer