Skip to content

Reland Button padding M3 - #119656

Merged
XilaiZhang merged 1 commit into
masterfrom
revert-119597-revert-119498-button_reland
Feb 22, 2023
Merged

Reland Button padding M3#119656
XilaiZhang merged 1 commit into
masterfrom
revert-119597-revert-119498-button_reland

Conversation

@CaseyHillers

@CaseyHillersCaseyHillers commented Jan 31, 2023

Copy link
Copy Markdown
Contributor

Reverts #119597

I'll land this when the LSC tooling is ready, and the Flutter roll is up to date.

@flutter-dashboardflutter-dashboardBot added a: text input Entering text in a text field or keyboard related problems d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos documentation p: material_ui material_ui package in flutter/packages framework flutter/packages/flutter repository. See also f: labels. c: contributor-productivity Team-specific productivity, code health, technical debt. labels Jan 31, 2023

@esouthrenesouthren left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@guidezplguidezpl left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

 _ ___ _____ __ __ | | / __|_ _| \/ |
| |_| (_ | | | | |\/| |
|____\___| |_| |_| |_|

@CaseyHillers
CaseyHillersforce-pushed the revert-119597-revert-119498-button_reland branch from 9c3400c to d6723b9CompareFebruary 17, 2023 21:26
@CaseyHillers

Copy link
Copy Markdown
ContributorAuthor

@XilaiZhang this is the first LSSC. Can you merge it in when you're ready?

@XilaiZhang

Copy link
Copy Markdown
Contributor

Casey built a LSSC tool yesterday, we will merge in this PR today

@XilaiZhangXilaiZhang added the autosubmit Merge PR when tree becomes green via auto submit App label Feb 22, 2023
@auto-submitauto-submitBot removed the autosubmit Merge PR when tree becomes green via auto submit App label Feb 22, 2023
@auto-submit

Copy link
Copy Markdown
Contributor

auto label is removed for flutter/flutter, pr: 119656, due to - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label.

@XilaiZhang

Copy link
Copy Markdown
Contributor

will squash and merge

@XilaiZhang
XilaiZhang merged commit 9241426 into masterFeb 22, 2023
@XilaiZhang
XilaiZhang deleted the revert-119597-revert-119498-button_reland branch February 22, 2023 21:51
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 23, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 23, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 23, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 24, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 24, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 24, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 24, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 24, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 24, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 25, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 25, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 26, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 26, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 26, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 27, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 27, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 27, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 27, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 27, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 27, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 27, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a: text inputEntering text in a text field or keyboard related problemsc: contributor-productivityTeam-specific productivity, code health, technical debt.d: api docsIssues with https://api.flutter.dev/d: examplesSample code and demosframeworkflutter/packages/flutter repository. See also f: labels.p: material_uimaterial_ui package in flutter/packages

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@CaseyHillers@XilaiZhang@guidezpl@esouthren