Uh oh!
There was an error while loading. Please reload this page.
fix spelling typo - #120062
Conversation
There was a problem hiding this comment.
LGTM. But the _index field is not nullable. /cc @justinmc
justinmc
commented
Feb 7, 2023
I guess I made several mistakes here 😊. I think this would be best actually: // The index of the current value, or -1 if the list is empty.int _index =-1;Notice that in the |
HansMuller
commented
Feb 16, 2023
@suragch - can you address #120062 (comment)? |
This address the comment here: flutter#120062 (comment)
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
I've updated the PR to address the comments by @LongCatIsLooong and @justinmc @Hixie indicated that this change doesn't need an additional test: https://discord.com/channels/608014603317936148/608021635370582020/1075853169055244359 |
Hixie
commented
Feb 17, 2023
test-exempt: code refactor with no semantic change |
Renzo-Olivares
commented
Feb 17, 2023
@suragch looks like some tests are failing, though they seem unrelated to the changes in this PR. Do you mind syncing up to the latest commit and seeing if that helps? |
suragch
commented
Feb 21, 2023
@Renzo-Olivares Tests are passing after syncing. |
"empty" was spelled wrong.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.