Skip to content

Reland "Remove references to Observatory (#118577)" - #121606

Merged
bkonyi merged 3 commits into
masterfrom
reland_obs
Feb 28, 2023
Merged

Reland "Remove references to Observatory (#118577)" #121606
bkonyi merged 3 commits into
masterfrom
reland_obs

Conversation

@bkonyi

Copy link
Copy Markdown
Contributor

Relands change reverted in #121555, which was breaking the Intellij plugin due to an event parameter being renamed.

@flutter-dashboardflutter-dashboardBot added framework flutter/packages/flutter repository. See also f: labels. platform-ios iOS applications specifically c: contributor-productivity Team-specific productivity, code health, technical debt. tool Affects the "flutter" command-line tool. See also t: labels. labels Feb 28, 2023

@CaseyHillersCaseyHillers left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bkonyibkonyi added the autosubmit Merge PR when tree becomes green via auto submit App label Feb 28, 2023
@bkonyi
bkonyi merged commit ecd7518 into masterFeb 28, 2023
@bkonyi
bkonyi deleted the reland_obs branch February 28, 2023 16:57
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 1, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 1, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 1, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 1, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 1, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 1, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 1, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 2, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 2, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 2, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 2, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 2, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 2, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 2, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 3, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 3, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023
auto-submitBot pushed a commit to flutter-team-archive/engine that referenced this pull request Mar 29, 2024
As of flutter/flutter#121606 the flutter tool no longer registers for the legacy `_dartobservatory._tcp` DNS type. Remove the fallback and just register for the preferred `_dartVmService._tcp`.
See also dart-lang/sdk#50233
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmitMerge PR when tree becomes green via auto submit Appc: contributor-productivityTeam-specific productivity, code health, technical debt.frameworkflutter/packages/flutter repository. See also f: labels.platform-iosiOS applications specificallytoolAffects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@bkonyi@CaseyHillers