Skip to content

Reland "Update test font (#121306)" - #122068

Merged
auto-submit[bot] merged 2 commits into
flutter:masterfrom
LongCatIsLooong:reland-121306
Mar 9, 2023
Merged

Reland "Update test font (#121306)"#122068
auto-submit[bot] merged 2 commits into
flutter:masterfrom
LongCatIsLooong:reland-121306

Conversation

@LongCatIsLooong

@LongCatIsLooongLongCatIsLooong commented Mar 7, 2023

Copy link
Copy Markdown
Contributor

Reverted in #122053. Diff: 24e2ca6

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboardflutter-dashboardBot added a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) a: text input Entering text in a text field or keyboard related problems p: cupertino_ui cupertino_ui package in flutter/packages p: material_ui material_ui package in flutter/packages f: routes Navigator, Router, and related APIs. f: scrolling Viewports, list views, slivers, etc. framework flutter/packages/flutter repository. See also f: labels. labels Mar 7, 2023
justinmc
justinmc approved these changes Mar 9, 2023
View reviewed changes

@justinmcjustinmc left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 . Thank you for posting the diff in the description!

@LongCatIsLooongLongCatIsLooong added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 9, 2023
@auto-submit
auto-submitBot merged commit f4551e6 into flutter:masterMar 9, 2023
@LongCatIsLooong
LongCatIsLooong deleted the reland-121306 branch March 9, 2023 20:12
@engine-flutter-autorollengine-flutter-autoroll mentioned this pull request Mar 10, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 10, 2023
@engine-flutter-autoroll
f4551e6Reland "Update test font (#121306)" (flutter/flutter#122068)
0c0d12c
@engine-flutter-autorollengine-flutter-autoroll mentioned this pull request Mar 10, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 10, 2023
@engine-flutter-autoroll
f4551e6Reland "Update test font (#121306)" (flutter/flutter#122068)
4aeb23a
@engine-flutter-autorollengine-flutter-autoroll mentioned this pull request Mar 10, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 10, 2023
@engine-flutter-autoroll
f4551e6Reland "Update test font (#121306)" (flutter/flutter#122068)
035d668
hannah-hyj pushed a commit to hannah-hyj/flutter that referenced this pull request Mar 11, 2023
@LongCatIsLooong@hannah-hyj
Reland "Update test font (flutter#121306)" (flutter#122068)
a473a5b
Reland "Update test font (flutter#121306)"
@engine-flutter-autorollengine-flutter-autoroll mentioned this pull request Mar 11, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 11, 2023
@engine-flutter-autoroll
f4551e6Reland "Update test font (#121306)" (flutter/flutter#122068)
acc6e92
@engine-flutter-autorollengine-flutter-autoroll mentioned this pull request Mar 12, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 12, 2023
@engine-flutter-autoroll
f4551e6Reland "Update test font (#121306)" (flutter/flutter#122068)
bb2403c
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023
@engine-flutter-autoroll
f4551e6Reland "Update test font (#121306)" (flutter/flutter#122068)
263d1df
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023
@engine-flutter-autoroll
f4551e6Reland "Update test font (#121306)" (flutter/flutter#122068)
64f21e6
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@justinmcjustinmcjustinmc approved these changes
@Renzo-OlivaresRenzo-OlivaresAwaiting requested review from Renzo-Olivares

Assignees

No one assigned

Labels

a: accessibilityAccessibility, e.g. VoiceOver or TalkBack. (aka a11y)a: text inputEntering text in a text field or keyboard related problemsautosubmitMerge PR when tree becomes green via auto submit Appf: routesNavigator, Router, and related APIs.f: scrollingViewports, list views, slivers, etc.frameworkflutter/packages/flutter repository. See also f: labels.p: cupertino_uicupertino_ui package in flutter/packagesp: material_uimaterial_ui package in flutter/packages

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@LongCatIsLooong@justinmc