Update Material 3 bottom sheet by hannah-hyj · Pull Request #122445 · flutter/flutter

hannah-hyj · 2023-03-11T00:31:12Z

issue:#111448

Added a default max width as 640
Added a drag handle, the user can also tap it to dismiss bottom sheet in a11y mode. Added drag handle color and size to bottom sheet theme.

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

guidezpl

Nice! Quick comments about docs and relation with enableDrag

gnprice · 2023-03-13T23:47:37Z

Everything LGTM now except what's covered in existing open threads:
#120855 (comment)
#122445 (comment)

I'll leave @HansMuller and @guidezpl to wrap those up and approve the PR when they think it's ready. Thanks for all your work on this!

guidezpl

Nice work! Just minor nits about formatting and docs

 _ ___ _____ __ __ | | / __|_ _| \/ |
| |_| (_ | | | | |\/| |
|____\___| |_| |_| |_|

auto-submit · 2023-03-17T02:17:51Z

auto label is removed for flutter/flutter, pr: 122445, due to - The status or check suite Windows web_tool_tests_1_2 has failed. Please fix the issues identified (or deflake) before re-applying this label.

Co-authored-by: Pierre-Louis <6655696+guidezpl@users.noreply.github.com>

Update bottom_sheet_test.dart Update bottom_sheet.dart

flutter-dashboardBot added p: material_ui material_ui package in flutter/packages framework flutter/packages/flutter repository. See also f: labels. c: contributor-productivity Team-specific productivity, code health, technical debt. labels Mar 11, 2023

hannah-hyj mentioned this pull request Mar 11, 2023
Update Material 3 bottom sheet #120855
Closed
8 tasks

hannah-hyj requested review from HansMuller, gnprice and guidezpl March 11, 2023 00:46

guidezpl requested changes Mar 13, 2023
View reviewed changes

Comment threadpackages/flutter/lib/src/material/bottom_sheet.dart Outdated
Comment threadpackages/flutter/lib/src/material/bottom_sheet.dart Outdated

hannah-hyj requested a review from guidezpl March 15, 2023 03:23

hannah-hyj force-pushed the bottom-sheet-0306 branch from 052f822 to fe04be7Compare March 15, 2023 03:28

HansMuller reviewed Mar 15, 2023
View reviewed changes

hannah-hyj requested a review from HansMuller March 16, 2023 04:18

guidezpl approved these changes Mar 16, 2023
View reviewed changes

hannah-hyj force-pushed the bottom-sheet-0306 branch from ce7faf5 to 0d7efc7Compare March 16, 2023 21:10

hannah-hyj added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 16, 2023

auto-submitBot removed the autosubmit Merge PR when tree becomes green via auto submit App label Mar 17, 2023

hannah-hyj force-pushed the bottom-sheet-0306 branch from e756a8f to d45e0e6Compare March 17, 2023 02:21

hannah-hyj added 11 commits March 16, 2023 20:21

M3 bottomsheet
3a6ea32

Update bottom_sheet.dart
2060e04

Update bottom_sheet.dart
027bc61

Update bottom_sheet.dart
08371eb

Update bottom_sheet.dart
04a0289

Update bottom_sheet.dart
464e79e

Update bottom_sheet.dart
b9d2444

Update bottom_sheet.dart
19b6a30

Update bottom_sheet.dart
db32ee9

Update bottom_sheet.dart
90c6b43

Update bottom_sheet.dart
9bd3773

hannah-hyjand others added 7 commits March 16, 2023 20:21

Update packages/flutter/lib/src/material/bottom_sheet.dart
7eaf6a4
Co-authored-by: Pierre-Louis <6655696+guidezpl@users.noreply.github.com>

Update packages/flutter/lib/src/material/bottom_sheet.dart
8a5662f
Co-authored-by: Pierre-Louis <6655696+guidezpl@users.noreply.github.com>

Update packages/flutter/lib/src/material/bottom_sheet.dart
eb2bc0f
Co-authored-by: Pierre-Louis <6655696+guidezpl@users.noreply.github.com>

Update packages/flutter/lib/src/material/bottom_sheet.dart
df6e9c1
Co-authored-by: Pierre-Louis <6655696+guidezpl@users.noreply.github.com>

Update packages/flutter/lib/src/material/bottom_sheet.dart
2318b95
Co-authored-by: Pierre-Louis <6655696+guidezpl@users.noreply.github.com>

Update packages/flutter/lib/src/material/bottom_sheet.dart
a2c2c44
Co-authored-by: Pierre-Louis <6655696+guidezpl@users.noreply.github.com>

Update bottom_sheet.dart
2b10969
Update bottom_sheet_test.dart Update bottom_sheet.dart

hannah-hyj force-pushed the bottom-sheet-0306 branch from d45e0e6 to 2b10969Compare March 17, 2023 03:21

hannah-hyj added 2 commits March 17, 2023 12:52

showDragHandle defaults to false
7417683

fix test
8e1905b

hannah-hyj merged commit 9fc1fd1 into flutter:masterMar 19, 2023

engine-flutter-autoroll mentioned this pull request Mar 19, 2023
Roll Flutter from 6bd2b3ca21cc to 87ac905a5a1b (6 revisions) flutter/packages#3489
Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 19, 2023
9fc1fd1Update Material 3 bottom sheet (flutter/flutter#122445)
5228bd9

engine-flutter-autoroll mentioned this pull request Mar 19, 2023
Roll Flutter from 6bd2b3ca21cc to 3e4e0920a4c6 (7 revisions) flutter/packages#3490
Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 19, 2023
9fc1fd1Update Material 3 bottom sheet (flutter/flutter#122445)
eb26316

gnprice mentioned this pull request Mar 20, 2023
ModalBottomSheetRoute: Allow content to consume top notch with SafeArea #122225
Closed
8 tasks

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023
9fc1fd1Update Material 3 bottom sheet (flutter/flutter#122445)
68799d4

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023
9fc1fd1Update Material 3 bottom sheet (flutter/flutter#122445)
7d26a14

TahaTesser mentioned this pull request May 17, 2023
[3.10.0] ModalBottomSheet rebuilds on drag #126833
Closed
2 tasks

huycozy mentioned this pull request May 29, 2024
dragHandleSize can't be larger than 48 #149170
Closed

gnprice mentioned this pull request Aug 12, 2024
action_sheet: Redesign bottom sheet zulip/zulip-flutter#853
Merged

Navigation Menu

Uh oh!

Update Material 3 bottom sheet - #122445

Update Material 3 bottom sheet #122445
hannah-hyj merged 20 commits into
flutter:masterfrom
hannah-hyj:bottom-sheet-0306

hannah-hyj commented Mar 11, 2023

Uh oh!

guidezpl left a comment

Uh oh!

Uh oh!

Uh oh!

gnprice commented Mar 13, 2023•
edited
Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

guidezpl left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

auto-submitBot commented Mar 17, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

hannah-hyj commented Mar 11, 2023

Pre-launch Checklist

Uh oh!

guidezpl left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

gnprice commented Mar 13, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

guidezpl left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

auto-submitBot commented Mar 17, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

gnprice commented Mar 13, 2023•
edited
Loading