Skip to content

Add support for secondary tab bar - #122756

Merged
auto-submit[bot] merged 9 commits into
flutter:masterfrom
guidezpl:secondary-tab-bar
Mar 23, 2023
Merged

Add support for secondary tab bar#122756
auto-submit[bot] merged 9 commits into
flutter:masterfrom
guidezpl:secondary-tab-bar

Conversation

@guidezpl

@guidezplguidezpl commented Mar 15, 2023•
edited
Loading

Copy link
Copy Markdown
Member

Description

  • Introduce secondary constructor for TabBar
  • Generate defaults from design tokens for secondary tab bar
  • Uses correct defaults throughout
  • Adds a M3 sample showcasing nested (primary + secondary) tabs
    image

Related Issues

Tests

  • TODO

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboardflutter-dashboardBot added d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos documentation p: material_ui material_ui package in flutter/packages framework flutter/packages/flutter repository. See also f: labels. c: contributor-productivity Team-specific productivity, code health, technical debt. labels Mar 15, 2023
@flutter-dashboard

This comment was marked as resolved.

Sign in to view
@TahaTesser

TahaTesser commented Mar 15, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor

Thanks for pushing this! I'll add the tests and get second review and land this soon.

(Just made an empty commit to make sure I can update the PR)

@TahaTesser
TahaTesser requested a review from PiinksMarch 22, 2023 14:46
Piinks
Piinks reviewed Mar 22, 2023
View reviewed changes
Comment threadpackages/flutter/lib/src/material/tabs.dart Outdated
Piinks
Piinks reviewed Mar 22, 2023
View reviewed changes
Comment threadpackages/flutter/lib/src/material/tabs.dart Outdated
Piinks
Piinks reviewed Mar 22, 2023
View reviewed changes
Comment threadpackages/flutter/lib/src/material/tabs.dart Outdated
Piinks
Piinks reviewed Mar 22, 2023
View reviewed changes
Comment threadpackages/flutter/lib/src/material/tabs.dart
Piinks
Piinks reviewed Mar 22, 2023
View reviewed changes
Comment threadpackages/flutter/test/material/tab_bar_theme_test.dart Outdated
Piinks
Piinks reviewed Mar 22, 2023
View reviewed changes

@PiinksPiinks left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly some style nits, but over all this is nice!

@PiinksPiinks mentioned this pull request Mar 22, 2023
Merged
8 tasks
@TahaTesser

TahaTesser commented Mar 22, 2023

Copy link
Copy Markdown
Contributor

Mostly some style nits, but over all this is nice!

Thank you so much for adding fixing the style!

Piinks
Piinks approved these changes Mar 23, 2023
View reviewed changes

@PiinksPiinks left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! LGTM, thank you!

@PiinksPiinks added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 23, 2023
@auto-submit
auto-submitBot merged commit 02d5c75 into flutter:masterMar 23, 2023
@engine-flutter-autorollengine-flutter-autoroll mentioned this pull request Mar 24, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 24, 2023
@engine-flutter-autoroll
02d5c75Add support for secondary tab bar (flutter/flutter#122756)
bc4b9d9
@HansMullerHansMuller mentioned this pull request Mar 24, 2023
Closed
This was referenced Mar 28, 2023
Merged
Merged
@reidbakerreidbaker mentioned this pull request Apr 5, 2023
Merged
8 tasks
@guidezpl
guidezpl deleted the secondary-tab-bar branch April 12, 2023 20:10
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023
@engine-flutter-autoroll
02d5c75Add support for secondary tab bar (flutter/flutter#122756)
3c2a1c5
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023
@engine-flutter-autoroll
02d5c75Add support for secondary tab bar (flutter/flutter#122756)
ebb2e5c
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@PiinksPiinksPiinks approved these changes
@TahaTesserTahaTesserAwaiting requested review from TahaTesser

Assignees

No one assigned

Labels

autosubmitMerge PR when tree becomes green via auto submit Appc: contributor-productivityTeam-specific productivity, code health, technical debt.d: api docsIssues with https://api.flutter.dev/d: examplesSample code and demosframeworkflutter/packages/flutter repository. See also f: labels.p: material_uimaterial_ui package in flutter/packages

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Update TabBar to support Material 3

3 participants

@guidezpl@TahaTesser@Piinks