Uh oh!
There was an error while loading. Please reload this page.
Make Element tree root generic - #123352
Merged
Merged
Conversation
4 tasks
goderbauer
marked this pull request as ready for review
March 23, 2023 20:27
This was referenced Mar 23, 2023
goderbauer
commented
Mar 23, 2023
MemberAuthor
The fix for the flutter_plugins check is flutter/packages#3539. |
gspencergoog
approved these changes
Mar 24, 2023
Contributor
There was a problem hiding this comment.
You could also mention that it is no longer used by Flutter.
goderbauerforce-pushed
the
genericElementRoot
branch
from
March 25, 2023 20:35
f6315eb to
f5f884eComparegoderbauerforce-pushed
the
genericElementRoot
branch
from
March 27, 2023 17:37
f5f884e to
b657ffaComparegoderbauer
commented
Mar 27, 2023
MemberAuthor
flutter/packages#3539 has rolled into the framework in #123542. |
Contributor
auto label is removed for flutter/flutter, pr: 123352, due to - The status or check suite Linux customer_testing has failed. Please fix the issues identified (or deflake) before re-applying this label. |
goderbauer
commented
Mar 27, 2023
MemberAuthor
customer_testing failures are (unrelated) flakes hopefully fixed with flutter/tests#239. |
Contributor
auto label is removed for flutter/flutter, pr: 123352, due to - The status or check suite customer_testing-linux has failed. Please fix the issues identified (or deflake) before re-applying this label. |
engine-flutter-autoroll added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 28, 2023
engine-flutter-autoroll added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 28, 2023
engine-flutter-autoroll added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 28, 2023
engine-flutter-autoroll added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 28, 2023
8 tasks
This was referenced Apr 1, 2023
engine-flutter-autoroll added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 10, 2023
engine-flutter-autoroll added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 10, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #121573.
This change allows the root of the element tree to be any
Element(not just aRenderObjectElement). For that, it introduces theRootElementMixin, which can be used to make any Element subclass the root of the element tree. It replaces theRootRenderObjectElement, which is now deprecated in favor of the new mixin. In addition to that, it renames therenderViewElementaccessor on the WidgetsBinding torootElementto remove the implied assumption that the root is aRenderObjectElement.This is in preparation for further changes towards multi-view rendering, where the root of the element tree will not be backed by render objects, see https://docs.flutter.dev/go/multiple-views for the details of that.