Skip to content

flutter tool: make FlutterOptions abstract final - #124178

Merged
auto-submit[bot] merged 6 commits into
masterfrom
flutter_options_abstract_final
Apr 6, 2023
Merged

flutter tool: make FlutterOptions abstract final#124178
auto-submit[bot] merged 6 commits into
masterfrom
flutter_options_abstract_final

Conversation

@kevmoo

@kevmookevmoo commented Apr 5, 2023

Copy link
Copy Markdown
Contributor

Never meant to be instantiated, implemented, or extended

@kevmoo
flutter tool: make FlutterOptions abstract final
060067b
Never meant to be instantiated, implemented, or extended
@flutter-dashboardflutter-dashboardBot added the tool Affects the "flutter" command-line tool. See also t: labels. label Apr 5, 2023
@flutter-dashboard

flutter-dashboardBot commented Apr 5, 2023

Copy link
Copy Markdown

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@kevmoo

kevmoo commented Apr 5, 2023

Copy link
Copy Markdown
ContributorAuthor

Using those fun new Dart language features.

christopherfujino
christopherfujino reviewed Apr 5, 2023
View reviewed changes
Comment threadpackages/flutter_tools/lib/src/runner/flutter_command.dart
christopherfujino
christopherfujino approved these changes Apr 5, 2023
View reviewed changes

@christopherfujinochristopherfujino left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kevmookevmoo added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 5, 2023
@auto-submitauto-submitBot removed the autosubmit Merge PR when tree becomes green via auto submit App label Apr 5, 2023
@auto-submit

auto-submitBot commented Apr 5, 2023

Copy link
Copy Markdown
Contributor

auto label is removed for flutter/flutter, pr: 124178, due to - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label.

@kevmookevmoo added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 5, 2023
@auto-submitauto-submitBot removed the autosubmit Merge PR when tree becomes green via auto submit App label Apr 5, 2023
@auto-submit

auto-submitBot commented Apr 5, 2023

Copy link
Copy Markdown
Contributor

auto label is removed for flutter/flutter, pr: 124178, due to - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label.

@kevmookevmoo added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 5, 2023
@auto-submitauto-submitBot removed the autosubmit Merge PR when tree becomes green via auto submit App label Apr 5, 2023
@auto-submit

auto-submitBot commented Apr 5, 2023

Copy link
Copy Markdown
Contributor

auto label is removed for flutter/flutter, pr: 124178, due to - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label.

@kevmookevmoo added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 5, 2023
@auto-submit

auto-submitBot commented Apr 6, 2023

Copy link
Copy Markdown
Contributor

auto label is removed for flutter/flutter, pr: 124178, due to - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label.

@auto-submitauto-submitBot removed the autosubmit Merge PR when tree becomes green via auto submit App label Apr 6, 2023
@kevmookevmoo added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 6, 2023
@auto-submitauto-submitBot removed the autosubmit Merge PR when tree becomes green via auto submit App label Apr 6, 2023
@auto-submit

auto-submitBot commented Apr 6, 2023

Copy link
Copy Markdown
Contributor

auto label is removed for flutter/flutter, pr: 124178, due to - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label.

@kevmookevmoo added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 6, 2023
@auto-submit
auto-submitBot merged commit d062bfa into masterApr 6, 2023
@auto-submit
auto-submitBot deleted the flutter_options_abstract_final branch April 6, 2023 05:34
zanderso added a commit that referenced this pull request Apr 6, 2023
@zanderso
Revert "flutter tool: make FlutterOptions abstract final (#124178)"
7eb25fb
This reverts commit d062bfa.
@zandersozanderso mentioned this pull request Apr 6, 2023
Merged
@auto-submitauto-submitBot mentioned this pull request Apr 6, 2023
Closed
@zandersozanderso mentioned this pull request Apr 6, 2023
Merged
@engine-flutter-autorollengine-flutter-autoroll mentioned this pull request Apr 6, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 6, 2023
@engine-flutter-autoroll
d062bfaflutter tool: make FlutterOptions abstract final (flutter/flu…
599a1e9
…tter#124178)
@kevmookevmoo mentioned this pull request Apr 6, 2023
Merged
kevmoo added a commit that referenced this pull request Apr 6, 2023
@kevmoo
flutter tool: make FlutterOptions abstract final
3c35a05
Relands #124178 - d062bfa
Unlands #124303 - 419c1eb
flutter tool: make FlutterOptions abstract final
exaby73 pushed a commit to NevercodeHQ/flutter that referenced this pull request Apr 17, 2023
@kevmoo@exaby73
flutter tool: make FlutterOptions abstract final (flutter#124178)
70ab68d
flutter tool: make FlutterOptions abstract final
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023
@engine-flutter-autoroll
d062bfaflutter tool: make FlutterOptions abstract final (flutter/flu…
50cfafc
…tter#124178)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023
@engine-flutter-autoroll
d062bfaflutter tool: make FlutterOptions abstract final (flutter/flu…
67739b4
…tter#124178)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@christopherfujinochristopherfujinochristopherfujino approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

autosubmitMerge PR when tree becomes green via auto submit ApptoolAffects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kevmoo@christopherfujino