Skip to content

MinimumTapTargetGuideline skips nodes at scrollable boundaries - #124615

Merged
chunhtai merged 3 commits into
flutter:masterfrom
chunhtai:issues/107615
Apr 20, 2023
Merged

MinimumTapTargetGuideline skips nodes at scrollable boundaries#124615
chunhtai merged 3 commits into
flutter:masterfrom
chunhtai:issues/107615

Conversation

@chunhtai

@chunhtaichunhtai commented Apr 11, 2023

Copy link
Copy Markdown
Contributor

fixes#107615

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboardflutter-dashboardBot added a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) a: tests "flutter test", flutter_test, or one of our tests framework flutter/packages/flutter repository. See also f: labels. labels Apr 11, 2023
chunhtai
chunhtai commented Apr 17, 2023
View reviewed changes
Comment threadpackages/flutter_test/lib/src/accessibility.dart Outdated
Comment threadpackages/flutter_test/lib/src/accessibility.dart Outdated
pdblasi-google
pdblasi-google approved these changes Apr 17, 2023
View reviewed changes

@pdblasi-googlepdblasi-google left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chunhtaichunhtai added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 17, 2023
@auto-submitauto-submitBot removed the autosubmit Merge PR when tree becomes green via auto submit App label Apr 18, 2023
@auto-submit

auto-submitBot commented Apr 18, 2023

Copy link
Copy Markdown
Contributor

auto label is removed for flutter/flutter, pr: 124615, due to - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label.

@chunhtai

chunhtai commented Apr 19, 2023

Copy link
Copy Markdown
ContributorAuthor

g3fix
cl/525216354

@chunhtai
chunhtai merged commit 8ac94c1 into flutter:masterApr 20, 2023
@engine-flutter-autorollengine-flutter-autoroll mentioned this pull request Apr 20, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 20, 2023
@engine-flutter-autoroll
8ac94c1MinimumTapTargetGuideline skips nodes at scrollable boundaries (
428e47b
flutter/flutter#124615)
@engine-flutter-autorollengine-flutter-autoroll mentioned this pull request Apr 20, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 20, 2023
@engine-flutter-autoroll
8ac94c1MinimumTapTargetGuideline skips nodes at scrollable boundaries (
38d8d51
flutter/flutter#124615)
@engine-flutter-autorollengine-flutter-autoroll mentioned this pull request Apr 20, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 20, 2023
@engine-flutter-autoroll
8ac94c1MinimumTapTargetGuideline skips nodes at scrollable boundaries (
d132c2b
flutter/flutter#124615)
@engine-flutter-autorollengine-flutter-autoroll mentioned this pull request Apr 20, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 20, 2023
@engine-flutter-autoroll
8ac94c1MinimumTapTargetGuideline skips nodes at scrollable boundaries (
cfc0a4c
flutter/flutter#124615)
This was referenced Apr 20, 2023
Closed
Closed
@engine-flutter-autorollengine-flutter-autoroll mentioned this pull request Apr 21, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 21, 2023
@engine-flutter-autoroll
8ac94c1MinimumTapTargetGuideline skips nodes at scrollable boundaries (
c87ab33
flutter/flutter#124615)
@engine-flutter-autorollengine-flutter-autoroll mentioned this pull request Apr 21, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 21, 2023
@engine-flutter-autoroll
8ac94c1MinimumTapTargetGuideline skips nodes at scrollable boundaries (
8ec3e59
flutter/flutter#124615)
@reidbakerreidbaker mentioned this pull request Apr 21, 2023
Merged
8 tasks
@engine-flutter-autorollengine-flutter-autoroll mentioned this pull request Apr 22, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 22, 2023
@engine-flutter-autoroll
8ac94c1MinimumTapTargetGuideline skips nodes at scrollable boundaries (
e7ad740
flutter/flutter#124615)
@engine-flutter-autorollengine-flutter-autoroll mentioned this pull request Apr 22, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 22, 2023
@engine-flutter-autoroll
8ac94c1MinimumTapTargetGuideline skips nodes at scrollable boundaries (
38ca06a
flutter/flutter#124615)
@engine-flutter-autorollengine-flutter-autoroll mentioned this pull request Apr 23, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 23, 2023
@engine-flutter-autoroll
8ac94c1MinimumTapTargetGuideline skips nodes at scrollable boundaries (
19fedeb
flutter/flutter#124615)
@engine-flutter-autorollengine-flutter-autoroll mentioned this pull request Apr 23, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 23, 2023
@engine-flutter-autoroll
8ac94c1MinimumTapTargetGuideline skips nodes at scrollable boundaries (
083a67c
flutter/flutter#124615)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 24, 2023
@engine-flutter-autoroll
8ac94c1MinimumTapTargetGuideline skips nodes at scrollable boundaries (
61b271d
flutter/flutter#124615)
@engine-flutter-autorollengine-flutter-autoroll mentioned this pull request Apr 24, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 24, 2023
@engine-flutter-autoroll
8ac94c1MinimumTapTargetGuideline skips nodes at scrollable boundaries (
d43dade
flutter/flutter#124615)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 24, 2023
@engine-flutter-autoroll
8ac94c1MinimumTapTargetGuideline skips nodes at scrollable boundaries (
90047d6
flutter/flutter#124615)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 24, 2023
@engine-flutter-autoroll
8ac94c1MinimumTapTargetGuideline skips nodes at scrollable boundaries (
528c530
flutter/flutter#124615)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 24, 2023
@engine-flutter-autoroll
8ac94c1MinimumTapTargetGuideline skips nodes at scrollable boundaries (
d15995a
flutter/flutter#124615)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 25, 2023
@engine-flutter-autoroll
8ac94c1MinimumTapTargetGuideline skips nodes at scrollable boundaries (
507b78b
flutter/flutter#124615)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 25, 2023
@engine-flutter-autoroll
8ac94c1MinimumTapTargetGuideline skips nodes at scrollable boundaries (
6558ae9
flutter/flutter#124615)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@pdblasi-googlepdblasi-googlepdblasi-google approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

a: accessibilityAccessibility, e.g. VoiceOver or TalkBack. (aka a11y)a: tests"flutter test", flutter_test, or one of our testsframeworkflutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

MinimumTapTargetGuideline doesn't work if items are scrolled out of the viewport and the viewport doesn't touch the edge of the screen

2 participants

@chunhtai@pdblasi-google