Skip to content

Remove the old canvaskit artifacts to not confuse the web runner. - #124641

Merged
auto-submit[bot] merged 2 commits into
flutter:masterfrom
eyebrowsoffire:remove_old_canvaskit
Apr 12, 2023
Merged

Remove the old canvaskit artifacts to not confuse the web runner.#124641
auto-submit[bot] merged 2 commits into
flutter:masterfrom
eyebrowsoffire:remove_old_canvaskit

Conversation

@eyebrowsoffire

@eyebrowsoffireeyebrowsoffire commented Apr 12, 2023

Copy link
Copy Markdown
Contributor

This fixes#123737

The old canvaskit artifacts were confusing the in-memory filesystem that the web runner uses. Added another artifact set that removes the old canvaskit artifacts if they exist.

@flutter-dashboardflutter-dashboardBot added the tool Affects the "flutter" command-line tool. See also t: labels. label Apr 12, 2023
@flutter-dashboard

flutter-dashboardBot commented Apr 12, 2023

Copy link
Copy Markdown

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@eyebrowsoffireeyebrowsoffire mentioned this pull request Apr 12, 2023
Closed
ditman
ditman approved these changes Apr 12, 2023
View reviewed changes

@ditmanditman left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ditman

ditman commented Apr 12, 2023

Copy link
Copy Markdown
Member

Failing tests LUCI tests look like flakes?

@bernaferrari

bernaferrari commented Apr 12, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor

Yes, rebase and try again. Should work. Everything was failing today.

@eyebrowsoffireeyebrowsoffire added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 12, 2023
@auto-submit
auto-submitBot merged commit ac9b501 into flutter:masterApr 12, 2023
@engine-flutter-autorollengine-flutter-autoroll mentioned this pull request Apr 13, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 13, 2023
@engine-flutter-autoroll
ac9b501Remove the old canvaskit artifacts to not confuse the web run…
4d4dce6
…ner. (flutter/flutter#124641)
exaby73 pushed a commit to exaby73/flutter_nevercode that referenced this pull request Apr 17, 2023
@eyebrowsoffire@exaby73
Remove the old canvaskit artifacts to not confuse the web runner. (fl…
527d99d
…utter#124641)
Remove the old canvaskit artifacts to not confuse the web runner.
@eyebrowsoffire
eyebrowsoffire deleted the remove_old_canvaskit branch December 12, 2025 21:56
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ditmanditmanditman approved these changes

Assignees

No one assigned

Labels

autosubmitMerge PR when tree becomes green via auto submit ApptoolAffects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

framework canvaskit cache is not being cleared with engine rolls

3 participants

@eyebrowsoffire@ditman@bernaferrari