Skip to content

Switch imports from test_api to focused libaries - #125854

Merged
auto-submit[bot] merged 5 commits into
flutter:masterfrom
natebosch:matcher-import
May 4, 2023
Merged

Switch imports from test_api to focused libaries#125854
auto-submit[bot] merged 5 commits into
flutter:masterfrom
natebosch:matcher-import

Conversation

@natebosch

@nateboschnatebosch commented May 2, 2023

Copy link
Copy Markdown
Contributor

Move imports of API available in hooks.dart or scaffolding.dart to use those more narrow libraries.

Move imports of APIs from package:matcher to import directly. The next major version of test_api will remove the exports of matcher APIs.

@natebosch
Switch imports from test_api to focused libaries
f368a7f
Move imports of API available in `hooks.dart` or `scaffolding.dart` to
use those more narrow libraries.
Move imports of APIs from `package:matcher` to import directly. The next
major version of `test_api` will remove the exports of `matcher` APIs.
@flutter-dashboardflutter-dashboardBot added a: tests "flutter test", flutter_test, or one of our tests framework flutter/packages/flutter repository. See also f: labels. labels May 2, 2023
@flutter-dashboard

flutter-dashboardBot commented May 2, 2023

Copy link
Copy Markdown

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@nateboschnatebosch mentioned this pull request May 2, 2023
Merged
goderbauer
goderbauer reviewed May 2, 2023
View reviewed changes
Comment threadpackages/flutter_test/lib/src/_binding_io.dart Outdated
christopherfujino
christopherfujino approved these changes May 2, 2023
View reviewed changes

@christopherfujinochristopherfujino left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nateboschnatebosch added the autosubmit Merge PR when tree becomes green via auto submit App label May 2, 2023
@Hixie

Hixie commented May 2, 2023

Copy link
Copy Markdown
Contributor

test-exempt: preparing for roll

@auto-submitauto-submitBot removed the autosubmit Merge PR when tree becomes green via auto submit App label May 3, 2023
@auto-submit

auto-submitBot commented May 3, 2023

Copy link
Copy Markdown
Contributor

auto label is removed for flutter/flutter, pr: 125854, due to - The status or check suite Windows customer_testing has failed. Please fix the issues identified (or deflake) before re-applying this label.

@natebosch

natebosch commented May 3, 2023

Copy link
Copy Markdown
ContributorAuthor

I don't understand the failure on "Windows customer_testing" - it looks like it may be some infrastructure failure?

@christopherfujino

christopherfujino commented May 3, 2023

Copy link
Copy Markdown
Contributor

I don't understand the failure on "Windows customer_testing" - it looks like it may be some infrastructure failure?

customer_testing compares the registry against the branch point from master. If this was fixed upstream you'd need to rebase (not merge) upstream master to pick up the fix.

@natebosch

natebosch commented May 3, 2023

Copy link
Copy Markdown
ContributorAuthor

you'd need to rebase (not merge)

If it fails again I will try a rebase. Is there any discussion of fixing this so it isn't a requirement to rewrite shared history?

@christopherfujino

christopherfujino commented May 3, 2023

Copy link
Copy Markdown
Contributor

you'd need to rebase (not merge)

If it fails again I will try a rebase. Is there any discussion of fixing this so it isn't a requirement to rewrite shared history?

not sure.

@nateboschnatebosch added the autosubmit Merge PR when tree becomes green via auto submit App label May 3, 2023
@natebosch

natebosch commented May 3, 2023

Copy link
Copy Markdown
ContributorAuthor

It passed this time, so it may have been a flake.

@natebosch

natebosch commented May 3, 2023

Copy link
Copy Markdown
ContributorAuthor

I'm not sure whether "Google testing" is still doing any work, it says "Presubmit Test Passed"...

@goderbauer

goderbauer commented May 4, 2023

Copy link
Copy Markdown
Member

There's a bug that sometimes Frob doesn't sync back a successful test run. I manually set it to green.

@auto-submit
auto-submitBot merged commit 2089eac into flutter:masterMay 4, 2023
@engine-flutter-autorollengine-flutter-autoroll mentioned this pull request May 4, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 4, 2023
@engine-flutter-autoroll
2089eacSwitch imports from test_api to focused libaries (flutter/flu…
d71dbc1
…tter#125854)
@engine-flutter-autorollengine-flutter-autoroll mentioned this pull request May 4, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 4, 2023
@engine-flutter-autoroll
2089eacSwitch imports from test_api to focused libaries (flutter/flu…
689bca9
…tter#125854)
@natebosch
natebosch deleted the matcher-import branch May 4, 2023 16:35
@engine-flutter-autorollengine-flutter-autoroll mentioned this pull request May 4, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 4, 2023
@engine-flutter-autoroll
2089eacSwitch imports from test_api to focused libaries (flutter/flu…
eed419b
…tter#125854)
@engine-flutter-autorollengine-flutter-autoroll mentioned this pull request May 4, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 4, 2023
@engine-flutter-autoroll
2089eacSwitch imports from test_api to focused libaries (flutter/flu…
82d4e57
…tter#125854)
@engine-flutter-autorollengine-flutter-autoroll mentioned this pull request May 4, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 4, 2023
@engine-flutter-autoroll
2089eacSwitch imports from test_api to focused libaries (flutter/flu…
841f4a4
…tter#125854)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 16, 2023
@engine-flutter-autoroll
2089eacSwitch imports from test_api to focused libaries (flutter/flu…
ec88110
…tter#125854)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023
@engine-flutter-autoroll
2089eacSwitch imports from test_api to focused libaries (flutter/flu…
63aa4b6
…tter#125854)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023
@engine-flutter-autoroll
2089eacSwitch imports from test_api to focused libaries (flutter/flu…
fa5b237
…tter#125854)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023
@engine-flutter-autoroll
2089eacSwitch imports from test_api to focused libaries (flutter/flu…
330d633
…tter#125854)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@goderbauergoderbauergoderbauer left review comments
+1 more reviewer
@christopherfujinochristopherfujinochristopherfujino approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

a: tests"flutter test", flutter_test, or one of our testsautosubmitMerge PR when tree becomes green via auto submit Appframeworkflutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@natebosch@Hixie@christopherfujino@goderbauer