Skip to content

tool: DRY up DepfileService - #125922

Merged
auto-submit[bot] merged 6 commits into
masterfrom
kevmoo_tool_depfileservice
May 3, 2023
Merged

tool: DRY up DepfileService#125922
auto-submit[bot] merged 6 commits into
masterfrom
kevmoo_tool_depfileservice

Conversation

@kevmoo

Copy link
Copy Markdown
Contributor

No description provided.

@flutter-dashboardflutter-dashboardBot added the tool Affects the "flutter" command-line tool. See also t: labels. label May 2, 2023
@kevmoo

Copy link
Copy Markdown
ContributorAuthor

There were cases where globals was used when an environment was available, etc.

Comment threadpackages/flutter_tools/lib/src/build_system/targets/common.dart Outdated

@christopherfujinochristopherfujino left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kevmookevmoo added the autosubmit Merge PR when tree becomes green via auto submit App label May 3, 2023
@auto-submitauto-submitBot removed the autosubmit Merge PR when tree becomes green via auto submit App label May 3, 2023
@auto-submit

Copy link
Copy Markdown
Contributor

auto label is removed for flutter/flutter, pr: 125922, due to - The status or check suite Linux analyze has failed. Please fix the issues identified (or deflake) before re-applying this label.

@kevmookevmoo added the autosubmit Merge PR when tree becomes green via auto submit App label May 3, 2023
@auto-submit
auto-submitBot merged commit 4bd9bcd into masterMay 3, 2023
@auto-submit
auto-submitBot deleted the kevmoo_tool_depfileservice branch May 3, 2023 20:54
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 4, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 4, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 4, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 4, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 4, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 4, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 16, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmitMerge PR when tree becomes green via auto submit ApptoolAffects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@kevmoo@christopherfujino