Skip to content

Add debugging for Dart VM timeout flake - #126437

Merged
auto-submit[bot] merged 5 commits into
flutter:masterfrom
vashworth:dart_vm_timeout_debug
May 15, 2023
Merged

Add debugging for Dart VM timeout flake#126437
auto-submit[bot] merged 5 commits into
flutter:masterfrom
vashworth:dart_vm_timeout_debug

Conversation

@vashworth

@vashworthvashworth commented May 10, 2023

Copy link
Copy Markdown
Contributor

Check what is available in the device's iOS DeviceSupport folder to check if symbols were properly fetched. Also, add some logging to track what status the debugger is in.

Debugging for #121231.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboardflutter-dashboardBot added platform-ios iOS applications specifically tool Affects the "flutter" command-line tool. See also t: labels. labels May 10, 2023
@vashworthvashworth changed the title Add debugging for dart vm timeout flakeAdd debugging for Dart VM timeout flakeMay 10, 2023
@vashworth

vashworth commented May 10, 2023

Copy link
Copy Markdown
ContributorAuthor

I described this in the comments in the code, but FYI:

The expected files to be found in the device's iOS DeviceSupport include Symbols (directory), Info.plist, and .finalized.

If any of the expected files are missing or there are additional files (such as .copying_lock or .processing_lock), this may indicate the symbols may still be fetching or something went wrong when fetching them.

@vashworthvashworth mentioned this pull request May 10, 2023
Closed
hellohuanlin
hellohuanlin approved these changes May 11, 2023
View reviewed changes
Comment threadpackages/flutter_tools/lib/src/ios/ios_deploy.dart
Comment threadpackages/flutter_tools/lib/src/ios/ios_deploy.dart
christopherfujino
christopherfujino reviewed May 12, 2023
View reviewed changes
Comment threadpackages/flutter_tools/lib/src/ios/ios_deploy.dart Outdated
christopherfujino
christopherfujino approved these changes May 12, 2023
View reviewed changes

@christopherfujinochristopherfujino left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit about adding a bit more context to one trace, but LGTM

@vashworthvashworth added the autosubmit Merge PR when tree becomes green via auto submit App label May 15, 2023
@auto-submit
auto-submitBot merged commit 5d11325 into flutter:masterMay 15, 2023
@engine-flutter-autorollengine-flutter-autoroll mentioned this pull request May 15, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 15, 2023
@engine-flutter-autoroll
5d11325Add debugging for Dart VM timeout flake (flutter/flutter#126437)
358529c
@engine-flutter-autorollengine-flutter-autoroll mentioned this pull request May 15, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 15, 2023
@engine-flutter-autoroll
5d11325Add debugging for Dart VM timeout flake (flutter/flutter#126437)
1df5aa3
@engine-flutter-autorollengine-flutter-autoroll mentioned this pull request May 15, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 15, 2023
@engine-flutter-autoroll
5d11325Add debugging for Dart VM timeout flake (flutter/flutter#126437)
7ded3d7
@engine-flutter-autorollengine-flutter-autoroll mentioned this pull request May 15, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 15, 2023
@engine-flutter-autoroll
5d11325Add debugging for Dart VM timeout flake (flutter/flutter#126437)
94ff494
@engine-flutter-autorollengine-flutter-autoroll mentioned this pull request May 16, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 16, 2023
@engine-flutter-autoroll
5d11325Add debugging for Dart VM timeout flake (flutter/flutter#126437)
b48ec6b
@engine-flutter-autorollengine-flutter-autoroll mentioned this pull request May 16, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 16, 2023
@engine-flutter-autoroll
5d11325Add debugging for Dart VM timeout flake (flutter/flutter#126437)
36866da
@engine-flutter-autorollengine-flutter-autoroll mentioned this pull request May 16, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 16, 2023
@engine-flutter-autoroll
5d11325Add debugging for Dart VM timeout flake (flutter/flutter#126437)
52d6622
@engine-flutter-autorollengine-flutter-autoroll mentioned this pull request May 16, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 16, 2023
@engine-flutter-autoroll
5d11325Add debugging for Dart VM timeout flake (flutter/flutter#126437)
f245555
@engine-flutter-autorollengine-flutter-autoroll mentioned this pull request May 16, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 16, 2023
@engine-flutter-autoroll
5d11325Add debugging for Dart VM timeout flake (flutter/flutter#126437)
8fd974a
@engine-flutter-autorollengine-flutter-autoroll mentioned this pull request May 16, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 16, 2023
@engine-flutter-autoroll
5d11325Add debugging for Dart VM timeout flake (flutter/flutter#126437)
1dc19dc
@engine-flutter-autorollengine-flutter-autoroll mentioned this pull request May 16, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 16, 2023
@engine-flutter-autoroll
5d11325Add debugging for Dart VM timeout flake (flutter/flutter#126437)
cac4d3d
@engine-flutter-autorollengine-flutter-autoroll mentioned this pull request May 16, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 16, 2023
@engine-flutter-autoroll
5d11325Add debugging for Dart VM timeout flake (flutter/flutter#126437)
b4cd681
@engine-flutter-autorollengine-flutter-autoroll mentioned this pull request May 16, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 16, 2023
@engine-flutter-autoroll
5d11325Add debugging for Dart VM timeout flake (flutter/flutter#126437)
b100d63
@engine-flutter-autorollengine-flutter-autoroll mentioned this pull request May 16, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 16, 2023
@engine-flutter-autoroll
5d11325Add debugging for Dart VM timeout flake (flutter/flutter#126437)
75b1cf0
@engine-flutter-autorollengine-flutter-autoroll mentioned this pull request May 16, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 16, 2023
@engine-flutter-autoroll
5d11325Add debugging for Dart VM timeout flake (flutter/flutter#126437)
ec01856
@engine-flutter-autorollengine-flutter-autoroll mentioned this pull request May 16, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 16, 2023
@engine-flutter-autoroll
5d11325Add debugging for Dart VM timeout flake (flutter/flutter#126437)
bfc5cbe
@engine-flutter-autorollengine-flutter-autoroll mentioned this pull request May 16, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 16, 2023
@engine-flutter-autoroll
5d11325Add debugging for Dart VM timeout flake (flutter/flutter#126437)
a6f8f8f
@vashworthvashworth mentioned this pull request May 16, 2023
Closed
CaseyHillers pushed a commit to CaseyHillers/flutter that referenced this pull request May 24, 2023
@vashworthCasey Hillers
Add debugging for Dart VM timeout flake (flutter#126437)
0689c57
Check what is available in the device's iOS DeviceSupport folder to check if symbols were properly fetched. Also, add some logging to track what status the debugger is in.
Debugging for flutter#121231.
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 16, 2023
@engine-flutter-autoroll
5d11325Add debugging for Dart VM timeout flake (flutter/flutter#126437)
7a3530c
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023
@engine-flutter-autoroll
5d11325Add debugging for Dart VM timeout flake (flutter/flutter#126437)
378b4d1
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023
@engine-flutter-autoroll
5d11325Add debugging for Dart VM timeout flake (flutter/flutter#126437)
bfadf5d
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023
@engine-flutter-autoroll
5d11325Add debugging for Dart VM timeout flake (flutter/flutter#126437)
804a829
@vashworth
vashworth deleted the dart_vm_timeout_debug branch September 27, 2023 15:36
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hellohuanlinhellohuanlinhellohuanlin approved these changes
+1 more reviewer
@christopherfujinochristopherfujinochristopherfujino approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

autosubmitMerge PR when tree becomes green via auto submit Appplatform-iosiOS applications specificallytoolAffects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vashworth@christopherfujino@hellohuanlin