Skip to content

Revert "Replace rsync when unzipping artifacts on a Mac (#126703)" - #127430

Merged
auto-submit[bot] merged 1 commit into
flutter:masterfrom
vashworth:revert_126703
May 24, 2023
Merged

Revert "Replace rsync when unzipping artifacts on a Mac (#126703)"#127430
auto-submit[bot] merged 1 commit into
flutter:masterfrom
vashworth:revert_126703

Conversation

@vashworth

@vashworthvashworth commented May 23, 2023

Copy link
Copy Markdown
Contributor

This reverts commit 2b3cd7f.

Fixes#127281.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboardflutter-dashboardBot added the tool Affects the "flutter" command-line tool. See also t: labels. label May 23, 2023
christopherfujino
christopherfujino approved these changes May 23, 2023
View reviewed changes

@christopherfujinochristopherfujino left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vashworthvashworth mentioned this pull request May 23, 2023
Closed
8 tasks
@dnfield

dnfield commented May 23, 2023

Copy link
Copy Markdown
Contributor

Does this need a cherry pick into stable?

@christopherfujino

christopherfujino commented May 23, 2023

Copy link
Copy Markdown
Contributor

Does this need a cherry pick into stable?

Nope, this never landed in a release

@vashworthvashworth added the autosubmit Merge PR when tree becomes green via auto submit App label May 24, 2023
@christopherfujinochristopherfujino mentioned this pull request May 24, 2023
Closed
2 tasks
@auto-submit
auto-submitBot merged commit 555326b into flutter:masterMay 24, 2023
@engine-flutter-autorollengine-flutter-autoroll mentioned this pull request May 25, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 25, 2023
@engine-flutter-autoroll
555326bRevert "Replace rsync when unzipping artifacts on a Mac (#126…
8a6e983
…703)" (flutter/flutter#127430)
@engine-flutter-autorollengine-flutter-autoroll mentioned this pull request May 25, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 25, 2023
@engine-flutter-autoroll
555326bRevert "Replace rsync when unzipping artifacts on a Mac (#126…
fc0b2bd
…703)" (flutter/flutter#127430)
@engine-flutter-autorollengine-flutter-autoroll mentioned this pull request May 25, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 25, 2023
@engine-flutter-autoroll
555326bRevert "Replace rsync when unzipping artifacts on a Mac (#126…
8234b69
…703)" (flutter/flutter#127430)
@engine-flutter-autorollengine-flutter-autoroll mentioned this pull request May 25, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 25, 2023
@engine-flutter-autoroll
555326bRevert "Replace rsync when unzipping artifacts on a Mac (#126…
40a63e5
…703)" (flutter/flutter#127430)
@engine-flutter-autorollengine-flutter-autoroll mentioned this pull request May 25, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 25, 2023
@engine-flutter-autoroll
555326bRevert "Replace rsync when unzipping artifacts on a Mac (#126…
0804a8c
…703)" (flutter/flutter#127430)
@engine-flutter-autorollengine-flutter-autoroll mentioned this pull request May 25, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 25, 2023
@engine-flutter-autoroll
555326bRevert "Replace rsync when unzipping artifacts on a Mac (#126…
f650093
…703)" (flutter/flutter#127430)
@engine-flutter-autorollengine-flutter-autoroll mentioned this pull request May 25, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 25, 2023
@engine-flutter-autoroll
555326bRevert "Replace rsync when unzipping artifacts on a Mac (#126…
a546683
…703)" (flutter/flutter#127430)
@engine-flutter-autorollengine-flutter-autoroll mentioned this pull request May 25, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 25, 2023
@engine-flutter-autoroll
555326bRevert "Replace rsync when unzipping artifacts on a Mac (#126…
0e04dd9
…703)" (flutter/flutter#127430)
@reidbakerreidbaker mentioned this pull request May 25, 2023
Merged
8 tasks
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 26, 2023
@engine-flutter-autoroll
555326bRevert "Replace rsync when unzipping artifacts on a Mac (#126…
86856ad
…703)" (flutter/flutter#127430)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 26, 2023
@engine-flutter-autoroll
555326bRevert "Replace rsync when unzipping artifacts on a Mac (#126…
aaa9892
…703)" (flutter/flutter#127430)
@reidbakerreidbaker mentioned this pull request May 26, 2023
Merged
8 tasks
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 16, 2023
@engine-flutter-autoroll
555326bRevert "Replace rsync when unzipping artifacts on a Mac (#126…
08c45c1
…703)" (flutter/flutter#127430)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023
@engine-flutter-autoroll
555326bRevert "Replace rsync when unzipping artifacts on a Mac (#126…
d4a73dd
…703)" (flutter/flutter#127430)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023
@engine-flutter-autoroll
555326bRevert "Replace rsync when unzipping artifacts on a Mac (#126…
dbbf02f
…703)" (flutter/flutter#127430)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023
@engine-flutter-autoroll
555326bRevert "Replace rsync when unzipping artifacts on a Mac (#126…
c9a32c9
…703)" (flutter/flutter#127430)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@christopherfujinochristopherfujinochristopherfujino approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

autosubmitMerge PR when tree becomes green via auto submit ApptoolAffects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Could not find package sky_engine in the Flutter SDK (MacOS)

3 participants

@vashworth@dnfield@christopherfujino