Skip to content

Add menu dismiss localization - #128613

Merged
auto-submit[bot] merged 11 commits into
flutter:masterfrom
gspencergoog:add_context_localization
Jul 19, 2023
Merged

Add menu dismiss localization#128613
auto-submit[bot] merged 11 commits into
flutter:masterfrom
gspencergoog:add_context_localization

Conversation

@gspencergoog

@gspencergooggspencergoog commented Jun 9, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor

Description

Modifies the semantic label for popup and context menus to be "Dismiss menu" instead of just "Dismiss".

Related Issues

Tests

  • Updated tests

@github-actionsgithub-actionsBot added a: internationalization Supporting other languages or locales. (aka i18n) a: text input Entering text in a text field or keyboard related problems p: cupertino_ui cupertino_ui package in flutter/packages p: material_ui material_ui package in flutter/packages framework flutter/packages/flutter repository. See also f: labels. labels Jun 9, 2023
@gspencergoog
gspencergoog marked this pull request as ready for review June 9, 2023 23:05
@gspencergoog
gspencergoogforce-pushed the add_context_localization branch from c75c349 to 3160adcCompareJune 9, 2023 23:06
justinmc
justinmc approved these changes Jun 9, 2023
View reviewed changes

@justinmcjustinmc left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Thanks for fixing this.

@gspencergooggspencergoog added the autosubmit Merge PR when tree becomes green via auto submit App label Jun 9, 2023
@auto-submitauto-submitBot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jun 10, 2023
@auto-submit

auto-submitBot commented Jun 10, 2023

Copy link
Copy Markdown
Contributor

auto label is removed for flutter/flutter, pr: 128613, due to - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label.

tgucio
tgucio reviewed Jun 10, 2023
View reviewed changes
Comment threadpackages/flutter/lib/src/cupertino/localizations.dart Outdated

@tguciotgucioJun 10, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm thinking from a regular user's perspective maybe "Dismiss menu" would fit better than "Dismiss context menu"? Not sure how many people would call it a "context menu" rather than just "menu" - and how translatable "context menu" is.

@gspencergooggspencergoogJun 13, 2023

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, that works for me.

@gspencergoog
gspencergoogforce-pushed the add_context_localization branch 5 times, most recently from c34c217 to 8084f20CompareJune 13, 2023 17:57
@gspencergooggspencergoog changed the title Add context menu dismiss localizationAdd menu dismiss localizationJun 13, 2023
@gspencergooggspencergoog added the autosubmit Merge PR when tree becomes green via auto submit App label Jun 14, 2023
@auto-submitauto-submitBot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jun 14, 2023
@auto-submit

auto-submitBot commented Jun 14, 2023

Copy link
Copy Markdown
Contributor

auto label is removed for flutter/flutter, pr: 128613, due to - The status or check suite Linux framework_tests_libraries has failed. Please fix the issues identified (or deflake) before re-applying this label.

@gspencergooggspencergoog added the autosubmit Merge PR when tree becomes green via auto submit App label Jun 14, 2023
@gspencergoog

gspencergoog commented Jun 14, 2023

Copy link
Copy Markdown
ContributorAuthor

I'll need to update the Google semantics tests so that they pass with the new value. I'll do that in July when I return from vacation.

@gspencergoog
gspencergoogforce-pushed the add_context_localization branch from 3c7d548 to 75edbffCompareJuly 7, 2023 18:35
@auto-submitauto-submitBot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jul 7, 2023
@auto-submit

auto-submitBot commented Jul 7, 2023

Copy link
Copy Markdown
Contributor

auto label is removed for flutter/flutter, pr: 128613, due to - The status or check suite Linux analyze has failed. Please fix the issues identified (or deflake) before re-applying this label.

@gspencergoog
gspencergoogforce-pushed the add_context_localization branch 2 times, most recently from 8f9f5a8 to b8b5335CompareJuly 18, 2023 15:36
@gspencergoog
gspencergoogforce-pushed the add_context_localization branch from b8b5335 to 0a07c07CompareJuly 19, 2023 21:33
@gspencergooggspencergoog added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 19, 2023
@auto-submit
auto-submitBot merged commit 258382c into flutter:masterJul 19, 2023
@engine-flutter-autorollengine-flutter-autoroll mentioned this pull request Jul 20, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 20, 2023
@engine-flutter-autoroll
258382cAdd menu dismiss localization (flutter/flutter#128613)
2fbf798
@engine-flutter-autorollengine-flutter-autoroll mentioned this pull request Jul 20, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 20, 2023
@engine-flutter-autoroll
258382cAdd menu dismiss localization (flutter/flutter#128613)
b2dd031
@engine-flutter-autorollengine-flutter-autoroll mentioned this pull request Jul 20, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 20, 2023
@engine-flutter-autoroll
258382cAdd menu dismiss localization (flutter/flutter#128613)
1102f9f
@engine-flutter-autorollengine-flutter-autoroll mentioned this pull request Jul 21, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 21, 2023
@engine-flutter-autoroll
258382cAdd menu dismiss localization (flutter/flutter#128613)
4f9e237
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 21, 2023
@engine-flutter-autoroll
258382cAdd menu dismiss localization (flutter/flutter#128613)
8945c4d
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tguciotguciotgucio left review comments
@justinmcjustinmcjustinmc approved these changes

Assignees

No one assigned

Labels

a: internationalizationSupporting other languages or locales. (aka i18n)a: text inputEntering text in a text field or keyboard related problemsautosubmitMerge PR when tree becomes green via auto submit Appframeworkflutter/packages/flutter repository. See also f: labels.p: cupertino_uicupertino_ui package in flutter/packagesp: material_uimaterial_ui package in flutter/packages

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Correct accessibility label for dismissing menus

4 participants

@gspencergoog@justinmc@tgucio@flutter-pub-roller-bot