[web] New HtmlElementView.fromTagName constructor by mdebbar · Pull Request #130513 · flutter/flutter

mdebbar · 2023-07-13T19:16:08Z

This wraps up the platform view improvements discussed in #127030.

Splits HtmlElementView into 2 files that are conditionally imported.
The non-web version can be instantiated but it throws if it ends up being built in a widget tree.
Out-of-the-box view factories that create visible & invisible DOM elements given a tagName parameter.
New HtmlElementView.fromTagName() constructor that uses the default factories to create DOM elements.
Tests covering the new API.

Depends on flutter-team-archive/engine#43828

ditman

Small comment: would defining the default factories in the engine simplify the framework code?

ditman

I think this one is ready to go. Only one comment about attempting to make the new extension private so it doesn't show in docs.flutter.dev.

Convenient default factories for creating DOM element from a given tag name. Required by flutter/flutter#130513 Part of flutter/flutter#127030

ditman

I still like this after the latest changes. LGTM!

…utter#130513)

flutter/flutter@ad0aa8d...436df69 2023-08-08 engine-flutter-autoroll@skia.org Roll Flutter Engine from 9c83d90b01bd to 146c4c9487fc (6 revisions) (flutter/flutter#132112) 2023-08-08 engine-flutter-autoroll@skia.org Roll Flutter Engine from c27109291e22 to 9c83d90b01bd (5 revisions) (flutter/flutter#132108) 2023-08-08 engine-flutter-autoroll@skia.org Roll Flutter Engine from be085f6699b6 to c27109291e22 (3 revisions) (flutter/flutter#132086) 2023-08-08 jesus_sguerrero@hotmail.com Revert "Replace TextField.canRequestFocus with TextField.focusNode.canRequestFocus" (flutter/flutter#132104) 2023-08-08 jonahwilliams@google.com [Impeller] add drawVertices and drawAtlas benchmarks. (flutter/flutter#132080) 2023-08-07 47866232+chunhtai@users.noreply.github.com Adds more documentations around ignoreSemantics deprecations. (flutter/flutter#131287) 2023-08-07 mdebbar@google.com [web] New HtmlElementView.fromTagName constructor (flutter/flutter#130513) 2023-08-07 katelovett@google.com Move mock canvas to flutter_test (flutter/flutter#131631) 2023-08-07 matej.knopp@gmail.com Add static_path_tessellation macrobenchmark (flutter/flutter#131837) 2023-08-07 mdebbar@google.com [web] Remove usage of `ui.webOnlyInitializePlatform()` (flutter/flutter#131344) 2023-08-07 engine-flutter-autoroll@skia.org Roll Flutter Engine from 39a575f65d50 to be085f6699b6 (1 revision) (flutter/flutter#132069) 2023-08-07 jmccandless@google.com Android context menu theming and visual update (flutter/flutter#131816) 2023-08-07 engine-flutter-autoroll@skia.org Roll Flutter Engine from 39ce1c097bce to 39a575f65d50 (2 revisions) (flutter/flutter#132064) 2023-08-07 xhzq233@qq.com CupertinoContextMenu improvement (flutter/flutter#131030) 2023-08-07 engine-flutter-autoroll@skia.org Roll Flutter Engine from 5b47c0577060 to 39ce1c097bce (3 revisions) (flutter/flutter#132057) 2023-08-07 xming@google.com Slider should check `mounted` before start interaction (flutter/flutter#132010) 2023-08-07 engine-flutter-autoroll@skia.org Roll Packages from ce53da1 to d7ee75a (7 revisions) (flutter/flutter#132058) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC rmistry@google.com,stuartmorgan@google.com,tarrinneal@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

…r-team-archive#43828) Convenient default factories for creating DOM element from a given tag name. Required by flutter/flutter#130513 Part of flutter/flutter#127030

…utter#130513)

flutter/flutter@ad0aa8d...436df69 2023-08-08 engine-flutter-autoroll@skia.org Roll Flutter Engine from 9c83d90b01bd to 146c4c9487fc (6 revisions) (flutter/flutter#132112) 2023-08-08 engine-flutter-autoroll@skia.org Roll Flutter Engine from c27109291e22 to 9c83d90b01bd (5 revisions) (flutter/flutter#132108) 2023-08-08 engine-flutter-autoroll@skia.org Roll Flutter Engine from be085f6699b6 to c27109291e22 (3 revisions) (flutter/flutter#132086) 2023-08-08 jesus_sguerrero@hotmail.com Revert "Replace TextField.canRequestFocus with TextField.focusNode.canRequestFocus" (flutter/flutter#132104) 2023-08-08 jonahwilliams@google.com [Impeller] add drawVertices and drawAtlas benchmarks. (flutter/flutter#132080) 2023-08-07 47866232+chunhtai@users.noreply.github.com Adds more documentations around ignoreSemantics deprecations. (flutter/flutter#131287) 2023-08-07 mdebbar@google.com [web] New HtmlElementView.fromTagName constructor (flutter/flutter#130513) 2023-08-07 katelovett@google.com Move mock canvas to flutter_test (flutter/flutter#131631) 2023-08-07 matej.knopp@gmail.com Add static_path_tessellation macrobenchmark (flutter/flutter#131837) 2023-08-07 mdebbar@google.com [web] Remove usage of `ui.webOnlyInitializePlatform()` (flutter/flutter#131344) 2023-08-07 engine-flutter-autoroll@skia.org Roll Flutter Engine from 39a575f65d50 to be085f6699b6 (1 revision) (flutter/flutter#132069) 2023-08-07 jmccandless@google.com Android context menu theming and visual update (flutter/flutter#131816) 2023-08-07 engine-flutter-autoroll@skia.org Roll Flutter Engine from 39ce1c097bce to 39a575f65d50 (2 revisions) (flutter/flutter#132064) 2023-08-07 xhzq233@qq.com CupertinoContextMenu improvement (flutter/flutter#131030) 2023-08-07 engine-flutter-autoroll@skia.org Roll Flutter Engine from 5b47c0577060 to 39ce1c097bce (3 revisions) (flutter/flutter#132057) 2023-08-07 xming@google.com Slider should check `mounted` before start interaction (flutter/flutter#132010) 2023-08-07 engine-flutter-autoroll@skia.org Roll Packages from ce53da1 to d7ee75a (7 revisions) (flutter/flutter#132058) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC rmistry@google.com,stuartmorgan@google.com,tarrinneal@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

flutter/flutter@ad0aa8d...436df69 2023-08-08 engine-flutter-autoroll@skia.org Roll Flutter Engine from 9c83d90b01bd to 146c4c9487fc (6 revisions) (flutter/flutter#132112) 2023-08-08 engine-flutter-autoroll@skia.org Roll Flutter Engine from c27109291e22 to 9c83d90b01bd (5 revisions) (flutter/flutter#132108) 2023-08-08 engine-flutter-autoroll@skia.org Roll Flutter Engine from be085f6699b6 to c27109291e22 (3 revisions) (flutter/flutter#132086) 2023-08-08 jesus_sguerrero@hotmail.com Revert "Replace TextField.canRequestFocus with TextField.focusNode.canRequestFocus" (flutter/flutter#132104) 2023-08-08 jonahwilliams@google.com [Impeller] add drawVertices and drawAtlas benchmarks. (flutter/flutter#132080) 2023-08-07 47866232+chunhtai@users.noreply.github.com Adds more documentations around ignoreSemantics deprecations. (flutter/flutter#131287) 2023-08-07 mdebbar@google.com [web] New HtmlElementView.fromTagName constructor (flutter/flutter#130513) 2023-08-07 katelovett@google.com Move mock canvas to flutter_test (flutter/flutter#131631) 2023-08-07 matej.knopp@gmail.com Add static_path_tessellation macrobenchmark (flutter/flutter#131837) 2023-08-07 mdebbar@google.com [web] Remove usage of `ui.webOnlyInitializePlatform()` (flutter/flutter#131344) 2023-08-07 engine-flutter-autoroll@skia.org Roll Flutter Engine from 39a575f65d50 to be085f6699b6 (1 revision) (flutter/flutter#132069) 2023-08-07 jmccandless@google.com Android context menu theming and visual update (flutter/flutter#131816) 2023-08-07 engine-flutter-autoroll@skia.org Roll Flutter Engine from 39ce1c097bce to 39a575f65d50 (2 revisions) (flutter/flutter#132064) 2023-08-07 xhzq233@qq.com CupertinoContextMenu improvement (flutter/flutter#131030) 2023-08-07 engine-flutter-autoroll@skia.org Roll Flutter Engine from 5b47c0577060 to 39ce1c097bce (3 revisions) (flutter/flutter#132057) 2023-08-07 xming@google.com Slider should check `mounted` before start interaction (flutter/flutter#132010) 2023-08-07 engine-flutter-autoroll@skia.org Roll Packages from 747c466 to be5db8f (7 revisions) (flutter/flutter#132058) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC rmistry@google.com,stuartmorgan@google.com,tarrinneal@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

[web] New HtmlElementView.domElement constructor
ebe3866

mdebbar requested a review from ditman July 13, 2023 19:16

github-actionsBot added the framework flutter/packages/flutter repository. See also f: labels. label Jul 13, 2023

fix analyzer warnings
9e96ea9

ditman reviewed Jul 14, 2023
View reviewed changes

Comment threadpackages/flutter/lib/src/widgets/_html_element_view_web.dart Outdated
Comment threadpackages/flutter/lib/src/widgets/platform_view.dart Outdated
Comment threadpackages/flutter/lib/src/widgets/platform_view.dart

mdebbar added 3 commits July 19, 2023 14:10

reduce duplicate code in conditional import
deb6307

Merge branch 'main' into built_in_factory
ae06c2b

default factories are registered in the engine
2ff243e

mdebbar mentioned this pull request Jul 19, 2023
[web] Provide convenient default factories for platform views flutter-team-archive/engine#43828
Merged

ditman reviewed Jul 21, 2023
View reviewed changes

Comment threadpackages/flutter/lib/src/widgets/_html_element_view_io.dart Outdated
Comment threadpackages/flutter/lib/src/widgets/platform_view.dart
Comment threadpackages/flutter/lib/src/widgets/_html_element_view_io.dart

mdebbar added 2 commits July 25, 2023 13:24

use constants from dart:ui_web
965f872

Merge branch 'main' into built_in_factory
aeb576b

mdebbar changed the title ~~[web] New HtmlElementView.domElement constructor~~[web] New HtmlElementView.fromTagName constructorJul 25, 2023

throw early
4a7ea9f

This comment was marked as outdated.
Sign in to view

mdebbar added 2 commits July 26, 2023 13:24

Merge branch 'main' into built_in_factory
3de6a94

get constants from the correct place
af37519

ditman approved these changes Jul 27, 2023
View reviewed changes

mdebbar added 2 commits August 7, 2023 17:02

Merge branch 'main' into built_in_factory
e34f31a

expect correct error type
435df20

mdebbar added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 7, 2023

auto-submitBot merged commit 55fe41b into flutter:masterAug 7, 2023

engine-flutter-autoroll mentioned this pull request Aug 8, 2023
Roll Flutter from ad0aa8de7512 to 436df69a4684 (17 revisions) flutter/packages#4663
Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 8, 2023
55fe41b[web] New HtmlElementView.fromTagName constructor (flutter/fl…
39f8b9b
…utter#130513)

mdebbar deleted the built_in_factory branch August 9, 2023 18:29

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 15, 2023
55fe41b[web] New HtmlElementView.fromTagName constructor (flutter/fl…
c5b723f
…utter#130513)

Navigation Menu

Uh oh!

[web] New HtmlElementView.fromTagName constructor - #130513

[web] New HtmlElementView.fromTagName constructor#130513
auto-submit[bot] merged 12 commits into
flutter:masterfrom
mdebbar:built_in_factory

mdebbar commented Jul 13, 2023•
edited
Loading

Uh oh!

ditman left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ditman left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

This comment was marked as outdated.

Uh oh!

ditman left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

mdebbar commented Jul 13, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ditman left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ditman left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

This comment was marked as outdated.

Uh oh!

ditman left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

mdebbar commented Jul 13, 2023•
edited
Loading