Uh oh!
There was an error while loading. Please reload this page.
Clean up analytics opt in/out flags - #132588
Merged
auto-submit[bot] merged 9 commits intoSep 12, 2023
Merged
Conversation
…ommands-for-analytics-opt-out
…ommands-for-analytics-opt-out
1 task
eliasyishak
marked this pull request as draft
August 24, 2023 20:15
eliasyishak
marked this pull request as ready for review
September 11, 2023 16:25
eliasyishak
commented
Sep 11, 2023
ContributorAuthor
@Hixie this PR is now ready for a review now that the PDD has been updated to change the text around the flag we use. |
Hixie
reviewed
Sep 11, 2023
Uh oh!
There was an error while loading. Please reload this page.
Hixie
reviewed
Sep 11, 2023
| @@ -15,7 +15,8 @@ import '../runner/flutter_command.dart'; | |||
| class ConfigCommand extends FlutterCommand { | |||
| ConfigCommand({ bool verboseHelp = false }) { | |||
| argParser.addFlag('analytics', | |||
Contributor
There was a problem hiding this comment.
do we want to hide this one by default, since it's redundant with the other ones?
ContributorAuthor
There was a problem hiding this comment.
I think that's a good idea, i have hidden it so that it only shows up when running in verbose mode
Hixie
approved these changes
Sep 11, 2023
Hixie
left a comment
Contributor
There was a problem hiding this comment.
modulo the minor comments above
eliasyishak
deleted the
132258-clean-up-commands-for-analytics-opt-out
branch
September 12, 2023 22:50
engine-flutter-autoroll added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 13, 2023
engine-flutter-autoroll added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 13, 2023
engine-flutter-autoroll added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 13, 2023
engine-flutter-autoroll added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 13, 2023
engine-flutter-autoroll added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 13, 2023
Mairramer pushed a commit
to Mairramer/flutter
that referenced
this pull request
Oct 10, 2023
engine-flutter-autoroll added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 15, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes:
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.