Uh oh!
There was an error while loading. Please reload this page.
CupertinoAlertDialog should not create ScrollController on every build, if null values are passed in constructor. - #133918
Merged
Conversation
2 tasks
engine-flutter-autoroll added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 6, 2023
…ery build, if null values are passed in constructor. (flutter/flutter#133918)
engine-flutter-autoroll added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 6, 2023
…ery build, if null values are passed in constructor. (flutter/flutter#133918)
engine-flutter-autoroll added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 6, 2023
…ery build, if null values are passed in constructor. (flutter/flutter#133918)
engine-flutter-autoroll added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 6, 2023
…ery build, if null values are passed in constructor. (flutter/flutter#133918)
engine-flutter-autoroll added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 6, 2023
…ery build, if null values are passed in constructor. (flutter/flutter#133918)
engine-flutter-autoroll added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 6, 2023
…ery build, if null values are passed in constructor. (flutter/flutter#133918)
engine-flutter-autoroll added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 6, 2023
…ery build, if null values are passed in constructor. (flutter/flutter#133918)
engine-flutter-autoroll added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 6, 2023
…ery build, if null values are passed in constructor. (flutter/flutter#133918)
engine-flutter-autoroll added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 7, 2023
…ery build, if null values are passed in constructor. (flutter/flutter#133918)
engine-flutter-autoroll added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 7, 2023
…ery build, if null values are passed in constructor. (flutter/flutter#133918)
engine-flutter-autoroll added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 7, 2023
…ery build, if null values are passed in constructor. (flutter/flutter#133918)
engine-flutter-autoroll added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 7, 2023
…ery build, if null values are passed in constructor. (flutter/flutter#133918)
engine-flutter-autoroll added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 7, 2023
…ery build, if null values are passed in constructor. (flutter/flutter#133918)
engine-flutter-autoroll added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 7, 2023
…ery build, if null values are passed in constructor. (flutter/flutter#133918)
engine-flutter-autoroll added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 15, 2023
…ery build, if null values are passed in constructor. (flutter/flutter#133918)
chunhtai pushed a commit
to chunhtai/packages
that referenced
this pull request
Jun 12, 2026
…ery build, if null values are passed in constructor." (#134071) Reverts flutter/flutter#133918 as it causes build failures.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes#133912