Form fields onChange callback should be called on reset by bleroux · Pull Request #134295 · flutter/flutter

bleroux · 2023-09-08T12:49:52Z

Description

This PR fixes form fields in order to call the onChange callback when the form is reset.

This change is based on the work done in #123108.

I considered adding the onChange callback to the FormField superclass but it would break existing code because two of the three subclasses defines the onChange callback with ValueChanged<String>? type and the third one defines it with ValueChanged<String?>?.

Related Issue

Fixes#123009.

Tests

Adds 3 tests.

Renzo-Olivares · 2023-09-18T19:53:43Z

Should we still call this if the value did not change?

Same for other FormFields.

I chose not to add such a check in order to be consistent with FormState.reset which (indirectly) call the Form.onChanged callback without checking if field values have changed.
I also checked that DropdownButton.onChanged is called when the same entry is selected.
Maybe we should consider this is another issue/PR? I don't know if this was done on purpose.

Renzo-Olivares · 2023-09-18T19:56:38Z

Can this be made a doc template and reused.

Probably, I upated the PR accordingly.

Renzo-Olivares

Thanks for the contribution @bleroux. Just had a few comments.

Renzo-Olivares · 2023-09-20T17:44:05Z

nit: TestFormField -> TextFormField. I think

Thanks for pointing this out!

Renzo-Olivares

LGTM w/ small nit. Thanks for fixing this @bleroux!

…ter/flutter#134295)

## Description This PR fixes form fields in order to call the `onChange` callback when the form is reset. This change is based on the work done in flutter#123108. I considered adding the `onChange` callback to the `FormField` superclass but it would break existing code because two of the three subclasses defines the `onChange` callback with `ValueChanged<String>?` type and the third one defines it with `ValueChanged<String?>?`. ## Related Issue Fixesflutter#123009. ## Tests Adds 3 tests.

…ter/flutter#134295)

github-actionsBot added a: text input Entering text in a text field or keyboard related problems framework flutter/packages/flutter repository. See also f: labels. p: material_ui material_ui package in flutter/packages p: cupertino_ui cupertino_ui package in flutter/packages labels Sep 8, 2023

bleroux mentioned this pull request Sep 8, 2023
Fix FormField implementation components TextFormField, DropdownButtonFormField, CupertinoTextFormFieldRow. The problem that their onChange() method cannot be executed when the parent Form component calls the reset() method #123108
Closed

bleroux force-pushed the formfield_onchange_should_be_called_after_reset branch 5 times, most recently from 90eea5c to ba88062Compare September 12, 2023 12:38

bleroux requested a review from Renzo-Olivares September 12, 2023 20:15

bleroux force-pushed the formfield_onchange_should_be_called_after_reset branch from ba88062 to 2af641fCompare September 15, 2023 07:10

Renzo-Olivares reviewed Sep 18, 2023
View reviewed changes

Comment threadpackages/flutter/test/material/text_form_field_test.dart Outdated

Renzo-Olivares reviewed Sep 18, 2023
View reviewed changes

Comment threadpackages/flutter/test/material/text_form_field_test.dart Outdated

Renzo-Olivares reviewed Sep 18, 2023
View reviewed changes

bleroux force-pushed the formfield_onchange_should_be_called_after_reset branch from 2af641f to 28efbeeCompare September 20, 2023 06:31

bleroux requested a review from Renzo-Olivares September 20, 2023 09:19

bleroux force-pushed the formfield_onchange_should_be_called_after_reset branch from 28efbee to fc3af56Compare September 20, 2023 09:19

Renzo-Olivares reviewed Sep 20, 2023
View reviewed changes

Renzo-Olivares approved these changes Sep 20, 2023
View reviewed changes

bleroux force-pushed the formfield_onchange_should_be_called_after_reset branch 2 times, most recently from 914a2fa to 57c90ccCompare September 20, 2023 18:50

blerouxand others added 2 commits September 20, 2023 22:14

Form fields onChange callback should be called on reset
ea1d355

Address review comments
0ec68a8

bleroux force-pushed the formfield_onchange_should_be_called_after_reset branch from 57c90cc to 0ec68a8Compare September 20, 2023 20:15

bleroux added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 21, 2023

auto-submitBot merged commit 07cc3f7 into flutter:masterSep 21, 2023

bleroux deleted the formfield_onchange_should_be_called_after_reset branch September 21, 2023 05:54

engine-flutter-autoroll mentioned this pull request Sep 22, 2023
Roll Flutter from 893650416352 to f58163447f3b (86 revisions) flutter/packages#4978
Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 22, 2023
07cc3f7Form fields onChange callback should be called on reset (flut…
21c8bdd
…ter/flutter#134295)

engine-flutter-autoroll mentioned this pull request Sep 22, 2023
Roll Flutter from 893650416352 to 06780cb1d069 (87 revisions) flutter/packages#4979
Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 22, 2023
07cc3f7Form fields onChange callback should be called on reset (flut…
750a7c2
…ter/flutter#134295)

engine-flutter-autoroll mentioned this pull request Sep 22, 2023
Roll Flutter from 893650416352 to 74c6693170e1 (88 revisions) flutter/packages#4980
Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 22, 2023
07cc3f7Form fields onChange callback should be called on reset (flut…
eb9eabc
…ter/flutter#134295)

engine-flutter-autoroll mentioned this pull request Sep 22, 2023
Roll Flutter from 893650416352 to dbe0ccd8853d (89 revisions) flutter/packages#4981
Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 22, 2023
07cc3f7Form fields onChange callback should be called on reset (flut…
5f4cafd
…ter/flutter#134295)

engine-flutter-autoroll mentioned this pull request Sep 22, 2023
Roll Flutter from 893650416352 to 76a938bfa6d1 (90 revisions) flutter/packages#4983
Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 22, 2023
07cc3f7Form fields onChange callback should be called on reset (flut…
dc40b5d
…ter/flutter#134295)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 25, 2023
07cc3f7Form fields onChange callback should be called on reset (flut…
d1d1cb5
…ter/flutter#134295)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 26, 2023
07cc3f7Form fields onChange callback should be called on reset (flut…
727fdb3
…ter/flutter#134295)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 26, 2023
07cc3f7Form fields onChange callback should be called on reset (flut…
7412c40
…ter/flutter#134295)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 26, 2023
07cc3f7Form fields onChange callback should be called on reset (flut…
9c7e0c5
…ter/flutter#134295)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 26, 2023
07cc3f7Form fields onChange callback should be called on reset (flut…
c7ee0dc
…ter/flutter#134295)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 26, 2023
07cc3f7Form fields onChange callback should be called on reset (flut…
e8ba312
…ter/flutter#134295)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 27, 2023
07cc3f7Form fields onChange callback should be called on reset (flut…
d02a8cf
…ter/flutter#134295)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 27, 2023
07cc3f7Form fields onChange callback should be called on reset (flut…
90e4869
…ter/flutter#134295)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 27, 2023
07cc3f7Form fields onChange callback should be called on reset (flut…
4f17e52
…ter/flutter#134295)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 27, 2023
07cc3f7Form fields onChange callback should be called on reset (flut…
4a97b25
…ter/flutter#134295)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 27, 2023
07cc3f7Form fields onChange callback should be called on reset (flut…
b1f822a
…ter/flutter#134295)

HansMuller mentioned this pull request Sep 28, 2023
Flutter Framework Team: Notable Commits #121415
Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 28, 2023
07cc3f7Form fields onChange callback should be called on reset (flut…
5182fc4
…ter/flutter#134295)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 28, 2023
07cc3f7Form fields onChange callback should be called on reset (flut…
8ae668c
…ter/flutter#134295)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 28, 2023
07cc3f7Form fields onChange callback should be called on reset (flut…
8fb67b2
…ter/flutter#134295)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 28, 2023
07cc3f7Form fields onChange callback should be called on reset (flut…
a30d1cf
…ter/flutter#134295)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 28, 2023
07cc3f7Form fields onChange callback should be called on reset (flut…
8d4b5dd
…ter/flutter#134295)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 28, 2023
07cc3f7Form fields onChange callback should be called on reset (flut…
99e8360
…ter/flutter#134295)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 15, 2023
07cc3f7Form fields onChange callback should be called on reset (flut…
ec4fac2
…ter/flutter#134295)

Navigation Menu

Uh oh!

Form fields onChange callback should be called on reset - #134295

Form fields onChange callback should be called on reset#134295
auto-submit[bot] merged 2 commits into
flutter:masterfrom
NevercodeHQ:formfield_onchange_should_be_called_after_reset

bleroux commented Sep 8, 2023•
edited
Loading

Uh oh!

Renzo-OlivaresSep 18, 2023

Uh oh!

Renzo-OlivaresSep 18, 2023

Uh oh!

blerouxSep 20, 2023

Uh oh!

Renzo-OlivaresSep 18, 2023

Uh oh!

blerouxSep 20, 2023

Uh oh!

Uh oh!

Uh oh!

Renzo-Olivares left a comment

Uh oh!

Renzo-OlivaresSep 20, 2023

Uh oh!

blerouxSep 20, 2023

Uh oh!

Renzo-Olivares left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

bleroux commented Sep 8, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Related Issue

Tests

Uh oh!

Renzo-OlivaresSep 18, 2023

Choose a reason for hiding this comment

Uh oh!

Renzo-OlivaresSep 18, 2023

Choose a reason for hiding this comment

Uh oh!

blerouxSep 20, 2023

Choose a reason for hiding this comment

Uh oh!

Renzo-OlivaresSep 18, 2023

Choose a reason for hiding this comment

Uh oh!

blerouxSep 20, 2023

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Renzo-Olivares left a comment

Choose a reason for hiding this comment

Uh oh!

Renzo-OlivaresSep 20, 2023

Choose a reason for hiding this comment

Uh oh!

blerouxSep 20, 2023

Choose a reason for hiding this comment

Uh oh!

Renzo-Olivares left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

bleroux commented Sep 8, 2023•
edited
Loading