Add abifilters to our gradle templates by gmackall · Pull Request #135529 · flutter/flutter

gmackall · 2023-09-26T21:55:50Z

Fixes#135173, and could also be interpreted as fixing #83596 based on @chinmaygarde 's comment.

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

gmackall · 2023-09-26T21:58:01Z

cc @chinmaygarde , as you made the original comment - does this look like the correct list to you, based on the table at https://developer.android.com/ndk/guides/abis#sa?

gmackall · 2023-09-26T22:06:23Z

 versionCode flutterVersionCode.toInteger()
 versionName flutterVersionName
+ ndk {
+ abiFilters 'arm64-v8a', 'x86_64', 'armeabi-v7a'


This is the list the above comment was referring to

christopherfujino · 2024-01-11T21:17:25Z

@gmackall is this pending Chinmay's review, or is it good to go once presubmits go green?

gmackall · 2024-01-11T21:18:54Z

@gmackall is this pending Chinmay's review, or is it good to go once presubmits go green?

I would want confirmation from Chinmay here before landing

chinmaygarde

Oh, I didn't know this was waiting on my review. This list LGTM. I think the x86 variant has to be created separately is needed and can't do AOT either.

andrewkolos · 2024-01-18T21:07:47Z

@gmackall Is this ready to be merged?

Reverts #135529 This had some failures in postsubmit: https://ci.chromium.org/ui/p/flutter/builders/prod/Linux%20gradle_plugin_light_apk_test/17054/overview and https://ci.chromium.org/ui/p/flutter/builders/prod/Linux%20gradle_plugin_fat_apk_test/17262/overview We should revert and then investigate.

flutter/flutter@5b673c2...19b06f4 2024-01-24 engine-flutter-autoroll@skia.org Roll Flutter Engine from 7c592dbfa032 to ba3a70ce7722 (2 revisions) (flutter/flutter#142130) 2024-01-24 engine-flutter-autoroll@skia.org Roll Flutter Engine from 700235c85d4a to 7c592dbfa032 (2 revisions) (flutter/flutter#142108) 2024-01-24 engine-flutter-autoroll@skia.org Roll Flutter Engine from da96f9de3f69 to 700235c85d4a (1 revision) (flutter/flutter#142100) 2024-01-24 engine-flutter-autoroll@skia.org Roll Flutter Engine from 220416cfa6ca to da96f9de3f69 (5 revisions) (flutter/flutter#142098) 2024-01-24 ybz975218925@gmail.com Don't change the height of the Textfield's labelStyle when it focused. (flutter/flutter#141943) 2024-01-24 polinach@google.com Ignore a leak. (flutter/flutter#141737) 2024-01-24 xilaizhang@google.com [github actions] FINALLY fix the mysterious token error in github actions (flutter/flutter#142058) 2024-01-24 jacksongardner@google.com Revert "Add abifilters to our gradle templates" (flutter/flutter#142089) 2024-01-23 engine-flutter-autoroll@skia.org Roll Flutter Engine from 0b9b538bd458 to 220416cfa6ca (2 revisions) (flutter/flutter#142079) 2024-01-23 34871572+gmackall@users.noreply.github.com Add abifilters to our gradle templates (flutter/flutter#135529) 2024-01-23 engine-flutter-autoroll@skia.org Roll Flutter Engine from 11a16d83ab6c to 0b9b538bd458 (2 revisions) (flutter/flutter#142076) 2024-01-23 49699333+dependabot[bot]@users.noreply.github.com Bump actions/upload-artifact from 4.2.0 to 4.3.0 (flutter/flutter#142075) 2024-01-23 andrewrkolos@gmail.com consolidate AssetBundle::entries and AssetBundle::entryKinds into a new type, `AssetBundleEntry` (flutter/flutter#142029) 2024-01-23 engine-flutter-autoroll@skia.org Roll Flutter Engine from 57d6b518f920 to 11a16d83ab6c (4 revisions) (flutter/flutter#142071) 2024-01-23 engine-flutter-autoroll@skia.org Roll Flutter Engine from 994054143fc3 to 57d6b518f920 (3 revisions) (flutter/flutter#142067) 2024-01-23 christopherfujino@gmail.com [flutter_tools] fix language_version_test and enable shuffle (flutter/flutter#142009) 2024-01-23 ian@hixie.ch Merge flutter_goldens_client into flutter_goldens (flutter/flutter#141900) 2024-01-23 chingjun@google.com Allow overriding the native assets yaml file in the resident runner. (flutter/flutter#142016) 2024-01-23 engine-flutter-autoroll@skia.org Roll Flutter Engine from b229878c57f5 to 994054143fc3 (1 revision) (flutter/flutter#142059) 2024-01-23 jhy03261997@gmail.com Update material banner maxScaleFactor to meet GAR requirement (flutter/flutter#142015) 2024-01-23 36861262+QuncCccccc@users.noreply.github.com Add tooltip for the clear button on `SearchAnchor`'s search view (flutter/flutter#141804) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC bmparr@google.com,rmistry@google.com,stuartmorgan@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

add abifilters to our gradle templates
89325dd

github-actionsBot added the tool Affects the "flutter" command-line tool. See also t: labels. label Sep 26, 2023

gmackall commented Sep 26, 2023
View reviewed changes

gmackall changed the title ~~add abifilters to our gradle templates~~Add abifilters to our gradle templatesSep 26, 2023

johnmccutchan requested review from chinmaygarde and johnmccutchan September 26, 2023 22:07

johnmccutchan approved these changes Sep 26, 2023
View reviewed changes

gmackall marked this pull request as ready for review December 19, 2023 20:06

Merge branch 'master' into abifilter_round2
2d4fad5

chinmaygarde approved these changes Jan 11, 2024
View reviewed changes

gmackall added 3 commits January 11, 2024 13:24

Merge branch 'master' into abifilter_round2
34d8522

Merge branch 'master' into abifilter_round2
1751206

Merge branch 'master' into abifilter_round2
74f2e7d

gmackall added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 23, 2024

auto-submitBot merged commit 5123352 into flutter:masterJan 23, 2024

eyebrowsoffire mentioned this pull request Jan 24, 2024
Revert "Add abifilters to our gradle templates" #142089
Merged

engine-flutter-autoroll mentioned this pull request Jan 24, 2024
Roll Flutter from 5b673c28e4ac to 19b06f4ee9a0 (21 revisions) flutter/packages#5968
Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 24, 2024
5123352Add abifilters to our gradle templates (flutter/flutter#135529)
582481c

danagbemava-nc mentioned this pull request Aug 14, 2024
Investigate path resolution for "libflutter.so" binary #151638
Open

lukehutch mentioned this pull request Aug 14, 2024
Flutter needs to declare abiFilters for only supported architectures by default #153476
Closed

Navigation Menu

Uh oh!

Add abifilters to our gradle templates - #135529

Add abifilters to our gradle templates#135529
auto-submit[bot] merged 5 commits into
flutter:masterfrom
gmackall:abifilter_round2

gmackall commented Sep 26, 2023•
edited
Loading

Uh oh!

gmackall commented Sep 26, 2023•
edited
Loading

Uh oh!

gmackallSep 26, 2023

Uh oh!

christopherfujino commented Jan 11, 2024

Uh oh!

gmackall commented Jan 11, 2024

Uh oh!

chinmaygarde left a comment

Uh oh!

andrewkolos commented Jan 18, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Uh oh!

Conversation

gmackall commented Sep 26, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-launch Checklist

Uh oh!

gmackall commented Sep 26, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gmackallSep 26, 2023

Choose a reason for hiding this comment

Uh oh!

christopherfujino commented Jan 11, 2024

Uh oh!

gmackall commented Jan 11, 2024

Uh oh!

chinmaygarde left a comment

Choose a reason for hiding this comment

Uh oh!

andrewkolos commented Jan 18, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

gmackall commented Sep 26, 2023•
edited
Loading

gmackall commented Sep 26, 2023•
edited
Loading