Skip to content

Pass along web renderer into debugging options in the test command. - #143128

Merged
auto-submit[bot] merged 1 commit into
flutter:masterfrom
eyebrowsoffire:flutter_test_web_renderer
Feb 8, 2024
Merged

Pass along web renderer into debugging options in the test command.#143128
auto-submit[bot] merged 1 commit into
flutter:masterfrom
eyebrowsoffire:flutter_test_web_renderer

Conversation

@eyebrowsoffire

@eyebrowsoffireeyebrowsoffire commented Feb 7, 2024

Copy link
Copy Markdown
Contributor

We need to pass along the web renderer in the debugging options to make sure that the resident web runner sets up the targets correctly.

@github-actionsgithub-actionsBot added the tool Affects the "flutter" command-line tool. See also t: labels. label Feb 7, 2024
@ditmanditman mentioned this pull request Feb 7, 2024
Open
ditman
ditman approved these changes Feb 8, 2024
View reviewed changes

@ditmanditman left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM!

@ditmanditman added the autosubmit Merge PR when tree becomes green via auto submit App label Feb 8, 2024
@auto-submit
auto-submitBot merged commit 71c6cd0 into flutter:masterFeb 8, 2024
@ditman

ditman commented Feb 8, 2024

Copy link
Copy Markdown
Member

(@eyebrowsoffire still getting isCanvasKit false after attempting to run tests on top of this commit)

$ flutter --version && flutter test --local-web-sdk=wasm_release --platform=chrome --web-renderer=canvaskit test/widgets/overscroll_stretch_indicator_test.dart
Building flutter tool...
Resolving dependencies... (1.6s)
Got dependencies.
Flutter 3.20.0-4.0.pre.34 • channel master • git@github.com:ditman/flutter-flutter.git
Framework • revision 71c6cd0cb9 (19 minutes ago) • 2024-02-07 17:21:07 -0800
Engine • revision 45137ea6ba
Tools • Dart 3.4.0 (build 3.4.0-116.0.dev) • DevTools 2.32.0
00:01 +1: Stretch overscroll vertically isCanvasKit? false
isCanvasKit? false
isCanvasKit? false
isCanvasKit? false
00:05 +2: Stretch overscroll works in reverse - vertical isCanvasKit? false
00:06 +3: Stretch overscroll works in reverse - horizontal isCanvasKit? false
00:06 +4: Stretch overscroll works in reverse - horizontal - RTL isCanvasKit? false
isCanvasKit? false
isCanvasKit? false
isCanvasKit? false
00:08 +5: Stretch overscroll horizontally isCanvasKit? false
isCanvasKit? false
isCanvasKit? false
isCanvasKit? false
00:10 +6: Stretch overscroll horizontally RTL isCanvasKit? false
00:10 +8: Stretch does not overflow bounds of container isCanvasKit? false
00:12 +19: All tests passed!

@engine-flutter-autorollengine-flutter-autoroll mentioned this pull request Feb 8, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 8, 2024
@engine-flutter-autoroll
71c6cd0Pass along web renderer into debugging options in the test co…
98086be
…mmand. (flutter/flutter#143128)
@engine-flutter-autorollengine-flutter-autoroll mentioned this pull request Feb 8, 2024
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 8, 2024
@engine-flutter-autoroll
71c6cd0Pass along web renderer into debugging options in the test co…
aa8a65d
…mmand. (flutter/flutter#143128)
auto-submitBot pushed a commit to flutter/packages that referenced this pull request Feb 8, 2024
@engine-flutter-autoroll
Roll Flutter from8431caetoeb5d0a4(33 revisions) (#6079)
316bde0
Roll Flutter from 8431cae to eb5d0a4 (33 revisions)
flutter/flutter@8431cae...eb5d0a4
2024-02-08 engine-flutter-autoroll@skia.org Roll Packages from e4ea6bf to 29d8cc0 (5 revisions) (flutter/flutter#143161)
2024-02-08 engine-flutter-autoroll@skia.org Roll Flutter Engine from 6d524588c0f9 to f53fbd8393ce (1 revision) (flutter/flutter#143160)
2024-02-08 engine-flutter-autoroll@skia.org Roll Flutter Engine from 22e1241e9823 to 6d524588c0f9 (3 revisions) (flutter/flutter#143147)
2024-02-08 engine-flutter-autoroll@skia.org Roll Flutter Engine from 084bd0b8f5ac to 22e1241e9823 (1 revision) (flutter/flutter#143140)
2024-02-08 engine-flutter-autoroll@skia.org Roll Flutter Engine from 104804aa374e to 084bd0b8f5ac (1 revision) (flutter/flutter#143139)
2024-02-08 engine-flutter-autoroll@skia.org Roll Flutter Engine from 45137ea6ba29 to 104804aa374e (1 revision) (flutter/flutter#143138)
2024-02-08 jacksongardner@google.com Pass along web renderer into debugging options in the test command. (flutter/flutter#143128)
2024-02-08 engine-flutter-autoroll@skia.org Roll Flutter Engine from 4ea7bd07328b to 45137ea6ba29 (2 revisions) (flutter/flutter#143135)
2024-02-08 engine-flutter-autoroll@skia.org Roll Flutter Engine from 322a461dc74f to 4ea7bd07328b (2 revisions) (flutter/flutter#143131)
2024-02-07 36861262+QuncCccccc@users.noreply.github.com Add a unit test for `NavigationRail` (flutter/flutter#143108)
2024-02-07 engine-flutter-autoroll@skia.org Roll Flutter Engine from b1ba9f329f76 to 322a461dc74f (2 revisions) (flutter/flutter#143123)
2024-02-07 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Improve build output for all platforms" (flutter/flutter#143125)
2024-02-07 engine-flutter-autoroll@skia.org Roll Flutter Engine from e4a5acc14b44 to b1ba9f329f76 (2 revisions) (flutter/flutter#143120)
2024-02-07 6655696+guidezpl@users.noreply.github.com Improve build output for all platforms (flutter/flutter#128236)
2024-02-07 engine-flutter-autoroll@skia.org Roll Flutter Engine from 19ae46afed69 to e4a5acc14b44 (7 revisions) (flutter/flutter#143112)
2024-02-07 ybz975218925@gmail.com Fixed cursor blinking during selection. (flutter/flutter#141380)
2024-02-07 magder@google.com Remove Cirrus check for web test concurrency (flutter/flutter#143046)
2024-02-07 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Enforce a policy on supported Gradle, Java, AGP, and KGP versions" (flutter/flutter#143114)
2024-02-07 34871572+gmackall@users.noreply.github.com Enforce a policy on supported Gradle, Java, AGP, and KGP versions (flutter/flutter#142000)
2024-02-07 jacksongardner@google.com Fix inputs and outputs for `WebReleaseBundle` (flutter/flutter#143023)
2024-02-07 ian@hixie.ch Various improvements to text-editing-related documentation. (flutter/flutter#142561)
2024-02-07 goderbauer@google.com Revert "Add `SingleChildScrollView` for `NavigationRail`" (flutter/flutter#143097)
2024-02-07 34871572+gmackall@users.noreply.github.com Restore log dumps for gradle OOM crashes, and set a value for `MaxMetaspaceSize` (flutter/flutter#143085)
2024-02-07 15619084+vashworth@users.noreply.github.com Move Mac_build_test flutter_gallery__transition_perf_e2e_ios out of staging (flutter/flutter#142987)
2024-02-07 engine-flutter-autoroll@skia.org Roll Flutter Engine from fafd8e55eb4b to 19ae46afed69 (1 revision) (flutter/flutter#143094)
2024-02-07 ian@hixie.ch Add a test for the isAvailableForEnvironment logic (flutter/flutter#142251)
2024-02-07 32538273+ValentinVignal@users.noreply.github.com Add the number of mismatched pixels to golden tests output (flutter/flutter#142975)
2024-02-07 goderbauer@google.com Add indexInParent to SemanticsNode debug information (flutter/flutter#142826)
2024-02-07 magder@google.com Remove unused devicelab task gradle_non_android_plugin_test (flutter/flutter#142742)
2024-02-07 34871572+gmackall@users.noreply.github.com Make generate_gradle_lockfiles also write the gradle wrapper file (flutter/flutter#142329)
2024-02-07 engine-flutter-autoroll@skia.org Roll Flutter Engine from 6807342305e4 to fafd8e55eb4b (1 revision) (flutter/flutter#143086)
2024-02-07 andrewrkolos@gmail.com Remove redundant `rootDirectoryPath` parameter in `DevFS::update` (flutter/flutter#143034)
2024-02-07 maRci002@users.noreply.github.com Handle transitions to AppLifecycleState.detached in lifecycle state generation (flutter/flutter#142523)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC rmistry@google.com,stuartmorgan@google.com,tarrinneal@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
...
eyebrowsoffire added a commit to eyebrowsoffire/flutter that referenced this pull request Feb 8, 2024
@eyebrowsoffire
Revert "Pass along web renderer into debugging options in the test co…
a98cfb2
…mmand. (flutter#143128)"
This reverts commit 71c6cd0.
@eyebrowsoffireeyebrowsoffire mentioned this pull request Feb 8, 2024
Merged
auto-submitBot pushed a commit that referenced this pull request Feb 8, 2024
@eyebrowsoffire
Revert Dual Web Compile changes (#143175)
2efeeb4
Dual Web Compile has had some issues where `flutter test` is not respecting the `--web-renderer` flag for some reason. I haven't gotten entirely to the bottom of the issue, but for now we need to rever these changes while I investigate. This reverts the following PRs:
#143128#141396
While doing this revert, I had a few merge conflicts with #142760, and I tried to resolve the merge conflicts within the spirit of that PR's change, but @chingjun I might need your input on whether the imports I have modified are okay with regards to the change you were making.
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 14, 2024
@engine-flutter-autoroll
71c6cd0Pass along web renderer into debugging options in the test co…
abb287e
…mmand. (flutter/flutter#143128)
@eyebrowsoffire
eyebrowsoffire deleted the flutter_test_web_renderer branch December 12, 2025 21:55
creatorpiyush pushed a commit to creatorpiyush/packages that referenced this pull request Jun 10, 2026
@engine-flutter-autoroll
Roll Flutter from8431caetoeb5d0a4(33 revisions) (flutter#6079)
1cf215c
Roll Flutter from 8431cae to eb5d0a4 (33 revisions)
flutter/flutter@8431cae...eb5d0a4
2024-02-08 engine-flutter-autoroll@skia.org Roll Packages from e4ea6bf to 29d8cc0 (5 revisions) (flutter/flutter#143161)
2024-02-08 engine-flutter-autoroll@skia.org Roll Flutter Engine from 6d524588c0f9 to f53fbd8393ce (1 revision) (flutter/flutter#143160)
2024-02-08 engine-flutter-autoroll@skia.org Roll Flutter Engine from 22e1241e9823 to 6d524588c0f9 (3 revisions) (flutter/flutter#143147)
2024-02-08 engine-flutter-autoroll@skia.org Roll Flutter Engine from 084bd0b8f5ac to 22e1241e9823 (1 revision) (flutter/flutter#143140)
2024-02-08 engine-flutter-autoroll@skia.org Roll Flutter Engine from 104804aa374e to 084bd0b8f5ac (1 revision) (flutter/flutter#143139)
2024-02-08 engine-flutter-autoroll@skia.org Roll Flutter Engine from 45137ea6ba29 to 104804aa374e (1 revision) (flutter/flutter#143138)
2024-02-08 jacksongardner@google.com Pass along web renderer into debugging options in the test command. (flutter/flutter#143128)
2024-02-08 engine-flutter-autoroll@skia.org Roll Flutter Engine from 4ea7bd07328b to 45137ea6ba29 (2 revisions) (flutter/flutter#143135)
2024-02-08 engine-flutter-autoroll@skia.org Roll Flutter Engine from 322a461dc74f to 4ea7bd07328b (2 revisions) (flutter/flutter#143131)
2024-02-07 36861262+QuncCccccc@users.noreply.github.com Add a unit test for `NavigationRail` (flutter/flutter#143108)
2024-02-07 engine-flutter-autoroll@skia.org Roll Flutter Engine from b1ba9f329f76 to 322a461dc74f (2 revisions) (flutter/flutter#143123)
2024-02-07 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Improve build output for all platforms" (flutter/flutter#143125)
2024-02-07 engine-flutter-autoroll@skia.org Roll Flutter Engine from e4a5acc14b44 to b1ba9f329f76 (2 revisions) (flutter/flutter#143120)
2024-02-07 6655696+guidezpl@users.noreply.github.com Improve build output for all platforms (flutter/flutter#128236)
2024-02-07 engine-flutter-autoroll@skia.org Roll Flutter Engine from 19ae46afed69 to e4a5acc14b44 (7 revisions) (flutter/flutter#143112)
2024-02-07 ybz975218925@gmail.com Fixed cursor blinking during selection. (flutter/flutter#141380)
2024-02-07 magder@google.com Remove Cirrus check for web test concurrency (flutter/flutter#143046)
2024-02-07 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Enforce a policy on supported Gradle, Java, AGP, and KGP versions" (flutter/flutter#143114)
2024-02-07 34871572+gmackall@users.noreply.github.com Enforce a policy on supported Gradle, Java, AGP, and KGP versions (flutter/flutter#142000)
2024-02-07 jacksongardner@google.com Fix inputs and outputs for `WebReleaseBundle` (flutter/flutter#143023)
2024-02-07 ian@hixie.ch Various improvements to text-editing-related documentation. (flutter/flutter#142561)
2024-02-07 goderbauer@google.com Revert "Add `SingleChildScrollView` for `NavigationRail`" (flutter/flutter#143097)
2024-02-07 34871572+gmackall@users.noreply.github.com Restore log dumps for gradle OOM crashes, and set a value for `MaxMetaspaceSize` (flutter/flutter#143085)
2024-02-07 15619084+vashworth@users.noreply.github.com Move Mac_build_test flutter_gallery__transition_perf_e2e_ios out of staging (flutter/flutter#142987)
2024-02-07 engine-flutter-autoroll@skia.org Roll Flutter Engine from fafd8e55eb4b to 19ae46afed69 (1 revision) (flutter/flutter#143094)
2024-02-07 ian@hixie.ch Add a test for the isAvailableForEnvironment logic (flutter/flutter#142251)
2024-02-07 32538273+ValentinVignal@users.noreply.github.com Add the number of mismatched pixels to golden tests output (flutter/flutter#142975)
2024-02-07 goderbauer@google.com Add indexInParent to SemanticsNode debug information (flutter/flutter#142826)
2024-02-07 magder@google.com Remove unused devicelab task gradle_non_android_plugin_test (flutter/flutter#142742)
2024-02-07 34871572+gmackall@users.noreply.github.com Make generate_gradle_lockfiles also write the gradle wrapper file (flutter/flutter#142329)
2024-02-07 engine-flutter-autoroll@skia.org Roll Flutter Engine from 6807342305e4 to fafd8e55eb4b (1 revision) (flutter/flutter#143086)
2024-02-07 andrewrkolos@gmail.com Remove redundant `rootDirectoryPath` parameter in `DevFS::update` (flutter/flutter#143034)
2024-02-07 maRci002@users.noreply.github.com Handle transitions to AppLifecycleState.detached in lifecycle state generation (flutter/flutter#142523)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC rmistry@google.com,stuartmorgan@google.com,tarrinneal@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
...
bisor0627 pushed a commit to bisor0627/packages that referenced this pull request Jun 19, 2026
@engine-flutter-autoroll
Roll Flutter from8431caetoeb5d0a4(33 revisions) (flutter#6079)
39809c3
Roll Flutter from 8431cae to eb5d0a4 (33 revisions)
flutter/flutter@8431cae...eb5d0a4
2024-02-08 engine-flutter-autoroll@skia.org Roll Packages from 90f7ffe to e3370e6 (5 revisions) (flutter/flutter#143161)
2024-02-08 engine-flutter-autoroll@skia.org Roll Flutter Engine from 6d524588c0f9 to f53fbd8393ce (1 revision) (flutter/flutter#143160)
2024-02-08 engine-flutter-autoroll@skia.org Roll Flutter Engine from 22e1241e9823 to 6d524588c0f9 (3 revisions) (flutter/flutter#143147)
2024-02-08 engine-flutter-autoroll@skia.org Roll Flutter Engine from 084bd0b8f5ac to 22e1241e9823 (1 revision) (flutter/flutter#143140)
2024-02-08 engine-flutter-autoroll@skia.org Roll Flutter Engine from 104804aa374e to 084bd0b8f5ac (1 revision) (flutter/flutter#143139)
2024-02-08 engine-flutter-autoroll@skia.org Roll Flutter Engine from 45137ea6ba29 to 104804aa374e (1 revision) (flutter/flutter#143138)
2024-02-08 jacksongardner@google.com Pass along web renderer into debugging options in the test command. (flutter/flutter#143128)
2024-02-08 engine-flutter-autoroll@skia.org Roll Flutter Engine from 4ea7bd07328b to 45137ea6ba29 (2 revisions) (flutter/flutter#143135)
2024-02-08 engine-flutter-autoroll@skia.org Roll Flutter Engine from 322a461dc74f to 4ea7bd07328b (2 revisions) (flutter/flutter#143131)
2024-02-07 36861262+QuncCccccc@users.noreply.github.com Add a unit test for `NavigationRail` (flutter/flutter#143108)
2024-02-07 engine-flutter-autoroll@skia.org Roll Flutter Engine from b1ba9f329f76 to 322a461dc74f (2 revisions) (flutter/flutter#143123)
2024-02-07 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Improve build output for all platforms" (flutter/flutter#143125)
2024-02-07 engine-flutter-autoroll@skia.org Roll Flutter Engine from e4a5acc14b44 to b1ba9f329f76 (2 revisions) (flutter/flutter#143120)
2024-02-07 6655696+guidezpl@users.noreply.github.com Improve build output for all platforms (flutter/flutter#128236)
2024-02-07 engine-flutter-autoroll@skia.org Roll Flutter Engine from 19ae46afed69 to e4a5acc14b44 (7 revisions) (flutter/flutter#143112)
2024-02-07 ybz975218925@gmail.com Fixed cursor blinking during selection. (flutter/flutter#141380)
2024-02-07 magder@google.com Remove Cirrus check for web test concurrency (flutter/flutter#143046)
2024-02-07 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Enforce a policy on supported Gradle, Java, AGP, and KGP versions" (flutter/flutter#143114)
2024-02-07 34871572+gmackall@users.noreply.github.com Enforce a policy on supported Gradle, Java, AGP, and KGP versions (flutter/flutter#142000)
2024-02-07 jacksongardner@google.com Fix inputs and outputs for `WebReleaseBundle` (flutter/flutter#143023)
2024-02-07 ian@hixie.ch Various improvements to text-editing-related documentation. (flutter/flutter#142561)
2024-02-07 goderbauer@google.com Revert "Add `SingleChildScrollView` for `NavigationRail`" (flutter/flutter#143097)
2024-02-07 34871572+gmackall@users.noreply.github.com Restore log dumps for gradle OOM crashes, and set a value for `MaxMetaspaceSize` (flutter/flutter#143085)
2024-02-07 15619084+vashworth@users.noreply.github.com Move Mac_build_test flutter_gallery__transition_perf_e2e_ios out of staging (flutter/flutter#142987)
2024-02-07 engine-flutter-autoroll@skia.org Roll Flutter Engine from fafd8e55eb4b to 19ae46afed69 (1 revision) (flutter/flutter#143094)
2024-02-07 ian@hixie.ch Add a test for the isAvailableForEnvironment logic (flutter/flutter#142251)
2024-02-07 32538273+ValentinVignal@users.noreply.github.com Add the number of mismatched pixels to golden tests output (flutter/flutter#142975)
2024-02-07 goderbauer@google.com Add indexInParent to SemanticsNode debug information (flutter/flutter#142826)
2024-02-07 magder@google.com Remove unused devicelab task gradle_non_android_plugin_test (flutter/flutter#142742)
2024-02-07 34871572+gmackall@users.noreply.github.com Make generate_gradle_lockfiles also write the gradle wrapper file (flutter/flutter#142329)
2024-02-07 engine-flutter-autoroll@skia.org Roll Flutter Engine from 6807342305e4 to fafd8e55eb4b (1 revision) (flutter/flutter#143086)
2024-02-07 andrewrkolos@gmail.com Remove redundant `rootDirectoryPath` parameter in `DevFS::update` (flutter/flutter#143034)
2024-02-07 maRci002@users.noreply.github.com Handle transitions to AppLifecycleState.detached in lifecycle state generation (flutter/flutter#142523)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC rmistry@google.com,stuartmorgan@google.com,tarrinneal@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
...
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ditmanditmanditman approved these changes

Assignees

No one assigned

Labels

autosubmitMerge PR when tree becomes green via auto submit ApptoolAffects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@eyebrowsoffire@ditman