Update tokens to v2.3.5 by QuncCccccc · Pull Request #145356 · flutter/flutter

QuncCccccc · 2024-03-18T21:09:50Z

Updated the Material Design tokens to v2.3.5
Linear and circular progress indicator token sets are deprecated in v0.207. The md.com.progress-indicator token set was created and should be used instead.
tokens is now using semantic versioning （Thanks @guidezpl for reminding:) )
~~FixesPopupMenu Material 3 tokens #128877. The default text style is updated to bodyLarge now:)~~ Added TODOs for the label text style of PopupMenuButton. Will create a separate PR because this change breaks Google testing.

Pre-launch Checklist

I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
I read the [Tree Hygiene] wiki page, which explains my responsibilities.
I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
I signed the [CLA].
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is [test-exempt].
I followed the [breaking change policy] and added [Data Driven Fixes] where supported.
All existing and new tests are passing.

guidezpl

Nice. Worth noting tokens is now using semantic versioning

guidezpl · 2024-03-19T01:32:15Z

curious what is still using v 0.206?

Yeah, I think this is because my last commit change. I reverted the tokens in slider.json because there're a big change on Slider which might cause Scuba failures. I think probably we can create a separate PR for it:)

HansMuller

LGTM

flutter/flutter@89ea492...8528881 2024-03-29 34871572+gmackall@users.noreply.github.com Remove trailing commas in android dependency version checking gradle plugin (flutter/flutter#145718) 2024-03-29 polinach@google.com Upgrade leak_tracker. (flutter/flutter#145940) 2024-03-29 engine-flutter-autoroll@skia.org Roll Flutter Engine from 8b893cb3b607 to 68aa9ba386e1 (2 revisions) (flutter/flutter#145946) 2024-03-29 103135467+sealesj@users.noreply.github.com Refactor flutter_plugins (flutter/flutter#145870) 2024-03-29 34871572+gmackall@users.noreply.github.com Point kotlin message in `gradle_errors.dart` towards new place where templates define the kotlin version (flutter/flutter#145936) 2024-03-29 engine-flutter-autoroll@skia.org Roll Flutter Engine from b917b24836fd to 8b893cb3b607 (1 revision) (flutter/flutter#145941) 2024-03-28 engine-flutter-autoroll@skia.org Roll Flutter Engine from c176d114d01e to b917b24836fd (4 revisions) (flutter/flutter#145938) 2024-03-28 31859944+LongCatIsLooong@users.noreply.github.com `RenderFlex` baseline intrinsics (flutter/flutter#145483) 2024-03-28 godofredoc@google.com Use reporter extended consistently. (flutter/flutter#145617) 2024-03-28 36861262+QuncCccccc@users.noreply.github.com Update tokens to v2.3.5 (flutter/flutter#145356) 2024-03-28 engine-flutter-autoroll@skia.org Roll Flutter Engine from a396dc1a03a9 to c176d114d01e (2 revisions) (flutter/flutter#145934) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC dit@google.com,rmistry@google.com,stuartmorgan@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

This PR is to * Update the Material Design tokens to 4.0.0 Since the last token update(#145356), only `Slider` tokens have been updated. The M3 `Slider` has significant visual changes, compared to the original M3 Slider, so a separate PR would be needed. I commented out `SliderTemplate` and added a TODO when we are ready to add new widgets again.

This PR is to * Update the Material Design tokens to 4.0.0 Since the last token update(flutter#145356), only `Slider` tokens have been updated. The M3 `Slider` has significant visual changes, compared to the original M3 Slider, so a separate PR would be needed. I commented out `SliderTemplate` and added a TODO when we are ready to add new widgets again.

flutter/flutter@89ea492...8528881 2024-03-29 34871572+gmackall@users.noreply.github.com Remove trailing commas in android dependency version checking gradle plugin (flutter/flutter#145718) 2024-03-29 polinach@google.com Upgrade leak_tracker. (flutter/flutter#145940) 2024-03-29 engine-flutter-autoroll@skia.org Roll Flutter Engine from 8b893cb3b607 to 68aa9ba386e1 (2 revisions) (flutter/flutter#145946) 2024-03-29 103135467+sealesj@users.noreply.github.com Refactor flutter_plugins (flutter/flutter#145870) 2024-03-29 34871572+gmackall@users.noreply.github.com Point kotlin message in `gradle_errors.dart` towards new place where templates define the kotlin version (flutter/flutter#145936) 2024-03-29 engine-flutter-autoroll@skia.org Roll Flutter Engine from b917b24836fd to 8b893cb3b607 (1 revision) (flutter/flutter#145941) 2024-03-28 engine-flutter-autoroll@skia.org Roll Flutter Engine from c176d114d01e to b917b24836fd (4 revisions) (flutter/flutter#145938) 2024-03-28 31859944+LongCatIsLooong@users.noreply.github.com `RenderFlex` baseline intrinsics (flutter/flutter#145483) 2024-03-28 godofredoc@google.com Use reporter extended consistently. (flutter/flutter#145617) 2024-03-28 36861262+QuncCccccc@users.noreply.github.com Update tokens to v2.3.5 (flutter/flutter#145356) 2024-03-28 engine-flutter-autoroll@skia.org Roll Flutter Engine from a396dc1a03a9 to c176d114d01e (2 revisions) (flutter/flutter#145934) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC dit@google.com,rmistry@google.com,stuartmorgan@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

github-actionsBot added a: text input Entering text in a text field or keyboard related problems framework flutter/packages/flutter repository. See also f: labels. p: material_ui material_ui package in flutter/packages labels Mar 18, 2024

QuncCccccc changed the title ~~[WIP]Update tokens to v0.235~~[WIP]Update tokens to v235Mar 18, 2024

QuncCccccc changed the title ~~[WIP]Update tokens to v235~~[WIP]Update tokens to v2.3.5Mar 18, 2024

guidezpl approved these changes Mar 19, 2024
View reviewed changes

github-actionsBot added the a: internationalization Supporting other languages or locales. (aka i18n) label Mar 19, 2024

QuncCccccc marked this pull request as ready for review March 19, 2024 17:54

QuncCccccc changed the title ~~[WIP]Update tokens to v2.3.5~~Update tokens to v2.3.5Mar 19, 2024

QuncCccccc requested a review from HansMuller March 19, 2024 17:57

github-actionsBot removed the a: internationalization Supporting other languages or locales. (aka i18n) label Mar 19, 2024

QuncCccccc added 11 commits March 28, 2024 10:40

Update token version to v0.235
56f6d0f

Remove progress_indicator_circular and progress_indicator_linear
d0738d0

Update progress indicator templates
613e438

Update FAB templates
7ba4200

Updat menu item tokens and revert slider template
92adc96

Update PopupMenuButton tests
e2b4af1

Update unit test
4a641e1

Add a TODO to update M3 Slider to the latest changes
f679a64

Update unit tests
c446146

Update popupMenuButton related tests
37334ae

Update unit tests for progress indicator
efb5c5d

QuncCccccc force-pushed the update_tokens_to_v_235 branch from 37906c5 to efb5c5dCompare March 28, 2024 17:40

HansMuller approved these changes Mar 28, 2024
View reviewed changes

QuncCccccc added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 28, 2024

auto-submitBot merged commit ea1268a into flutter:masterMar 28, 2024

QuncCccccc mentioned this pull request Mar 28, 2024
PopupMenu Material 3 tokens #128877
Closed
2 tasks

engine-flutter-autoroll mentioned this pull request Mar 29, 2024
Roll Flutter from 89ea49204b37 to 1a2f34ab5b9a (10 revisions) flutter/packages#6435
Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 29, 2024
ea1268aUpdate tokens to v2.3.5 (flutter/flutter#145356)
c09a3a3

engine-flutter-autoroll mentioned this pull request Mar 29, 2024
Roll Flutter from 89ea49204b37 to 85288818b59e (11 revisions) flutter/packages#6436
Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 29, 2024
ea1268aUpdate tokens to v2.3.5 (flutter/flutter#145356)
8749258

HansMuller mentioned this pull request Mar 29, 2024
Flutter Framework Team: Notable Commits #121415
Closed

QuncCccccc mentioned this pull request May 21, 2024
Update tokens to 4.0.0 #148789
Merged
9 tasks

Navigation Menu

Uh oh!

Update tokens to v2.3.5 - #145356

Update tokens to v2.3.5#145356
auto-submit[bot] merged 11 commits into
flutter:masterfrom
QuncCccccc:update_tokens_to_v_235

QuncCccccc commented Mar 18, 2024•
edited
Loading

Uh oh!

guidezpl left a comment

Uh oh!

guidezplMar 19, 2024

Uh oh!

QuncCcccccMar 19, 2024

Uh oh!

HansMuller left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

QuncCccccc commented Mar 18, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-launch Checklist

Uh oh!

guidezpl left a comment

Choose a reason for hiding this comment

Uh oh!

guidezplMar 19, 2024

Choose a reason for hiding this comment

Uh oh!

QuncCcccccMar 19, 2024

Choose a reason for hiding this comment

Uh oh!

HansMuller left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

QuncCccccc commented Mar 18, 2024•
edited
Loading