Skip to content

test sliver fill remaining examples - #148041

Merged
auto-submit[bot] merged 5 commits into
flutter:masterfrom
derdilla:130459-sliver_fill_remaining
May 13, 2024
Merged

test sliver fill remaining examples#148041
auto-submit[bot] merged 5 commits into
flutter:masterfrom
derdilla:130459-sliver_fill_remaining

Conversation

@derdilla

@derdilladerdilla commented May 9, 2024

Copy link
Copy Markdown
Contributor

Par of #130459. Adds tests all SliverFillRemaining examples.

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@github-actionsgithub-actionsBot added framework flutter/packages/flutter repository. See also f: labels. f: scrolling Viewports, list views, slivers, etc. d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos labels May 9, 2024
gspencergoog
gspencergoog approved these changes May 10, 2024
View reviewed changes

@gspencergooggspencergoog left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

32384589-a60f0e74-c078-11e7-9bc1-e5b5287aea9d

Woohoo! Thanks!

victorsanni
victorsanni approved these changes May 11, 2024
View reviewed changes
Comment threadexamples/api/test/widgets/sliver_fill/sliver_fill_remaining.1_test.dart Outdated
@gspencergooggspencergoog added the autosubmit Merge PR when tree becomes green via auto submit App label May 13, 2024
@auto-submit
auto-submitBot merged commit 708fe97 into flutter:masterMay 13, 2024
@engine-flutter-autorollengine-flutter-autoroll mentioned this pull request May 13, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 13, 2024
@engine-flutter-autoroll
708fe97test sliver fill remaining examples (flutter/flutter#148041)
b0f9517
@engine-flutter-autorollengine-flutter-autoroll mentioned this pull request May 13, 2024
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 13, 2024
@engine-flutter-autoroll
708fe97test sliver fill remaining examples (flutter/flutter#148041)
3f3efc7
auto-submitBot pushed a commit to flutter/packages that referenced this pull request May 13, 2024
@engine-flutter-autoroll
Roll Flutter from1dfb46eto1255435(6 revisions) (#6723)
f91f689
flutter/flutter@1dfb46e...1255435
2024-05-13 jmccandless@google.com Native ios context menu (flutter/flutter#143002)
2024-05-13 82763757+NobodyForNothing@users.noreply.github.com test sliver fill remaining examples (flutter/flutter#148041)
2024-05-13 engine-flutter-autoroll@skia.org Roll Flutter Engine from fab7a7417888 to 0050bf9a8094 (1 revision) (flutter/flutter#148211)
2024-05-13 engine-flutter-autoroll@skia.org Roll Flutter Engine from e568e5db9391 to fab7a7417888 (1 revision) (flutter/flutter#148207)
2024-05-13 engine-flutter-autoroll@skia.org Roll Flutter Engine from 57e74a1b3860 to e568e5db9391 (2 revisions) (flutter/flutter#148204)
2024-05-13 engine-flutter-autoroll@skia.org Roll Flutter Engine from 34fd28e8c7bd to 57e74a1b3860 (1 revision) (flutter/flutter#148196)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC rmistry@google.com,stuartmorgan@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@PiinksPiinks mentioned this pull request May 17, 2024
Closed
TecHaxter pushed a commit to TecHaxter/flutter_packages that referenced this pull request May 22, 2024
@engine-flutter-autoroll@TecHaxter
Roll Flutter from1dfb46eto1255435(6 revisions) (flutter#6723)
17ca862
flutter/flutter@1dfb46e...1255435
2024-05-13 jmccandless@google.com Native ios context menu (flutter/flutter#143002)
2024-05-13 82763757+NobodyForNothing@users.noreply.github.com test sliver fill remaining examples (flutter/flutter#148041)
2024-05-13 engine-flutter-autoroll@skia.org Roll Flutter Engine from fab7a7417888 to 0050bf9a8094 (1 revision) (flutter/flutter#148211)
2024-05-13 engine-flutter-autoroll@skia.org Roll Flutter Engine from e568e5db9391 to fab7a7417888 (1 revision) (flutter/flutter#148207)
2024-05-13 engine-flutter-autoroll@skia.org Roll Flutter Engine from 57e74a1b3860 to e568e5db9391 (2 revisions) (flutter/flutter#148204)
2024-05-13 engine-flutter-autoroll@skia.org Roll Flutter Engine from 34fd28e8c7bd to 57e74a1b3860 (1 revision) (flutter/flutter#148196)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC rmistry@google.com,stuartmorgan@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 6, 2024
@engine-flutter-autoroll
708fe97test sliver fill remaining examples (flutter/flutter#148041)
6dd5e6a
creatorpiyush pushed a commit to creatorpiyush/packages that referenced this pull request Jun 10, 2026
@engine-flutter-autoroll
Roll Flutter from1dfb46eto1255435(6 revisions) (flutter#6723)
6862ebe
flutter/flutter@1dfb46e...1255435
2024-05-13 jmccandless@google.com Native ios context menu (flutter/flutter#143002)
2024-05-13 82763757+NobodyForNothing@users.noreply.github.com test sliver fill remaining examples (flutter/flutter#148041)
2024-05-13 engine-flutter-autoroll@skia.org Roll Flutter Engine from fab7a7417888 to 0050bf9a8094 (1 revision) (flutter/flutter#148211)
2024-05-13 engine-flutter-autoroll@skia.org Roll Flutter Engine from e568e5db9391 to fab7a7417888 (1 revision) (flutter/flutter#148207)
2024-05-13 engine-flutter-autoroll@skia.org Roll Flutter Engine from 57e74a1b3860 to e568e5db9391 (2 revisions) (flutter/flutter#148204)
2024-05-13 engine-flutter-autoroll@skia.org Roll Flutter Engine from 34fd28e8c7bd to 57e74a1b3860 (1 revision) (flutter/flutter#148196)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC rmistry@google.com,stuartmorgan@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
bisor0627 pushed a commit to bisor0627/packages that referenced this pull request Jun 19, 2026
@engine-flutter-autoroll
Roll Flutter from1dfb46eto1255435(6 revisions) (flutter#6723)
fdcd386
flutter/flutter@1dfb46e...1255435
2024-05-13 jmccandless@google.com Native ios context menu (flutter/flutter#143002)
2024-05-13 82763757+NobodyForNothing@users.noreply.github.com test sliver fill remaining examples (flutter/flutter#148041)
2024-05-13 engine-flutter-autoroll@skia.org Roll Flutter Engine from fab7a7417888 to 0050bf9a8094 (1 revision) (flutter/flutter#148211)
2024-05-13 engine-flutter-autoroll@skia.org Roll Flutter Engine from e568e5db9391 to fab7a7417888 (1 revision) (flutter/flutter#148207)
2024-05-13 engine-flutter-autoroll@skia.org Roll Flutter Engine from 57e74a1b3860 to e568e5db9391 (2 revisions) (flutter/flutter#148204)
2024-05-13 engine-flutter-autoroll@skia.org Roll Flutter Engine from 34fd28e8c7bd to 57e74a1b3860 (1 revision) (flutter/flutter#148196)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC rmistry@google.com,stuartmorgan@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@victorsannivictorsannivictorsanni approved these changes
@gspencergooggspencergoogAwaiting requested review from gspencergoog

Assignees

No one assigned

Labels

autosubmitMerge PR when tree becomes green via auto submit Appd: api docsIssues with https://api.flutter.dev/d: examplesSample code and demosf: scrollingViewports, list views, slivers, etc.frameworkflutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@derdilla@gspencergoog@victorsanni