Uh oh!
There was an error while loading. Please reload this page.
[GAR] [a11y] Update text button page in a11y assessment app - #148905
Merged
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
hannah-hyjforce-pushed
the
a11ytextbutton
branch
2 times, most recently
from
May 23, 2024 22:25
8c90aa8 to
b31ed1eCompare9 tasks
Contributor
auto label is removed for flutter/flutter/148905, due to - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label. |
update text button
Contributor
auto label is removed for flutter/flutter/148905, due to - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label. |
victorsanni pushed a commit
to victorsanni/flutter
that referenced
this pull request
May 31, 2024
…148905) internal: b/317125569 If the text button label contains its role and state, it will be confusing for tester. it will be announced like "xxx button button" : <img src="https://github.com/flutter/flutter/assets/108393416/16f5a996-b0f1-4f04-bd99-caa3cacd4182" width=50% height=50%> updated screen and label: <img src="https://github.com/flutter/flutter/assets/108393416/1de55cec-8a18-4c36-9dac-84ae7d151fd6" width=50% height=50%>
engine-flutter-autoroll added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 2, 2024
engine-flutter-autoroll added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 2, 2024
engine-flutter-autoroll added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 3, 2024
engine-flutter-autoroll added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 3, 2024
engine-flutter-autoroll added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 3, 2024
engine-flutter-autoroll added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 3, 2024
engine-flutter-autoroll added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 3, 2024
engine-flutter-autoroll added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 3, 2024
engine-flutter-autoroll added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 3, 2024
engine-flutter-autoroll added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 3, 2024
engine-flutter-autoroll added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 3, 2024
engine-flutter-autoroll added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 6, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
internal: b/317125569
If the text button label contains its role and state, it will be confusing for tester.
it will be announced like "xxx button button" :
updated screen and label:
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.