Skip to content

[Reland] Introduce doubleFlex.spacing parameter for Row/Column spacing - #152890

Merged
auto-submit[bot] merged 3 commits into
flutter:masterfrom
TahaTesser:reland-152472
Aug 5, 2024
Merged

[Reland] Introduce doubleFlex.spacing parameter for Row/Column spacing#152890
auto-submit[bot] merged 3 commits into
flutter:masterfrom
TahaTesser:reland-152472

Conversation

@TahaTesser

@TahaTesserTahaTesser commented Aug 5, 2024

Copy link
Copy Markdown
Contributor

Relands #152472 (Fixed error causing message test, maybe by #152501)


fixesadd spacing parameter to Column and Row

Column.spacing Code sample

expand to view the code sample
import'package:flutter/material.dart';
voidmain() =>runApp(constMyApp());
classMyAppextendsStatelessWidget {
constMyApp({super.key});
@overrideWidgetbuild(BuildContext context) {
returnMaterialApp(
debugShowCheckedModeBanner:false,
home:Scaffold(
backgroundColor:Colors.black,
body:Center(
child:Padding(
padding:constEdgeInsets.all(16.0),
child:DecoratedBox(
decoration:BoxDecoration(
border:Border.all(
color:Colors.amber,
)),
child:constRow(
mainAxisAlignment:MainAxisAlignment.spaceEvenly,
children:<Widget>[
Column(
spacing:40.0,
// ignore: avoid_redundant_argument_values
mainAxisAlignment:MainAxisAlignment.start,
children:<Widget>[
ColoredBox(
color:Color(0xffff0000),
child:SizedBox(
width:50.0,
height:75.0,
child:Align(
alignment:Alignment.topCenter,
child:Text(
'RED',
style:TextStyle(color:Colors.white),
),
),
),
),
ColoredBox(
color:Color(0xff00ff00),
child:SizedBox(
width:50.0,
height:75.0,
child:Center(
child:Text(
'GREEN',
style:TextStyle(color:Colors.black),
),
),
),
),
ColoredBox(
color:Color(0xff0000ff),
child:SizedBox(
width:50.0,
height:75.0,
child:Align(
alignment:Alignment.bottomCenter,
child:Text(
'BLUE',
style:TextStyle(color:Colors.white),
),
),
),
),
],
),
Column(
spacing:40.0,
mainAxisAlignment:MainAxisAlignment.center,
children:<Widget>[
ColoredBox(
color:Color(0xffff0000),
child:SizedBox(
width:50.0,
height:75.0,
child:Align(
alignment:Alignment.topCenter,
child:Text(
'RED',
style:TextStyle(color:Colors.white),
),
),
),
),
ColoredBox(
color:Color(0xff00ff00),
child:SizedBox(
width:50.0,
height:75.0,
child:Center(
child:Text(
'GREEN',
style:TextStyle(color:Colors.black),
),
),
),
),
ColoredBox(
color:Color(0xff0000ff),
child:SizedBox(
width:50.0,
height:75.0,
child:Align(
alignment:Alignment.bottomCenter,
child:Text(
'BLUE',
style:TextStyle(color:Colors.white),
),
),
),
),
],
),
Column(
spacing:40.0,
mainAxisAlignment:MainAxisAlignment.end,
children:<Widget>[
ColoredBox(
color:Color(0xffff0000),
child:SizedBox(
width:50.0,
height:75.0,
child:Align(
alignment:Alignment.topCenter,
child:Text(
'RED',
style:TextStyle(color:Colors.white),
),
),
),
),
ColoredBox(
color:Color(0xff00ff00),
child:SizedBox(
width:50.0,
height:75.0,
child:Center(
child:Text(
'GREEN',
style:TextStyle(color:Colors.black),
),
),
),
),
ColoredBox(
color:Color(0xff0000ff),
child:SizedBox(
width:50.0,
height:75.0,
child:Align(
alignment:Alignment.bottomCenter,
child:Text(
'BLUE',
style:TextStyle(color:Colors.white),
),
),
),
),
],
),
Column(
spacing:40.0,
mainAxisAlignment:MainAxisAlignment.spaceBetween,
children:<Widget>[
ColoredBox(
color:Color(0xffff0000),
child:SizedBox(
width:50.0,
height:75.0,
child:Align(
alignment:Alignment.topCenter,
child:Text(
'RED',
style:TextStyle(color:Colors.white),
),
),
),
),
ColoredBox(
color:Color(0xff00ff00),
child:SizedBox(
width:50.0,
height:75.0,
child:Center(
child:Text(
'GREEN',
style:TextStyle(color:Colors.black),
),
),
),
),
ColoredBox(
color:Color(0xff0000ff),
child:SizedBox(
width:50.0,
height:75.0,
child:Align(
alignment:Alignment.bottomCenter,
child:Text(
'BLUE',
style:TextStyle(color:Colors.white),
),
),
),
),
],
),
Column(
spacing:40.0,
mainAxisAlignment:MainAxisAlignment.spaceAround,
children:<Widget>[
ColoredBox(
color:Color(0xffff0000),
child:SizedBox(
width:50.0,
height:75.0,
child:Align(
alignment:Alignment.topCenter,
child:Text(
'RED',
style:TextStyle(color:Colors.white),
),
),
),
),
ColoredBox(
color:Color(0xff00ff00),
child:SizedBox(
width:50.0,
height:75.0,
child:Center(
child:Text(
'GREEN',
style:TextStyle(color:Colors.black),
),
),
),
),
ColoredBox(
color:Color(0xff0000ff),
child:SizedBox(
width:50.0,
height:75.0,
child:Align(
alignment:Alignment.bottomCenter,
child:Text(
'BLUE',
style:TextStyle(color:Colors.white),
),
),
),
),
],
),
Column(
spacing:40.0,
mainAxisAlignment:MainAxisAlignment.spaceEvenly,
children:<Widget>[
ColoredBox(
color:Color(0xffff0000),
child:SizedBox(
width:50.0,
height:75.0,
child:Align(
alignment:Alignment.topCenter,
child:Text(
'RED',
style:TextStyle(color:Colors.white),
),
),
),
),
ColoredBox(
color:Color(0xff00ff00),
child:SizedBox(
width:50.0,
height:75.0,
child:Center(
child:Text(
'GREEN',
style:TextStyle(color:Colors.black),
),
),
),
),
ColoredBox(
color:Color(0xff0000ff),
child:SizedBox(
width:50.0,
height:75.0,
child:Align(
alignment:Alignment.bottomCenter,
child:Text(
'BLUE',
style:TextStyle(color:Colors.white),
),
),
),
),
],
),
],
),
),
),
),
),
);
}
}

Preview

Screenshot 2024-07-30 at 15 40 59

Row.spacing Code sample

expand to view the code sample
import'package:flutter/material.dart';
voidmain() =>runApp(constMyApp());
classMyAppextendsStatelessWidget {
constMyApp({super.key});
@overrideWidgetbuild(BuildContext context) {
returnMaterialApp(
debugShowCheckedModeBanner:false,
home:Scaffold(
backgroundColor:Colors.black,
body:Center(
child:Padding(
padding:constEdgeInsets.all(16.0),
child:DecoratedBox(
decoration:BoxDecoration(
border:Border.all(
color:Colors.amber,
)),
child:constColumn(
mainAxisAlignment:MainAxisAlignment.spaceEvenly,
children:<Widget>[
Row(
spacing:40.0,
// ignore: avoid_redundant_argument_values
mainAxisAlignment:MainAxisAlignment.start,
children:<Widget>[
ColoredBox(
color:Color(0xffff0000),
child:SizedBox(
width:50.0,
height:75.0,
child:Align(
alignment:Alignment.centerLeft,
child:Text(
'RED',
style:TextStyle(color:Colors.white),
),
),
),
),
ColoredBox(
color:Color(0xff00ff00),
child:SizedBox(
width:50.0,
height:75.0,
child:Center(
child:Text(
'GREEN',
style:TextStyle(color:Colors.black),
),
),
),
),
ColoredBox(
color:Color(0xff0000ff),
child:SizedBox(
width:50.0,
height:75.0,
child:Align(
alignment:Alignment.centerRight,
child:Text(
'BLUE',
style:TextStyle(color:Colors.white),
),
),
),
),
],
),
Row(
spacing:40.0,
mainAxisAlignment:MainAxisAlignment.center,
children:<Widget>[
ColoredBox(
color:Color(0xffff0000),
child:SizedBox(
width:50.0,
height:75.0,
child:Align(
alignment:Alignment.centerLeft,
child:Text(
'RED',
style:TextStyle(color:Colors.white),
),
),
),
),
ColoredBox(
color:Color(0xff00ff00),
child:SizedBox(
width:50.0,
height:75.0,
child:Center(
child:Text(
'GREEN',
style:TextStyle(color:Colors.black),
),
),
),
),
ColoredBox(
color:Color(0xff0000ff),
child:SizedBox(
width:50.0,
height:75.0,
child:Align(
alignment:Alignment.centerRight,
child:Text(
'BLUE',
style:TextStyle(color:Colors.white),
),
),
),
),
],
),
Row(
spacing:40.0,
mainAxisAlignment:MainAxisAlignment.end,
children:<Widget>[
ColoredBox(
color:Color(0xffff0000),
child:SizedBox(
width:50.0,
height:75.0,
child:Align(
alignment:Alignment.centerLeft,
child:Text(
'RED',
style:TextStyle(color:Colors.white),
),
),
),
),
ColoredBox(
color:Color(0xff00ff00),
child:SizedBox(
width:50.0,
height:75.0,
child:Center(
child:Text(
'GREEN',
style:TextStyle(color:Colors.black),
),
),
),
),
ColoredBox(
color:Color(0xff0000ff),
child:SizedBox(
width:50.0,
height:75.0,
child:Align(
alignment:Alignment.centerRight,
child:Text(
'BLUE',
style:TextStyle(color:Colors.white),
),
),
),
),
],
),
Row(
spacing:40.0,
mainAxisAlignment:MainAxisAlignment.spaceBetween,
children:<Widget>[
ColoredBox(
color:Color(0xffff0000),
child:SizedBox(
width:50.0,
height:75.0,
child:Align(
alignment:Alignment.centerLeft,
child:Text(
'RED',
style:TextStyle(color:Colors.white),
),
),
),
),
ColoredBox(
color:Color(0xff00ff00),
child:SizedBox(
width:50.0,
height:75.0,
child:Center(
child:Text(
'GREEN',
style:TextStyle(color:Colors.black),
),
),
),
),
ColoredBox(
color:Color(0xff0000ff),
child:SizedBox(
width:50.0,
height:75.0,
child:Align(
alignment:Alignment.centerRight,
child:Text(
'BLUE',
style:TextStyle(color:Colors.white),
),
),
),
),
],
),
Row(
spacing:40.0,
mainAxisAlignment:MainAxisAlignment.spaceAround,
children:<Widget>[
ColoredBox(
color:Color(0xffff0000),
child:SizedBox(
width:50.0,
height:75.0,
child:Align(
alignment:Alignment.centerLeft,
child:Text(
'RED',
style:TextStyle(color:Colors.white),
),
),
),
),
ColoredBox(
color:Color(0xff00ff00),
child:SizedBox(
width:50.0,
height:75.0,
child:Center(
child:Text(
'GREEN',
style:TextStyle(color:Colors.black),
),
),
),
),
ColoredBox(
color:Color(0xff0000ff),
child:SizedBox(
width:50.0,
height:75.0,
child:Align(
alignment:Alignment.centerRight,
child:Text(
'BLUE',
style:TextStyle(color:Colors.white),
),
),
),
),
],
),
Row(
spacing:40.0,
mainAxisAlignment:MainAxisAlignment.spaceEvenly,
children:<Widget>[
ColoredBox(
color:Color(0xffff0000),
child:SizedBox(
width:50.0,
height:75.0,
child:Align(
alignment:Alignment.centerLeft,
child:Text(
'RED',
style:TextStyle(color:Colors.white),
),
),
),
),
ColoredBox(
color:Color(0xff00ff00),
child:SizedBox(
width:50.0,
height:75.0,
child:Center(
child:Text(
'GREEN',
style:TextStyle(color:Colors.black),
),
),
),
),
ColoredBox(
color:Color(0xff0000ff),
child:SizedBox(
width:50.0,
height:75.0,
child:Align(
child:Text(
'BLUE',
style:TextStyle(color:Colors.white),
),
),
),
),
],
),
],
),
),
),
),
),
);
}
}

Preview

Screenshot 2024-07-30 at 15 39 42

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

#152472)
fixes [add spacing parameter to Column and Row](#55378)
### `Column.spacing` Code sample
<details>
<summary>expand to view the code sample</summary> ```dart
import 'package:flutter/material.dart';
void main() => runApp(const MyApp());
class MyApp extends StatelessWidget {
const MyApp({super.key});
@OverRide
Widget build(BuildContext context) {
return MaterialApp(
debugShowCheckedModeBanner: false,
home: Scaffold(
backgroundColor: Colors.black,
body: Center(
child: Padding(
padding: const EdgeInsets.all(16.0),
child: DecoratedBox(
decoration: BoxDecoration(
border: Border.all(
color: Colors.amber,
)),
child: const Row(
mainAxisAlignment: MainAxisAlignment.spaceEvenly,
children: <Widget>[
Column(
spacing: 40.0,
// ignore: avoid_redundant_argument_values
mainAxisAlignment: MainAxisAlignment.start,
children: <Widget>[
ColoredBox(
color: Color(0xffff0000),
child: SizedBox(
width: 50.0,
height: 75.0,
child: Align(
alignment: Alignment.topCenter,
child: Text(
'RED',
style: TextStyle(color: Colors.white),
),
),
),
),
ColoredBox(
color: Color(0xff00ff00),
child: SizedBox(
width: 50.0,
height: 75.0,
child: Center(
child: Text(
'GREEN',
style: TextStyle(color: Colors.black),
),
),
),
),
ColoredBox(
color: Color(0xff0000ff),
child: SizedBox(
width: 50.0,
height: 75.0,
child: Align(
alignment: Alignment.bottomCenter,
child: Text(
'BLUE',
style: TextStyle(color: Colors.white),
),
),
),
),
],
),
Column(
spacing: 40.0,
mainAxisAlignment: MainAxisAlignment.center,
children: <Widget>[
ColoredBox(
color: Color(0xffff0000),
child: SizedBox(
width: 50.0,
height: 75.0,
child: Align(
alignment: Alignment.topCenter,
child: Text(
'RED',
style: TextStyle(color: Colors.white),
),
),
),
),
ColoredBox(
color: Color(0xff00ff00),
child: SizedBox(
width: 50.0,
height: 75.0,
child: Center(
child: Text(
'GREEN',
style: TextStyle(color: Colors.black),
),
),
),
),
ColoredBox(
color: Color(0xff0000ff),
child: SizedBox(
width: 50.0,
height: 75.0,
child: Align(
alignment: Alignment.bottomCenter,
child: Text(
'BLUE',
style: TextStyle(color: Colors.white),
),
),
),
),
],
),
Column(
spacing: 40.0,
mainAxisAlignment: MainAxisAlignment.end,
children: <Widget>[
ColoredBox(
color: Color(0xffff0000),
child: SizedBox(
width: 50.0,
height: 75.0,
child: Align(
alignment: Alignment.topCenter,
child: Text(
'RED',
style: TextStyle(color: Colors.white),
),
),
),
),
ColoredBox(
color: Color(0xff00ff00),
child: SizedBox(
width: 50.0,
height: 75.0,
child: Center(
child: Text(
'GREEN',
style: TextStyle(color: Colors.black),
),
),
),
),
ColoredBox(
color: Color(0xff0000ff),
child: SizedBox(
width: 50.0,
height: 75.0,
child: Align(
alignment: Alignment.bottomCenter,
child: Text(
'BLUE',
style: TextStyle(color: Colors.white),
),
),
),
),
],
),
Column(
spacing: 40.0,
mainAxisAlignment: MainAxisAlignment.spaceBetween,
children: <Widget>[
ColoredBox(
color: Color(0xffff0000),
child: SizedBox(
width: 50.0,
height: 75.0,
child: Align(
alignment: Alignment.topCenter,
child: Text(
'RED',
style: TextStyle(color: Colors.white),
),
),
),
),
ColoredBox(
color: Color(0xff00ff00),
child: SizedBox(
width: 50.0,
height: 75.0,
child: Center(
child: Text(
'GREEN',
style: TextStyle(color: Colors.black),
),
),
),
),
ColoredBox(
color: Color(0xff0000ff),
child: SizedBox(
width: 50.0,
height: 75.0,
child: Align(
alignment: Alignment.bottomCenter,
child: Text(
'BLUE',
style: TextStyle(color: Colors.white),
),
),
),
),
],
),
Column(
spacing: 40.0,
mainAxisAlignment: MainAxisAlignment.spaceAround,
children: <Widget>[
ColoredBox(
color: Color(0xffff0000),
child: SizedBox(
width: 50.0,
height: 75.0,
child: Align(
alignment: Alignment.topCenter,
child: Text(
'RED',
style: TextStyle(color: Colors.white),
),
),
),
),
ColoredBox(
color: Color(0xff00ff00),
child: SizedBox(
width: 50.0,
height: 75.0,
child: Center(
child: Text(
'GREEN',
style: TextStyle(color: Colors.black),
),
),
),
),
ColoredBox(
color: Color(0xff0000ff),
child: SizedBox(
width: 50.0,
height: 75.0,
child: Align(
alignment: Alignment.bottomCenter,
child: Text(
'BLUE',
style: TextStyle(color: Colors.white),
),
),
),
),
],
),
Column(
spacing: 40.0,
mainAxisAlignment: MainAxisAlignment.spaceEvenly,
children: <Widget>[
ColoredBox(
color: Color(0xffff0000),
child: SizedBox(
width: 50.0,
height: 75.0,
child: Align(
alignment: Alignment.topCenter,
child: Text(
'RED',
style: TextStyle(color: Colors.white),
),
),
),
),
ColoredBox(
color: Color(0xff00ff00),
child: SizedBox(
width: 50.0,
height: 75.0,
child: Center(
child: Text(
'GREEN',
style: TextStyle(color: Colors.black),
),
),
),
),
ColoredBox(
color: Color(0xff0000ff),
child: SizedBox(
width: 50.0,
height: 75.0,
child: Align(
alignment: Alignment.bottomCenter,
child: Text(
'BLUE',
style: TextStyle(color: Colors.white),
),
),
),
),
],
),
],
),
),
),
),
),
);
}
}
```
</details>
### Preview
<img width="1072" alt="Screenshot 2024-07-30 at 15 40 59" src="https://github.com/user-attachments/assets/14f21091-9e46-4a58-8552-1379f4ba9216">
### `Row.spacing` Code sample
<details>
<summary>expand to view the code sample</summary> ```dart
import 'package:flutter/material.dart';
void main() => runApp(const MyApp());
class MyApp extends StatelessWidget {
const MyApp({super.key});
@OverRide
Widget build(BuildContext context) {
return MaterialApp(
debugShowCheckedModeBanner: false,
home: Scaffold(
backgroundColor: Colors.black,
body: Center(
child: Padding(
padding: const EdgeInsets.all(16.0),
child: DecoratedBox(
decoration: BoxDecoration(
border: Border.all(
color: Colors.amber,
)),
child: const Column(
mainAxisAlignment: MainAxisAlignment.spaceEvenly,
children: <Widget>[
Row(
spacing: 40.0,
// ignore: avoid_redundant_argument_values
mainAxisAlignment: MainAxisAlignment.start,
children: <Widget>[
ColoredBox(
color: Color(0xffff0000),
child: SizedBox(
width: 50.0,
height: 75.0,
child: Align(
alignment: Alignment.centerLeft,
child: Text(
'RED',
style: TextStyle(color: Colors.white),
),
),
),
),
ColoredBox(
color: Color(0xff00ff00),
child: SizedBox(
width: 50.0,
height: 75.0,
child: Center(
child: Text(
'GREEN',
style: TextStyle(color: Colors.black),
),
),
),
),
ColoredBox(
color: Color(0xff0000ff),
child: SizedBox(
width: 50.0,
height: 75.0,
child: Align(
alignment: Alignment.centerRight,
child: Text(
'BLUE',
style: TextStyle(color: Colors.white),
),
),
),
),
],
),
Row(
spacing: 40.0,
mainAxisAlignment: MainAxisAlignment.center,
children: <Widget>[
ColoredBox(
color: Color(0xffff0000),
child: SizedBox(
width: 50.0,
height: 75.0,
child: Align(
alignment: Alignment.centerLeft,
child: Text(
'RED',
style: TextStyle(color: Colors.white),
),
),
),
),
ColoredBox(
color: Color(0xff00ff00),
child: SizedBox(
width: 50.0,
height: 75.0,
child: Center(
child: Text(
'GREEN',
style: TextStyle(color: Colors.black),
),
),
),
),
ColoredBox(
color: Color(0xff0000ff),
child: SizedBox(
width: 50.0,
height: 75.0,
child: Align(
alignment: Alignment.centerRight,
child: Text(
'BLUE',
style: TextStyle(color: Colors.white),
),
),
),
),
],
),
Row(
spacing: 40.0,
mainAxisAlignment: MainAxisAlignment.end,
children: <Widget>[
ColoredBox(
color: Color(0xffff0000),
child: SizedBox(
width: 50.0,
height: 75.0,
child: Align(
alignment: Alignment.centerLeft,
child: Text(
'RED',
style: TextStyle(color: Colors.white),
),
),
),
),
ColoredBox(
color: Color(0xff00ff00),
child: SizedBox(
width: 50.0,
height: 75.0,
child: Center(
child: Text(
'GREEN',
style: TextStyle(color: Colors.black),
),
),
),
),
ColoredBox(
color: Color(0xff0000ff),
child: SizedBox(
width: 50.0,
height: 75.0,
child: Align(
alignment: Alignment.centerRight,
child: Text(
'BLUE',
style: TextStyle(color: Colors.white),
),
),
),
),
],
),
Row(
spacing: 40.0,
mainAxisAlignment: MainAxisAlignment.spaceBetween,
children: <Widget>[
ColoredBox(
color: Color(0xffff0000),
child: SizedBox(
width: 50.0,
height: 75.0,
child: Align(
alignment: Alignment.centerLeft,
child: Text(
'RED',
style: TextStyle(color: Colors.white),
),
),
),
),
ColoredBox(
color: Color(0xff00ff00),
child: SizedBox(
width: 50.0,
height: 75.0,
child: Center(
child: Text(
'GREEN',
style: TextStyle(color: Colors.black),
),
),
),
),
ColoredBox(
color: Color(0xff0000ff),
child: SizedBox(
width: 50.0,
height: 75.0,
child: Align(
alignment: Alignment.centerRight,
child: Text(
'BLUE',
style: TextStyle(color: Colors.white),
),
),
),
),
],
),
Row(
spacing: 40.0,
mainAxisAlignment: MainAxisAlignment.spaceAround,
children: <Widget>[
ColoredBox(
color: Color(0xffff0000),
child: SizedBox(
width: 50.0,
height: 75.0,
child: Align(
alignment: Alignment.centerLeft,
child: Text(
'RED',
style: TextStyle(color: Colors.white),
),
),
),
),
ColoredBox(
color: Color(0xff00ff00),
child: SizedBox(
width: 50.0,
height: 75.0,
child: Center(
child: Text(
'GREEN',
style: TextStyle(color: Colors.black),
),
),
),
),
ColoredBox(
color: Color(0xff0000ff),
child: SizedBox(
width: 50.0,
height: 75.0,
child: Align(
alignment: Alignment.centerRight,
child: Text(
'BLUE',
style: TextStyle(color: Colors.white),
),
),
),
),
],
),
Row(
spacing: 40.0,
mainAxisAlignment: MainAxisAlignment.spaceEvenly,
children: <Widget>[
ColoredBox(
color: Color(0xffff0000),
child: SizedBox(
width: 50.0,
height: 75.0,
child: Align(
alignment: Alignment.centerLeft,
child: Text(
'RED',
style: TextStyle(color: Colors.white),
),
),
),
),
ColoredBox(
color: Color(0xff00ff00),
child: SizedBox(
width: 50.0,
height: 75.0,
child: Center(
child: Text(
'GREEN',
style: TextStyle(color: Colors.black),
),
),
),
),
ColoredBox(
color: Color(0xff0000ff),
child: SizedBox(
width: 50.0,
height: 75.0,
child: Align(
child: Text(
'BLUE',
style: TextStyle(color: Colors.white),
),
),
),
),
],
),
],
),
),
),
),
),
);
}
}
```
</details>
### Preview
<img width="1072" alt="Screenshot 2024-07-30 at 15 39 42" src="https://github.com/user-attachments/assets/717e9f5e-a491-4853-ba74-e72ec7493363">
@github-actionsgithub-actionsBot added tool Affects the "flutter" command-line tool. See also t: labels. framework flutter/packages/flutter repository. See also f: labels. labels Aug 5, 2024
@TahaTesserTahaTesser changed the title Reland 152472[Reland] Introduce doubleFlex.spacing parameter for Row/Column spacingAug 5, 2024
@TahaTesser
TahaTesser marked this pull request as ready for review August 5, 2024 20:25
' crossAxisAlignment: center',
' textDirection: ltr',
' verticalDirection: down',
' spacing: 0.0',

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This message test didn't account for spacing debug description, now fixed.

@goderbauergoderbauer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TahaTesserTahaTesser added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 5, 2024
@auto-submit

Copy link
Copy Markdown
Contributor

auto label is removed for flutter/flutter/152890, due to - The status or check suite Mac tool_integration_tests_2_5 has failed. Please fix the issues identified (or deflake) before re-applying this label.

@auto-submitauto-submitBot removed the autosubmit Merge PR when tree becomes green via auto submit App label Aug 5, 2024
@TahaTesserTahaTesser added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 5, 2024
@auto-submit
auto-submitBot merged commit 00ef750 into flutter:masterAug 5, 2024
@TahaTesser
TahaTesser deleted the reland-152472 branch August 5, 2024 23:06
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 6, 2024
auto-submitBot pushed a commit to flutter/packages that referenced this pull request Aug 6, 2024
Manual roll requested by tarrinneal@google.com
flutter/flutter@3832823...1dd7141
2024-08-06 engine-flutter-autoroll@skia.org Roll Flutter Engine from 376a853846ce to f5f6e966e7e7 (1 revision) (flutter/flutter#152911)
2024-08-06 zanderso@users.noreply.github.com Pass --no-dds to some integration tests driven by flutter drive (flutter/flutter#152898)
2024-08-06 kevmoo@users.noreply.github.com Manual dependency bump (flutter/flutter#152881)
2024-08-06 32538273+ValentinVignal@users.noreply.github.com Add tests for ordered_traversal_group.0.dart (flutter/flutter#152849)
2024-08-06 nate.w5687@gmail.com Implement `on` clauses (flutter/flutter#152706)
2024-08-06 engine-flutter-autoroll@skia.org Roll Flutter Engine from bc140a0124b7 to 376a853846ce (2 revisions) (flutter/flutter#152905)
2024-08-06 engine-flutter-autoroll@skia.org Roll Flutter Engine from e073ad2e3ad4 to bc140a0124b7 (1 revision) (flutter/flutter#152895)
2024-08-05 42016383+DBowen33@users.noreply.github.com added functionality to where SR will communicate button clicked (flutter/flutter#152185)
2024-08-05 goderbauer@google.com more docImports (flutter/flutter#151951)
2024-08-05 goderbauer@google.com Bump dartdoc to 8.0.13 (flutter/flutter#152896)
2024-08-05 tessertaha@gmail.com [Reland] Introduce `double` `Flex.spacing` parameter for `Row`/`Column` spacing (flutter/flutter#152890)
2024-08-05 36861262+QuncCccccc@users.noreply.github.com Fix CarouselView rebuild (flutter/flutter#152791)
2024-08-05 engine-flutter-autoroll@skia.org Roll Flutter Engine from 1bfd06cda313 to e073ad2e3ad4 (4 revisions) (flutter/flutter#152889)
2024-08-05 737941+loic-sharma@users.noreply.github.com Add migration to git ignore SwiftPM build directories (flutter/flutter#152766)
2024-08-05 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#152127)
2024-08-05 engine-flutter-autoroll@skia.org Roll Flutter Engine from 0aac60342005 to 1bfd06cda313 (2 revisions) (flutter/flutter#152868)
2024-08-05 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Introduce `double` `Flex.spacing` parameter for `Row`/`Column` spacing (#152472)" (flutter/flutter#152885)
2024-08-05 pateltirth454@gmail.com [Docs] DeviceOrientation Enum Correction (flutter/flutter#152876)
2024-08-05 zanderso@users.noreply.github.com Move Linux_build_test tests from staging to prod (flutter/flutter#152877)
2024-08-05 tessertaha@gmail.com Introduce `double` `Flex.spacing` parameter for `Row`/`Column` spacing (flutter/flutter#152472)
2024-08-05 zanderso@users.noreply.github.com Mark Linux_android_emu tests bringup: true (flutter/flutter#152867)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC rmistry@google.com,stuartmorgan@google.com,tarrinneal@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
TytaniumDev pushed a commit to TytaniumDev/flutter that referenced this pull request Aug 7, 2024
…n` spacing (flutter#152890)
Relands flutter#152472 (Fixed error causing message test, maybe by flutter#152501)
---
fixes [add spacing parameter to Column and Row](flutter#55378)
### `Column.spacing` Code sample
<details>
<summary>expand to view the code sample</summary> ```dart
import 'package:flutter/material.dart';
void main() => runApp(const MyApp());
class MyApp extends StatelessWidget {
const MyApp({super.key});
@OverRide
Widget build(BuildContext context) {
return MaterialApp(
debugShowCheckedModeBanner: false,
home: Scaffold(
backgroundColor: Colors.black,
body: Center(
child: Padding(
padding: const EdgeInsets.all(16.0),
child: DecoratedBox(
decoration: BoxDecoration(
border: Border.all(
color: Colors.amber,
)),
child: const Row(
mainAxisAlignment: MainAxisAlignment.spaceEvenly,
children: <Widget>[
Column(
spacing: 40.0,
// ignore: avoid_redundant_argument_values
mainAxisAlignment: MainAxisAlignment.start,
children: <Widget>[
ColoredBox(
color: Color(0xffff0000),
child: SizedBox(
width: 50.0,
height: 75.0,
child: Align(
alignment: Alignment.topCenter,
child: Text(
'RED',
style: TextStyle(color: Colors.white),
),
),
),
),
ColoredBox(
color: Color(0xff00ff00),
child: SizedBox(
width: 50.0,
height: 75.0,
child: Center(
child: Text(
'GREEN',
style: TextStyle(color: Colors.black),
),
),
),
),
ColoredBox(
color: Color(0xff0000ff),
child: SizedBox(
width: 50.0,
height: 75.0,
child: Align(
alignment: Alignment.bottomCenter,
child: Text(
'BLUE',
style: TextStyle(color: Colors.white),
),
),
),
),
],
),
Column(
spacing: 40.0,
mainAxisAlignment: MainAxisAlignment.center,
children: <Widget>[
ColoredBox(
color: Color(0xffff0000),
child: SizedBox(
width: 50.0,
height: 75.0,
child: Align(
alignment: Alignment.topCenter,
child: Text(
'RED',
style: TextStyle(color: Colors.white),
),
),
),
),
ColoredBox(
color: Color(0xff00ff00),
child: SizedBox(
width: 50.0,
height: 75.0,
child: Center(
child: Text(
'GREEN',
style: TextStyle(color: Colors.black),
),
),
),
),
ColoredBox(
color: Color(0xff0000ff),
child: SizedBox(
width: 50.0,
height: 75.0,
child: Align(
alignment: Alignment.bottomCenter,
child: Text(
'BLUE',
style: TextStyle(color: Colors.white),
),
),
),
),
],
),
Column(
spacing: 40.0,
mainAxisAlignment: MainAxisAlignment.end,
children: <Widget>[
ColoredBox(
color: Color(0xffff0000),
child: SizedBox(
width: 50.0,
height: 75.0,
child: Align(
alignment: Alignment.topCenter,
child: Text(
'RED',
style: TextStyle(color: Colors.white),
),
),
),
),
ColoredBox(
color: Color(0xff00ff00),
child: SizedBox(
width: 50.0,
height: 75.0,
child: Center(
child: Text(
'GREEN',
style: TextStyle(color: Colors.black),
),
),
),
),
ColoredBox(
color: Color(0xff0000ff),
child: SizedBox(
width: 50.0,
height: 75.0,
child: Align(
alignment: Alignment.bottomCenter,
child: Text(
'BLUE',
style: TextStyle(color: Colors.white),
),
),
),
),
],
),
Column(
spacing: 40.0,
mainAxisAlignment: MainAxisAlignment.spaceBetween,
children: <Widget>[
ColoredBox(
color: Color(0xffff0000),
child: SizedBox(
width: 50.0,
height: 75.0,
child: Align(
alignment: Alignment.topCenter,
child: Text(
'RED',
style: TextStyle(color: Colors.white),
),
),
),
),
ColoredBox(
color: Color(0xff00ff00),
child: SizedBox(
width: 50.0,
height: 75.0,
child: Center(
child: Text(
'GREEN',
style: TextStyle(color: Colors.black),
),
),
),
),
ColoredBox(
color: Color(0xff0000ff),
child: SizedBox(
width: 50.0,
height: 75.0,
child: Align(
alignment: Alignment.bottomCenter,
child: Text(
'BLUE',
style: TextStyle(color: Colors.white),
),
),
),
),
],
),
Column(
spacing: 40.0,
mainAxisAlignment: MainAxisAlignment.spaceAround,
children: <Widget>[
ColoredBox(
color: Color(0xffff0000),
child: SizedBox(
width: 50.0,
height: 75.0,
child: Align(
alignment: Alignment.topCenter,
child: Text(
'RED',
style: TextStyle(color: Colors.white),
),
),
),
),
ColoredBox(
color: Color(0xff00ff00),
child: SizedBox(
width: 50.0,
height: 75.0,
child: Center(
child: Text(
'GREEN',
style: TextStyle(color: Colors.black),
),
),
),
),
ColoredBox(
color: Color(0xff0000ff),
child: SizedBox(
width: 50.0,
height: 75.0,
child: Align(
alignment: Alignment.bottomCenter,
child: Text(
'BLUE',
style: TextStyle(color: Colors.white),
),
),
),
),
],
),
Column(
spacing: 40.0,
mainAxisAlignment: MainAxisAlignment.spaceEvenly,
children: <Widget>[
ColoredBox(
color: Color(0xffff0000),
child: SizedBox(
width: 50.0,
height: 75.0,
child: Align(
alignment: Alignment.topCenter,
child: Text(
'RED',
style: TextStyle(color: Colors.white),
),
),
),
),
ColoredBox(
color: Color(0xff00ff00),
child: SizedBox(
width: 50.0,
height: 75.0,
child: Center(
child: Text(
'GREEN',
style: TextStyle(color: Colors.black),
),
),
),
),
ColoredBox(
color: Color(0xff0000ff),
child: SizedBox(
width: 50.0,
height: 75.0,
child: Align(
alignment: Alignment.bottomCenter,
child: Text(
'BLUE',
style: TextStyle(color: Colors.white),
),
),
),
),
],
),
],
),
),
),
),
),
);
}
}
```
</details>
### Preview
<img width="1072" alt="Screenshot 2024-07-30 at 15 40 59" src="https://github.com/user-attachments/assets/14f21091-9e46-4a58-8552-1379f4ba9216">
### `Row.spacing` Code sample
<details>
<summary>expand to view the code sample</summary> ```dart
import 'package:flutter/material.dart';
void main() => runApp(const MyApp());
class MyApp extends StatelessWidget {
const MyApp({super.key});
@OverRide
Widget build(BuildContext context) {
return MaterialApp(
debugShowCheckedModeBanner: false,
home: Scaffold(
backgroundColor: Colors.black,
body: Center(
child: Padding(
padding: const EdgeInsets.all(16.0),
child: DecoratedBox(
decoration: BoxDecoration(
border: Border.all(
color: Colors.amber,
)),
child: const Column(
mainAxisAlignment: MainAxisAlignment.spaceEvenly,
children: <Widget>[
Row(
spacing: 40.0,
// ignore: avoid_redundant_argument_values
mainAxisAlignment: MainAxisAlignment.start,
children: <Widget>[
ColoredBox(
color: Color(0xffff0000),
child: SizedBox(
width: 50.0,
height: 75.0,
child: Align(
alignment: Alignment.centerLeft,
child: Text(
'RED',
style: TextStyle(color: Colors.white),
),
),
),
),
ColoredBox(
color: Color(0xff00ff00),
child: SizedBox(
width: 50.0,
height: 75.0,
child: Center(
child: Text(
'GREEN',
style: TextStyle(color: Colors.black),
),
),
),
),
ColoredBox(
color: Color(0xff0000ff),
child: SizedBox(
width: 50.0,
height: 75.0,
child: Align(
alignment: Alignment.centerRight,
child: Text(
'BLUE',
style: TextStyle(color: Colors.white),
),
),
),
),
],
),
Row(
spacing: 40.0,
mainAxisAlignment: MainAxisAlignment.center,
children: <Widget>[
ColoredBox(
color: Color(0xffff0000),
child: SizedBox(
width: 50.0,
height: 75.0,
child: Align(
alignment: Alignment.centerLeft,
child: Text(
'RED',
style: TextStyle(color: Colors.white),
),
),
),
),
ColoredBox(
color: Color(0xff00ff00),
child: SizedBox(
width: 50.0,
height: 75.0,
child: Center(
child: Text(
'GREEN',
style: TextStyle(color: Colors.black),
),
),
),
),
ColoredBox(
color: Color(0xff0000ff),
child: SizedBox(
width: 50.0,
height: 75.0,
child: Align(
alignment: Alignment.centerRight,
child: Text(
'BLUE',
style: TextStyle(color: Colors.white),
),
),
),
),
],
),
Row(
spacing: 40.0,
mainAxisAlignment: MainAxisAlignment.end,
children: <Widget>[
ColoredBox(
color: Color(0xffff0000),
child: SizedBox(
width: 50.0,
height: 75.0,
child: Align(
alignment: Alignment.centerLeft,
child: Text(
'RED',
style: TextStyle(color: Colors.white),
),
),
),
),
ColoredBox(
color: Color(0xff00ff00),
child: SizedBox(
width: 50.0,
height: 75.0,
child: Center(
child: Text(
'GREEN',
style: TextStyle(color: Colors.black),
),
),
),
),
ColoredBox(
color: Color(0xff0000ff),
child: SizedBox(
width: 50.0,
height: 75.0,
child: Align(
alignment: Alignment.centerRight,
child: Text(
'BLUE',
style: TextStyle(color: Colors.white),
),
),
),
),
],
),
Row(
spacing: 40.0,
mainAxisAlignment: MainAxisAlignment.spaceBetween,
children: <Widget>[
ColoredBox(
color: Color(0xffff0000),
child: SizedBox(
width: 50.0,
height: 75.0,
child: Align(
alignment: Alignment.centerLeft,
child: Text(
'RED',
style: TextStyle(color: Colors.white),
),
),
),
),
ColoredBox(
color: Color(0xff00ff00),
child: SizedBox(
width: 50.0,
height: 75.0,
child: Center(
child: Text(
'GREEN',
style: TextStyle(color: Colors.black),
),
),
),
),
ColoredBox(
color: Color(0xff0000ff),
child: SizedBox(
width: 50.0,
height: 75.0,
child: Align(
alignment: Alignment.centerRight,
child: Text(
'BLUE',
style: TextStyle(color: Colors.white),
),
),
),
),
],
),
Row(
spacing: 40.0,
mainAxisAlignment: MainAxisAlignment.spaceAround,
children: <Widget>[
ColoredBox(
color: Color(0xffff0000),
child: SizedBox(
width: 50.0,
height: 75.0,
child: Align(
alignment: Alignment.centerLeft,
child: Text(
'RED',
style: TextStyle(color: Colors.white),
),
),
),
),
ColoredBox(
color: Color(0xff00ff00),
child: SizedBox(
width: 50.0,
height: 75.0,
child: Center(
child: Text(
'GREEN',
style: TextStyle(color: Colors.black),
),
),
),
),
ColoredBox(
color: Color(0xff0000ff),
child: SizedBox(
width: 50.0,
height: 75.0,
child: Align(
alignment: Alignment.centerRight,
child: Text(
'BLUE',
style: TextStyle(color: Colors.white),
),
),
),
),
],
),
Row(
spacing: 40.0,
mainAxisAlignment: MainAxisAlignment.spaceEvenly,
children: <Widget>[
ColoredBox(
color: Color(0xffff0000),
child: SizedBox(
width: 50.0,
height: 75.0,
child: Align(
alignment: Alignment.centerLeft,
child: Text(
'RED',
style: TextStyle(color: Colors.white),
),
),
),
),
ColoredBox(
color: Color(0xff00ff00),
child: SizedBox(
width: 50.0,
height: 75.0,
child: Center(
child: Text(
'GREEN',
style: TextStyle(color: Colors.black),
),
),
),
),
ColoredBox(
color: Color(0xff0000ff),
child: SizedBox(
width: 50.0,
height: 75.0,
child: Align(
child: Text(
'BLUE',
style: TextStyle(color: Colors.white),
),
),
),
),
],
),
],
),
),
),
),
),
);
}
}
```
</details>
### Preview
<img width="1072" alt="Screenshot 2024-07-30 at 15 39 42" src="https://github.com/user-attachments/assets/717e9f5e-a491-4853-ba74-e72ec7493363">
Buchimi pushed a commit to Buchimi/flutter that referenced this pull request Sep 2, 2024
…n` spacing (flutter#152890)
Relands flutter#152472 (Fixed error causing message test, maybe by flutter#152501)
---
fixes [add spacing parameter to Column and Row](flutter#55378)
### `Column.spacing` Code sample
<details>
<summary>expand to view the code sample</summary> ```dart
import 'package:flutter/material.dart';
void main() => runApp(const MyApp());
class MyApp extends StatelessWidget {
const MyApp({super.key});
@OverRide
Widget build(BuildContext context) {
return MaterialApp(
debugShowCheckedModeBanner: false,
home: Scaffold(
backgroundColor: Colors.black,
body: Center(
child: Padding(
padding: const EdgeInsets.all(16.0),
child: DecoratedBox(
decoration: BoxDecoration(
border: Border.all(
color: Colors.amber,
)),
child: const Row(
mainAxisAlignment: MainAxisAlignment.spaceEvenly,
children: <Widget>[
Column(
spacing: 40.0,
// ignore: avoid_redundant_argument_values
mainAxisAlignment: MainAxisAlignment.start,
children: <Widget>[
ColoredBox(
color: Color(0xffff0000),
child: SizedBox(
width: 50.0,
height: 75.0,
child: Align(
alignment: Alignment.topCenter,
child: Text(
'RED',
style: TextStyle(color: Colors.white),
),
),
),
),
ColoredBox(
color: Color(0xff00ff00),
child: SizedBox(
width: 50.0,
height: 75.0,
child: Center(
child: Text(
'GREEN',
style: TextStyle(color: Colors.black),
),
),
),
),
ColoredBox(
color: Color(0xff0000ff),
child: SizedBox(
width: 50.0,
height: 75.0,
child: Align(
alignment: Alignment.bottomCenter,
child: Text(
'BLUE',
style: TextStyle(color: Colors.white),
),
),
),
),
],
),
Column(
spacing: 40.0,
mainAxisAlignment: MainAxisAlignment.center,
children: <Widget>[
ColoredBox(
color: Color(0xffff0000),
child: SizedBox(
width: 50.0,
height: 75.0,
child: Align(
alignment: Alignment.topCenter,
child: Text(
'RED',
style: TextStyle(color: Colors.white),
),
),
),
),
ColoredBox(
color: Color(0xff00ff00),
child: SizedBox(
width: 50.0,
height: 75.0,
child: Center(
child: Text(
'GREEN',
style: TextStyle(color: Colors.black),
),
),
),
),
ColoredBox(
color: Color(0xff0000ff),
child: SizedBox(
width: 50.0,
height: 75.0,
child: Align(
alignment: Alignment.bottomCenter,
child: Text(
'BLUE',
style: TextStyle(color: Colors.white),
),
),
),
),
],
),
Column(
spacing: 40.0,
mainAxisAlignment: MainAxisAlignment.end,
children: <Widget>[
ColoredBox(
color: Color(0xffff0000),
child: SizedBox(
width: 50.0,
height: 75.0,
child: Align(
alignment: Alignment.topCenter,
child: Text(
'RED',
style: TextStyle(color: Colors.white),
),
),
),
),
ColoredBox(
color: Color(0xff00ff00),
child: SizedBox(
width: 50.0,
height: 75.0,
child: Center(
child: Text(
'GREEN',
style: TextStyle(color: Colors.black),
),
),
),
),
ColoredBox(
color: Color(0xff0000ff),
child: SizedBox(
width: 50.0,
height: 75.0,
child: Align(
alignment: Alignment.bottomCenter,
child: Text(
'BLUE',
style: TextStyle(color: Colors.white),
),
),
),
),
],
),
Column(
spacing: 40.0,
mainAxisAlignment: MainAxisAlignment.spaceBetween,
children: <Widget>[
ColoredBox(
color: Color(0xffff0000),
child: SizedBox(
width: 50.0,
height: 75.0,
child: Align(
alignment: Alignment.topCenter,
child: Text(
'RED',
style: TextStyle(color: Colors.white),
),
),
),
),
ColoredBox(
color: Color(0xff00ff00),
child: SizedBox(
width: 50.0,
height: 75.0,
child: Center(
child: Text(
'GREEN',
style: TextStyle(color: Colors.black),
),
),
),
),
ColoredBox(
color: Color(0xff0000ff),
child: SizedBox(
width: 50.0,
height: 75.0,
child: Align(
alignment: Alignment.bottomCenter,
child: Text(
'BLUE',
style: TextStyle(color: Colors.white),
),
),
),
),
],
),
Column(
spacing: 40.0,
mainAxisAlignment: MainAxisAlignment.spaceAround,
children: <Widget>[
ColoredBox(
color: Color(0xffff0000),
child: SizedBox(
width: 50.0,
height: 75.0,
child: Align(
alignment: Alignment.topCenter,
child: Text(
'RED',
style: TextStyle(color: Colors.white),
),
),
),
),
ColoredBox(
color: Color(0xff00ff00),
child: SizedBox(
width: 50.0,
height: 75.0,
child: Center(
child: Text(
'GREEN',
style: TextStyle(color: Colors.black),
),
),
),
),
ColoredBox(
color: Color(0xff0000ff),
child: SizedBox(
width: 50.0,
height: 75.0,
child: Align(
alignment: Alignment.bottomCenter,
child: Text(
'BLUE',
style: TextStyle(color: Colors.white),
),
),
),
),
],
),
Column(
spacing: 40.0,
mainAxisAlignment: MainAxisAlignment.spaceEvenly,
children: <Widget>[
ColoredBox(
color: Color(0xffff0000),
child: SizedBox(
width: 50.0,
height: 75.0,
child: Align(
alignment: Alignment.topCenter,
child: Text(
'RED',
style: TextStyle(color: Colors.white),
),
),
),
),
ColoredBox(
color: Color(0xff00ff00),
child: SizedBox(
width: 50.0,
height: 75.0,
child: Center(
child: Text(
'GREEN',
style: TextStyle(color: Colors.black),
),
),
),
),
ColoredBox(
color: Color(0xff0000ff),
child: SizedBox(
width: 50.0,
height: 75.0,
child: Align(
alignment: Alignment.bottomCenter,
child: Text(
'BLUE',
style: TextStyle(color: Colors.white),
),
),
),
),
],
),
],
),
),
),
),
),
);
}
}
```
</details>
### Preview
<img width="1072" alt="Screenshot 2024-07-30 at 15 40 59" src="https://github.com/user-attachments/assets/14f21091-9e46-4a58-8552-1379f4ba9216">
### `Row.spacing` Code sample
<details>
<summary>expand to view the code sample</summary> ```dart
import 'package:flutter/material.dart';
void main() => runApp(const MyApp());
class MyApp extends StatelessWidget {
const MyApp({super.key});
@OverRide
Widget build(BuildContext context) {
return MaterialApp(
debugShowCheckedModeBanner: false,
home: Scaffold(
backgroundColor: Colors.black,
body: Center(
child: Padding(
padding: const EdgeInsets.all(16.0),
child: DecoratedBox(
decoration: BoxDecoration(
border: Border.all(
color: Colors.amber,
)),
child: const Column(
mainAxisAlignment: MainAxisAlignment.spaceEvenly,
children: <Widget>[
Row(
spacing: 40.0,
// ignore: avoid_redundant_argument_values
mainAxisAlignment: MainAxisAlignment.start,
children: <Widget>[
ColoredBox(
color: Color(0xffff0000),
child: SizedBox(
width: 50.0,
height: 75.0,
child: Align(
alignment: Alignment.centerLeft,
child: Text(
'RED',
style: TextStyle(color: Colors.white),
),
),
),
),
ColoredBox(
color: Color(0xff00ff00),
child: SizedBox(
width: 50.0,
height: 75.0,
child: Center(
child: Text(
'GREEN',
style: TextStyle(color: Colors.black),
),
),
),
),
ColoredBox(
color: Color(0xff0000ff),
child: SizedBox(
width: 50.0,
height: 75.0,
child: Align(
alignment: Alignment.centerRight,
child: Text(
'BLUE',
style: TextStyle(color: Colors.white),
),
),
),
),
],
),
Row(
spacing: 40.0,
mainAxisAlignment: MainAxisAlignment.center,
children: <Widget>[
ColoredBox(
color: Color(0xffff0000),
child: SizedBox(
width: 50.0,
height: 75.0,
child: Align(
alignment: Alignment.centerLeft,
child: Text(
'RED',
style: TextStyle(color: Colors.white),
),
),
),
),
ColoredBox(
color: Color(0xff00ff00),
child: SizedBox(
width: 50.0,
height: 75.0,
child: Center(
child: Text(
'GREEN',
style: TextStyle(color: Colors.black),
),
),
),
),
ColoredBox(
color: Color(0xff0000ff),
child: SizedBox(
width: 50.0,
height: 75.0,
child: Align(
alignment: Alignment.centerRight,
child: Text(
'BLUE',
style: TextStyle(color: Colors.white),
),
),
),
),
],
),
Row(
spacing: 40.0,
mainAxisAlignment: MainAxisAlignment.end,
children: <Widget>[
ColoredBox(
color: Color(0xffff0000),
child: SizedBox(
width: 50.0,
height: 75.0,
child: Align(
alignment: Alignment.centerLeft,
child: Text(
'RED',
style: TextStyle(color: Colors.white),
),
),
),
),
ColoredBox(
color: Color(0xff00ff00),
child: SizedBox(
width: 50.0,
height: 75.0,
child: Center(
child: Text(
'GREEN',
style: TextStyle(color: Colors.black),
),
),
),
),
ColoredBox(
color: Color(0xff0000ff),
child: SizedBox(
width: 50.0,
height: 75.0,
child: Align(
alignment: Alignment.centerRight,
child: Text(
'BLUE',
style: TextStyle(color: Colors.white),
),
),
),
),
],
),
Row(
spacing: 40.0,
mainAxisAlignment: MainAxisAlignment.spaceBetween,
children: <Widget>[
ColoredBox(
color: Color(0xffff0000),
child: SizedBox(
width: 50.0,
height: 75.0,
child: Align(
alignment: Alignment.centerLeft,
child: Text(
'RED',
style: TextStyle(color: Colors.white),
),
),
),
),
ColoredBox(
color: Color(0xff00ff00),
child: SizedBox(
width: 50.0,
height: 75.0,
child: Center(
child: Text(
'GREEN',
style: TextStyle(color: Colors.black),
),
),
),
),
ColoredBox(
color: Color(0xff0000ff),
child: SizedBox(
width: 50.0,
height: 75.0,
child: Align(
alignment: Alignment.centerRight,
child: Text(
'BLUE',
style: TextStyle(color: Colors.white),
),
),
),
),
],
),
Row(
spacing: 40.0,
mainAxisAlignment: MainAxisAlignment.spaceAround,
children: <Widget>[
ColoredBox(
color: Color(0xffff0000),
child: SizedBox(
width: 50.0,
height: 75.0,
child: Align(
alignment: Alignment.centerLeft,
child: Text(
'RED',
style: TextStyle(color: Colors.white),
),
),
),
),
ColoredBox(
color: Color(0xff00ff00),
child: SizedBox(
width: 50.0,
height: 75.0,
child: Center(
child: Text(
'GREEN',
style: TextStyle(color: Colors.black),
),
),
),
),
ColoredBox(
color: Color(0xff0000ff),
child: SizedBox(
width: 50.0,
height: 75.0,
child: Align(
alignment: Alignment.centerRight,
child: Text(
'BLUE',
style: TextStyle(color: Colors.white),
),
),
),
),
],
),
Row(
spacing: 40.0,
mainAxisAlignment: MainAxisAlignment.spaceEvenly,
children: <Widget>[
ColoredBox(
color: Color(0xffff0000),
child: SizedBox(
width: 50.0,
height: 75.0,
child: Align(
alignment: Alignment.centerLeft,
child: Text(
'RED',
style: TextStyle(color: Colors.white),
),
),
),
),
ColoredBox(
color: Color(0xff00ff00),
child: SizedBox(
width: 50.0,
height: 75.0,
child: Center(
child: Text(
'GREEN',
style: TextStyle(color: Colors.black),
),
),
),
),
ColoredBox(
color: Color(0xff0000ff),
child: SizedBox(
width: 50.0,
height: 75.0,
child: Align(
child: Text(
'BLUE',
style: TextStyle(color: Colors.white),
),
),
),
),
],
),
],
),
),
),
),
),
);
}
}
```
</details>
### Preview
<img width="1072" alt="Screenshot 2024-07-30 at 15 39 42" src="https://github.com/user-attachments/assets/717e9f5e-a491-4853-ba74-e72ec7493363">
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 11, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 12, 2024
creatorpiyush pushed a commit to creatorpiyush/packages that referenced this pull request Jun 10, 2026
)
Manual roll requested by tarrinneal@google.com
flutter/flutter@3832823...1dd7141
2024-08-06 engine-flutter-autoroll@skia.org Roll Flutter Engine from 376a853846ce to f5f6e966e7e7 (1 revision) (flutter/flutter#152911)
2024-08-06 zanderso@users.noreply.github.com Pass --no-dds to some integration tests driven by flutter drive (flutter/flutter#152898)
2024-08-06 kevmoo@users.noreply.github.com Manual dependency bump (flutter/flutter#152881)
2024-08-06 32538273+ValentinVignal@users.noreply.github.com Add tests for ordered_traversal_group.0.dart (flutter/flutter#152849)
2024-08-06 nate.w5687@gmail.com Implement `on` clauses (flutter/flutter#152706)
2024-08-06 engine-flutter-autoroll@skia.org Roll Flutter Engine from bc140a0124b7 to 376a853846ce (2 revisions) (flutter/flutter#152905)
2024-08-06 engine-flutter-autoroll@skia.org Roll Flutter Engine from e073ad2e3ad4 to bc140a0124b7 (1 revision) (flutter/flutter#152895)
2024-08-05 42016383+DBowen33@users.noreply.github.com added functionality to where SR will communicate button clicked (flutter/flutter#152185)
2024-08-05 goderbauer@google.com more docImports (flutter/flutter#151951)
2024-08-05 goderbauer@google.com Bump dartdoc to 8.0.13 (flutter/flutter#152896)
2024-08-05 tessertaha@gmail.com [Reland] Introduce `double` `Flex.spacing` parameter for `Row`/`Column` spacing (flutter/flutter#152890)
2024-08-05 36861262+QuncCccccc@users.noreply.github.com Fix CarouselView rebuild (flutter/flutter#152791)
2024-08-05 engine-flutter-autoroll@skia.org Roll Flutter Engine from 1bfd06cda313 to e073ad2e3ad4 (4 revisions) (flutter/flutter#152889)
2024-08-05 737941+loic-sharma@users.noreply.github.com Add migration to git ignore SwiftPM build directories (flutter/flutter#152766)
2024-08-05 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#152127)
2024-08-05 engine-flutter-autoroll@skia.org Roll Flutter Engine from 0aac60342005 to 1bfd06cda313 (2 revisions) (flutter/flutter#152868)
2024-08-05 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Introduce `double` `Flex.spacing` parameter for `Row`/`Column` spacing (#152472)" (flutter/flutter#152885)
2024-08-05 pateltirth454@gmail.com [Docs] DeviceOrientation Enum Correction (flutter/flutter#152876)
2024-08-05 zanderso@users.noreply.github.com Move Linux_build_test tests from staging to prod (flutter/flutter#152877)
2024-08-05 tessertaha@gmail.com Introduce `double` `Flex.spacing` parameter for `Row`/`Column` spacing (flutter/flutter#152472)
2024-08-05 zanderso@users.noreply.github.com Mark Linux_android_emu tests bringup: true (flutter/flutter#152867)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC rmistry@google.com,stuartmorgan@google.com,tarrinneal@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@coderabbitaicoderabbitaiBot mentioned this pull request Jun 17, 2026
9 tasks
bisor0627 pushed a commit to bisor0627/packages that referenced this pull request Jun 19, 2026
)
Manual roll requested by tarrinneal@google.com
flutter/flutter@3832823...1dd7141
2024-08-06 engine-flutter-autoroll@skia.org Roll Flutter Engine from 376a853846ce to f5f6e966e7e7 (1 revision) (flutter/flutter#152911)
2024-08-06 zanderso@users.noreply.github.com Pass --no-dds to some integration tests driven by flutter drive (flutter/flutter#152898)
2024-08-06 kevmoo@users.noreply.github.com Manual dependency bump (flutter/flutter#152881)
2024-08-06 32538273+ValentinVignal@users.noreply.github.com Add tests for ordered_traversal_group.0.dart (flutter/flutter#152849)
2024-08-06 nate.w5687@gmail.com Implement `on` clauses (flutter/flutter#152706)
2024-08-06 engine-flutter-autoroll@skia.org Roll Flutter Engine from bc140a0124b7 to 376a853846ce (2 revisions) (flutter/flutter#152905)
2024-08-06 engine-flutter-autoroll@skia.org Roll Flutter Engine from e073ad2e3ad4 to bc140a0124b7 (1 revision) (flutter/flutter#152895)
2024-08-05 42016383+DBowen33@users.noreply.github.com added functionality to where SR will communicate button clicked (flutter/flutter#152185)
2024-08-05 goderbauer@google.com more docImports (flutter/flutter#151951)
2024-08-05 goderbauer@google.com Bump dartdoc to 8.0.13 (flutter/flutter#152896)
2024-08-05 tessertaha@gmail.com [Reland] Introduce `double` `Flex.spacing` parameter for `Row`/`Column` spacing (flutter/flutter#152890)
2024-08-05 36861262+QuncCccccc@users.noreply.github.com Fix CarouselView rebuild (flutter/flutter#152791)
2024-08-05 engine-flutter-autoroll@skia.org Roll Flutter Engine from 1bfd06cda313 to e073ad2e3ad4 (4 revisions) (flutter/flutter#152889)
2024-08-05 737941+loic-sharma@users.noreply.github.com Add migration to git ignore SwiftPM build directories (flutter/flutter#152766)
2024-08-05 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#152127)
2024-08-05 engine-flutter-autoroll@skia.org Roll Flutter Engine from 0aac60342005 to 1bfd06cda313 (2 revisions) (flutter/flutter#152868)
2024-08-05 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Introduce `double` `Flex.spacing` parameter for `Row`/`Column` spacing (#152472)" (flutter/flutter#152885)
2024-08-05 pateltirth454@gmail.com [Docs] DeviceOrientation Enum Correction (flutter/flutter#152876)
2024-08-05 zanderso@users.noreply.github.com Move Linux_build_test tests from staging to prod (flutter/flutter#152877)
2024-08-05 tessertaha@gmail.com Introduce `double` `Flex.spacing` parameter for `Row`/`Column` spacing (flutter/flutter#152472)
2024-08-05 zanderso@users.noreply.github.com Mark Linux_android_emu tests bringup: true (flutter/flutter#152867)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC rmistry@google.com,stuartmorgan@google.com,tarrinneal@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmitMerge PR when tree becomes green via auto submit Appframeworkflutter/packages/flutter repository. See also f: labels.toolAffects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

add spacing parameter to Column and Row

2 participants

@TahaTesser@goderbauer