Add drawer and navigation drawer in a11y assessment app, also run `dart format` under a11y_assessments/ by hannah-hyj · Pull Request #153034 · flutter/flutter

hannah-hyj · 2024-08-07T17:11:21Z

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
I followed the breaking change policy and added Data Driven Fixes where supported.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

chunhtai

LGTM

… run `dart format` under a11y_assessments/ (flutter/flutter#153034)

Manual roll requested by tarrinneal@google.com flutter/flutter@d595e98...b6cd31e 2024-08-08 parlough@gmail.com Add a contribution doc on using reliable links in tooling (flutter/flutter#150962) 2024-08-08 engine-flutter-autoroll@skia.org Roll Flutter Engine from 94cf8c8fad31 to 3978ddd8d7a7 (1 revision) (flutter/flutter#153086) 2024-08-08 engine-flutter-autoroll@skia.org Roll Flutter Engine from 9dd4a2303898 to 94cf8c8fad31 (2 revisions) (flutter/flutter#153073) 2024-08-08 engine-flutter-autoroll@skia.org Roll Flutter Engine from 9932f34aac4e to 9dd4a2303898 (1 revision) (flutter/flutter#153067) 2024-08-08 jhy03261997@gmail.com Add drawer and navigation drawer in a11y assessment app, also run `dart format` under a11y_assessments/ (flutter/flutter#153034) 2024-08-07 engine-flutter-autoroll@skia.org Roll Flutter Engine from d4d9537bccdf to 9932f34aac4e (1 revision) (flutter/flutter#153063) 2024-08-07 leroux_bruno@yahoo.fr Clean up MenuAnchor (flutter/flutter#152946) 2024-08-07 kerber.jg@gmail.com Set default Cupertino `primaryContrastingColor` to white (flutter/flutter#153039) 2024-08-07 engine-flutter-autoroll@skia.org Roll Flutter Engine from 317eb6107646 to d4d9537bccdf (2 revisions) (flutter/flutter#153058) 2024-08-07 tylerholland@google.com Allow dropdown_menu to accept any EdgeInsetsGeometry (flutter/flutter#153053) 2024-08-07 magder@google.com Add xcresulttool --legacy flag for deprecated usage (flutter/flutter#152988) 2024-08-07 magder@google.com Revert "Marks Mac channels_integration_test to be flaky" (flutter/flutter#153044) 2024-08-07 engine-flutter-autoroll@skia.org Roll Flutter Engine from 69c29fb309bb to 317eb6107646 (2 revisions) (flutter/flutter#153048) 2024-08-07 fluttergithubbot@gmail.com Marks Linux android_java17_dependency_smoke_tests to be unflaky (flutter/flutter#153011) 2024-08-07 fluttergithubbot@gmail.com Marks Linux android_java11_dependency_smoke_tests to be unflaky (flutter/flutter#153010) 2024-08-07 yjbanov@google.com [web] hide the --web-renderer option in the tool (flutter/flutter#152683) 2024-08-07 goderbauer@google.com Doc imports again (flutter/flutter#152958) 2024-08-07 engine-flutter-autoroll@skia.org Roll Flutter Engine from 5a0fd5fbecc6 to 69c29fb309bb (6 revisions) (flutter/flutter#153035) 2024-08-07 engine-flutter-autoroll@skia.org Roll Packages from 551bde5 to 5cc0a01 (12 revisions) (flutter/flutter#153040) 2024-08-07 59215665+davidhicks980@users.noreply.github.com MenuAnchor hover traversal fixes (flutter/flutter#150914) 2024-08-07 34465683+rkishan516@users.noreply.github.com Style: Rename CupertinoSwitch activeColor and trackColor to activeTrackColor and InactiveTrackColor (flutter/flutter#151367) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC rmistry@google.com,stuartmorgan@google.com,tarrinneal@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

…rt format` under a11y_assessments/ (flutter#153034)

… run `dart format` under a11y_assessments/ (flutter/flutter#153034)

) Manual roll requested by tarrinneal@google.com flutter/flutter@d595e98...b6cd31e 2024-08-08 parlough@gmail.com Add a contribution doc on using reliable links in tooling (flutter/flutter#150962) 2024-08-08 engine-flutter-autoroll@skia.org Roll Flutter Engine from 94cf8c8fad31 to 3978ddd8d7a7 (1 revision) (flutter/flutter#153086) 2024-08-08 engine-flutter-autoroll@skia.org Roll Flutter Engine from 9dd4a2303898 to 94cf8c8fad31 (2 revisions) (flutter/flutter#153073) 2024-08-08 engine-flutter-autoroll@skia.org Roll Flutter Engine from 9932f34aac4e to 9dd4a2303898 (1 revision) (flutter/flutter#153067) 2024-08-08 jhy03261997@gmail.com Add drawer and navigation drawer in a11y assessment app, also run `dart format` under a11y_assessments/ (flutter/flutter#153034) 2024-08-07 engine-flutter-autoroll@skia.org Roll Flutter Engine from d4d9537bccdf to 9932f34aac4e (1 revision) (flutter/flutter#153063) 2024-08-07 leroux_bruno@yahoo.fr Clean up MenuAnchor (flutter/flutter#152946) 2024-08-07 kerber.jg@gmail.com Set default Cupertino `primaryContrastingColor` to white (flutter/flutter#153039) 2024-08-07 engine-flutter-autoroll@skia.org Roll Flutter Engine from 317eb6107646 to d4d9537bccdf (2 revisions) (flutter/flutter#153058) 2024-08-07 tylerholland@google.com Allow dropdown_menu to accept any EdgeInsetsGeometry (flutter/flutter#153053) 2024-08-07 magder@google.com Add xcresulttool --legacy flag for deprecated usage (flutter/flutter#152988) 2024-08-07 magder@google.com Revert "Marks Mac channels_integration_test to be flaky" (flutter/flutter#153044) 2024-08-07 engine-flutter-autoroll@skia.org Roll Flutter Engine from 69c29fb309bb to 317eb6107646 (2 revisions) (flutter/flutter#153048) 2024-08-07 fluttergithubbot@gmail.com Marks Linux android_java17_dependency_smoke_tests to be unflaky (flutter/flutter#153011) 2024-08-07 fluttergithubbot@gmail.com Marks Linux android_java11_dependency_smoke_tests to be unflaky (flutter/flutter#153010) 2024-08-07 yjbanov@google.com [web] hide the --web-renderer option in the tool (flutter/flutter#152683) 2024-08-07 goderbauer@google.com Doc imports again (flutter/flutter#152958) 2024-08-07 engine-flutter-autoroll@skia.org Roll Flutter Engine from 5a0fd5fbecc6 to 69c29fb309bb (6 revisions) (flutter/flutter#153035) 2024-08-07 engine-flutter-autoroll@skia.org Roll Packages from 551bde5 to 5cc0a01 (12 revisions) (flutter/flutter#153040) 2024-08-07 59215665+davidhicks980@users.noreply.github.com MenuAnchor hover traversal fixes (flutter/flutter#150914) 2024-08-07 34465683+rkishan516@users.noreply.github.com Style: Rename CupertinoSwitch activeColor and trackColor to activeTrackColor and InactiveTrackColor (flutter/flutter#151367) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC rmistry@google.com,stuartmorgan@google.com,tarrinneal@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

) Manual roll requested by tarrinneal@google.com flutter/flutter@d595e98...b6cd31e 2024-08-08 parlough@gmail.com Add a contribution doc on using reliable links in tooling (flutter/flutter#150962) 2024-08-08 engine-flutter-autoroll@skia.org Roll Flutter Engine from 94cf8c8fad31 to 3978ddd8d7a7 (1 revision) (flutter/flutter#153086) 2024-08-08 engine-flutter-autoroll@skia.org Roll Flutter Engine from 9dd4a2303898 to 94cf8c8fad31 (2 revisions) (flutter/flutter#153073) 2024-08-08 engine-flutter-autoroll@skia.org Roll Flutter Engine from 9932f34aac4e to 9dd4a2303898 (1 revision) (flutter/flutter#153067) 2024-08-08 jhy03261997@gmail.com Add drawer and navigation drawer in a11y assessment app, also run `dart format` under a11y_assessments/ (flutter/flutter#153034) 2024-08-07 engine-flutter-autoroll@skia.org Roll Flutter Engine from d4d9537bccdf to 9932f34aac4e (1 revision) (flutter/flutter#153063) 2024-08-07 leroux_bruno@yahoo.fr Clean up MenuAnchor (flutter/flutter#152946) 2024-08-07 kerber.jg@gmail.com Set default Cupertino `primaryContrastingColor` to white (flutter/flutter#153039) 2024-08-07 engine-flutter-autoroll@skia.org Roll Flutter Engine from 317eb6107646 to d4d9537bccdf (2 revisions) (flutter/flutter#153058) 2024-08-07 tylerholland@google.com Allow dropdown_menu to accept any EdgeInsetsGeometry (flutter/flutter#153053) 2024-08-07 magder@google.com Add xcresulttool --legacy flag for deprecated usage (flutter/flutter#152988) 2024-08-07 magder@google.com Revert "Marks Mac channels_integration_test to be flaky" (flutter/flutter#153044) 2024-08-07 engine-flutter-autoroll@skia.org Roll Flutter Engine from 69c29fb309bb to 317eb6107646 (2 revisions) (flutter/flutter#153048) 2024-08-07 fluttergithubbot@gmail.com Marks Linux android_java17_dependency_smoke_tests to be unflaky (flutter/flutter#153011) 2024-08-07 fluttergithubbot@gmail.com Marks Linux android_java11_dependency_smoke_tests to be unflaky (flutter/flutter#153010) 2024-08-07 yjbanov@google.com [web] hide the --web-renderer option in the tool (flutter/flutter#152683) 2024-08-07 goderbauer@google.com Doc imports again (flutter/flutter#152958) 2024-08-07 engine-flutter-autoroll@skia.org Roll Flutter Engine from 5a0fd5fbecc6 to 69c29fb309bb (6 revisions) (flutter/flutter#153035) 2024-08-07 engine-flutter-autoroll@skia.org Roll Packages from 09c21cd to cc4cfc5 (12 revisions) (flutter/flutter#153040) 2024-08-07 59215665+davidhicks980@users.noreply.github.com MenuAnchor hover traversal fixes (flutter/flutter#150914) 2024-08-07 34465683+rkishan516@users.noreply.github.com Style: Rename CupertinoSwitch activeColor and trackColor to activeTrackColor and InactiveTrackColor (flutter/flutter#151367) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC rmistry@google.com,stuartmorgan@google.com,tarrinneal@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

hannah-hyj added 2 commits August 7, 2024 10:03

add drawers
c27f81f

add tests
bb0e5af

hannah-hyj requested a review from chunhtai August 7, 2024 17:11

github-actionsBot added a: text input Entering text in a text field or keyboard related problems p: material_ui material_ui package in flutter/packages a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) labels Aug 7, 2024

chunhtai approved these changes Aug 7, 2024
View reviewed changes

hannah-hyj added 2 commits August 7, 2024 10:34

lint
fcf534d

add navigation rail
564ef20

hannah-hyj added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 8, 2024

auto-submitBot merged commit 9b281be into flutter:masterAug 8, 2024

engine-flutter-autoroll mentioned this pull request Aug 8, 2024
Manual roll Flutter from d595e98d85ea to b6cd31e6b5a6 (21 revisions) flutter/packages#7339
Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 8, 2024
9b281beAdd drawer and navigation drawer in a11y assessment app, also…
dd27685
… run `dart format` under a11y_assessments/ (flutter/flutter#153034)

engine-flutter-autoroll mentioned this pull request Aug 8, 2024
Roll Flutter from d595e98d85ea to b6cd31e6b5a6 (21 revisions) flutter/packages#7340
Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 8, 2024
9b281beAdd drawer and navigation drawer in a11y assessment app, also…
866d0b6
… run `dart format` under a11y_assessments/ (flutter/flutter#153034)

engine-flutter-autoroll mentioned this pull request Aug 8, 2024
Roll Flutter from d595e98d85ea to 51606f99a49e (22 revisions) flutter/packages#7341
Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 8, 2024
9b281beAdd drawer and navigation drawer in a11y assessment app, also…
dff1edc
… run `dart format` under a11y_assessments/ (flutter/flutter#153034)

engine-flutter-autoroll mentioned this pull request Aug 8, 2024
Roll Flutter from d595e98d85ea to d23be7a07de3 (24 revisions) flutter/packages#7342
Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 8, 2024
9b281beAdd drawer and navigation drawer in a11y assessment app, also…
598a607
… run `dart format` under a11y_assessments/ (flutter/flutter#153034)

engine-flutter-autoroll mentioned this pull request Aug 8, 2024
Roll Flutter from d595e98d85ea to a04ecb2b7234 (25 revisions) flutter/packages#7343
Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 8, 2024
9b281beAdd drawer and navigation drawer in a11y assessment app, also…
16c58c1
… run `dart format` under a11y_assessments/ (flutter/flutter#153034)

DBowen33 pushed a commit to DBowen33/flutter that referenced this pull request Aug 16, 2024
Add drawer and navigation drawer in a11y assessment app, also run `da…
1038987
…rt format` under a11y_assessments/ (flutter#153034)

Buchimi pushed a commit to Buchimi/flutter that referenced this pull request Sep 2, 2024
Add drawer and navigation drawer in a11y assessment app, also run `da…
0711de9
…rt format` under a11y_assessments/ (flutter#153034)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 11, 2024
9b281beAdd drawer and navigation drawer in a11y assessment app, also…
669bc73
… run `dart format` under a11y_assessments/ (flutter/flutter#153034)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 12, 2024
9b281beAdd drawer and navigation drawer in a11y assessment app, also…
6c55189
… run `dart format` under a11y_assessments/ (flutter/flutter#153034)

Navigation Menu

Uh oh!

Add drawer and navigation drawer in a11y assessment app, also run `dart format` under a11y_assessments/ - #153034

Add drawer and navigation drawer in a11y assessment app, also run `dart format` under a11y_assessments/#153034
auto-submit[bot] merged 4 commits into
flutter:masterfrom
hannah-hyj:a11y-drawer

hannah-hyj commented Aug 7, 2024

Uh oh!

chunhtai left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

hannah-hyj commented Aug 7, 2024

Pre-launch Checklist

Uh oh!

chunhtai left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants