Skip to content

Add minimum height for MaterialBanner - #153951

Merged
auto-submit[bot] merged 4 commits into
flutter:masterfrom
mansourzaki:issue#153666
Sep 4, 2024
Merged

Add minimum height for MaterialBanner#153951
auto-submit[bot] merged 4 commits into
flutter:masterfrom
mansourzaki:issue#153666

Conversation

@mansourzaki

@mansourzakimansourzaki commented Aug 22, 2024•
edited
Loading

Copy link
Copy Markdown
Contributor

This pr allows defining custom minimum height for material banner

fixes this #153666

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • I followed the [breaking change policy] and added [Data Driven Fixes] where supported.
  • All existing and new tests are passing.

@github-actionsgithub-actionsBot added framework flutter/packages/flutter repository. See also f: labels. p: material_ui material_ui package in flutter/packages labels Aug 22, 2024
@Piinks
Piinks requested a review from QuncCcccccAugust 28, 2024 18:04
QuncCccccc
QuncCccccc approved these changes Sep 4, 2024
View reviewed changes

@QuncCcccccQuncCccccc left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the contribution:)

Comment threadpackages/flutter/lib/src/material/banner.dart Outdated
Comment threadpackages/flutter/test/material/banner_test.dart Outdated
QuncCccccc
QuncCccccc approved these changes Sep 4, 2024
View reviewed changes

@QuncCcccccQuncCccccc left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM:)!

dkwingsmt
dkwingsmt approved these changes Sep 4, 2024
View reviewed changes

@dkwingsmtdkwingsmt left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with minor suggestions

Comment threadpackages/flutter/lib/src/material/banner.dart Outdated
Comment threadpackages/flutter/test/material/banner_test.dart Outdated
Comment threadpackages/flutter/test/material/banner_test.dart Outdated
piedcipher
piedcipher reviewed Sep 4, 2024
View reviewed changes

@piedcipherpiedcipher left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added some nits

Comment threadpackages/flutter/test/material/banner_test.dart Outdated
Comment threadpackages/flutter/test/material/banner_test.dart Outdated
Comment threadpackages/flutter/test/material/banner_test.dart Outdated
Comment threadpackages/flutter/test/material/banner_test.dart Outdated
Comment threadpackages/flutter/test/material/banner_test.dart Outdated
Comment threadpackages/flutter/test/material/banner_test.dart Outdated
Comment threadpackages/flutter/lib/src/material/banner.dart Outdated
@PiinksPiinks added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 4, 2024
@auto-submit
auto-submitBot merged commit 4e8df8b into flutter:masterSep 4, 2024
@engine-flutter-autorollengine-flutter-autoroll mentioned this pull request Sep 4, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 4, 2024
@engine-flutter-autoroll
4e8df8bAdd minimum height for MaterialBanner (flutter/flutter#153951)
ee07762
@piedcipherpiedcipher mentioned this pull request Sep 4, 2024
Closed
@engine-flutter-autorollengine-flutter-autoroll mentioned this pull request Sep 5, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 5, 2024
@engine-flutter-autoroll
4e8df8bAdd minimum height for MaterialBanner (flutter/flutter#153951)
6120db9
@engine-flutter-autorollengine-flutter-autoroll mentioned this pull request Sep 5, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 5, 2024
@engine-flutter-autoroll
4e8df8bAdd minimum height for MaterialBanner (flutter/flutter#153951)
4d37bcd
@engine-flutter-autorollengine-flutter-autoroll mentioned this pull request Sep 5, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 5, 2024
@engine-flutter-autoroll
4e8df8bAdd minimum height for MaterialBanner (flutter/flutter#153951)
7b5231b
@engine-flutter-autorollengine-flutter-autoroll mentioned this pull request Sep 5, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 5, 2024
@engine-flutter-autoroll
4e8df8bAdd minimum height for MaterialBanner (flutter/flutter#153951)
c47dbcb
@engine-flutter-autorollengine-flutter-autoroll mentioned this pull request Sep 5, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 5, 2024
@engine-flutter-autoroll
4e8df8bAdd minimum height for MaterialBanner (flutter/flutter#153951)
a2b8b49
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 11, 2024
@engine-flutter-autoroll
4e8df8bAdd minimum height for MaterialBanner (flutter/flutter#153951)
ba8686f
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 12, 2024
@engine-flutter-autoroll
4e8df8bAdd minimum height for MaterialBanner (flutter/flutter#153951)
effbb21
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dkwingsmtdkwingsmtdkwingsmt approved these changes
@piedcipherpiedcipherpiedcipher approved these changes
@QuncCcccccQuncCcccccQuncCccccc approved these changes

Assignees

No one assigned

Labels

autosubmitMerge PR when tree becomes green via auto submit Appframeworkflutter/packages/flutter repository. See also f: labels.p: material_uimaterial_ui package in flutter/packages

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@mansourzaki@dkwingsmt@piedcipher@QuncCccccc@Piinks