Uh oh!
There was an error while loading. Please reload this page.
Improve Documentation for ResizeImage Dimensions and Usage - #154212
Conversation
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Navaron Bracke <brackenavaron@gmail.com>
Co-authored-by: Navaron Bracke <brackenavaron@gmail.com>
Co-authored-by: Navaron Bracke <brackenavaron@gmail.com>
nate-thegrate
left a comment
There was a problem hiding this comment.
Thanks for the contribution!
I sort of crammed a bunch of feedback into this tiny addition, so take a look when you have a chance :)
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Nate Wilson <nathan.wilson1232@gmail.com>
Co-authored-by: Nate Wilson <nathan.wilson1232@gmail.com>
nate-thegrate
left a comment
There was a problem hiding this comment.
LGTM (with optional whitespace nit)
Thanks for making the improvement here!
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Nate Wilson <nathan.wilson1232@gmail.com>
RamonFarizel
commented
Sep 2, 2024
Thank you all for your support! It was nice to learn a bit more about all those details. |
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Nate Wilson <nathan.wilson1232@gmail.com>
hwh97
commented
Oct 25, 2024
@RamonFarizel@nate-thegrate Hey, Can someone confirm whether the |
Thank you @hwh97, this is a really good question. If you set This means that if the image is constrained, the I apologize for the confusion—originally my feedback on this PR was focused on syntax/grammar/style guidelines and I neglected to double-check that it matched the behavior. I'll go ahead and re-open #136508. |
This pull request enhances the documentation for the ResizeImage widget to provide clearer guidance on the use of the
widthandheightparameters.Fixes#136508
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.