Fix TabBar crash with SliverAppBar by hgraceb · Pull Request #154485 · flutter/flutter

hgraceb · 2024-09-01T13:01:13Z

Fixes#154484

Similar to #104998. Cause with updated at different phases of the same frame.

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
I followed the breaking change policy and added Data Driven Fixes where supported.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

nate-thegrate

LGTM, with 1 suggestion.

Thanks for fixing this!

nate-thegrate

It looks like the _TabBarState structure has some room for improvement, but that's outside the scope of this PR.

LGTM, thanks for the high-quality contribution!

Co-authored-by: Taha Tesser <tessertaha@gmail.com>

TahaTesser

LGTM

github-actionsBot added framework flutter/packages/flutter repository. See also f: labels. p: material_ui material_ui package in flutter/packages labels Sep 1, 2024

hgraceb mentioned this pull request Sep 1, 2024
TabBar crash with SliverAppBar #154484
Closed

hgraceb changed the title ~~Fix tabs crash with SliverAppBar~~Fix TabBar crash with SliverAppBarSep 1, 2024

github-actionsBot added the a: text input Entering text in a text field or keyboard related problems label Sep 1, 2024

TahaTesser requested review from TahaTesser and xu-baolin September 2, 2024 07:24

Piinks requested review from QuncCccccc and nate-thegrate September 4, 2024 18:04

nate-thegrate approved these changes Sep 4, 2024
View reviewed changes

Comment threadpackages/flutter/lib/src/widgets/editable_text.dart
Comment threadpackages/flutter/lib/src/material/tabs.dart
Comment threadpackages/flutter/test/material/tabs_test.dart

nate-thegrate approved these changes Sep 5, 2024
View reviewed changes

Comment threadpackages/flutter/lib/src/material/tabs.dart

TahaTesser suggested changes Sep 5, 2024
View reviewed changes

Comment threadpackages/flutter/test/material/tabs_test.dart Outdated
Comment threadpackages/flutter/test/material/tabs_test.dart

hgraceb force-pushed the tabs branch 2 times, most recently from bf7dd61 to ffbd717Compare September 5, 2024 17:06

TahaTesser suggested changes Sep 6, 2024
View reviewed changes

Comment threadpackages/flutter/test/material/tabs_test.dart Outdated

hgraceband others added 4 commits September 6, 2024 23:14

Fix tabs crash with SliverAppBar
149d404

Optimized comments
2c0cb2b

Improved title of test
59a9618

Update packages/flutter/test/material/tabs_test.dart
9b6dbf3
Co-authored-by: Taha Tesser <tessertaha@gmail.com>

hgraceb force-pushed the tabs branch from 4ed5cc5 to 9b6dbf3Compare September 6, 2024 15:14

hgraceb requested a review from TahaTesser September 6, 2024 15:17

TahaTesser approved these changes Sep 6, 2024
View reviewed changes

nate-thegrate added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 8, 2024

auto-submitBot merged commit 0139761 into flutter:masterSep 8, 2024

engine-flutter-autoroll mentioned this pull request Sep 8, 2024
Roll Flutter from 2e221e7308ba to 7a685ad07273 (11 revisions) flutter/packages#7602
Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 8, 2024
0139761Fix TabBar crash with SliverAppBar (flutter/flutter#154485)
7472795

engine-flutter-autoroll mentioned this pull request Sep 8, 2024
Roll Flutter from 2e221e7308ba to 7a685ad07273 (11 revisions) flutter/packages#7603
Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 8, 2024
0139761Fix TabBar crash with SliverAppBar (flutter/flutter#154485)
03b7ff4

engine-flutter-autoroll mentioned this pull request Sep 9, 2024
Roll Flutter from 2e221e7308ba to fb24721a2296 (13 revisions) flutter/packages#7608
Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 9, 2024
0139761Fix TabBar crash with SliverAppBar (flutter/flutter#154485)
33bfdc5

engine-flutter-autoroll mentioned this pull request Sep 9, 2024
Roll Flutter from 2e221e7308ba to cefca356e042 (16 revisions) flutter/packages#7613
Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 9, 2024
0139761Fix TabBar crash with SliverAppBar (flutter/flutter#154485)
82015c0

engine-flutter-autoroll mentioned this pull request Sep 10, 2024
Roll Flutter from 2e221e7308ba to 4be303510378 (30 revisions) flutter/packages#7615
Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 10, 2024
0139761Fix TabBar crash with SliverAppBar (flutter/flutter#154485)
7ed85e7

engine-flutter-autoroll mentioned this pull request Sep 10, 2024
Roll Flutter from 2e221e7308ba to bffa21549c7f (31 revisions) flutter/packages#7616
Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 10, 2024
0139761Fix TabBar crash with SliverAppBar (flutter/flutter#154485)
d82d678

engine-flutter-autoroll mentioned this pull request Sep 10, 2024
Roll Flutter from 2e221e7308ba to ebc2c3e437ee (32 revisions) flutter/packages#7617
Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 10, 2024
0139761Fix TabBar crash with SliverAppBar (flutter/flutter#154485)
d4a0511

engine-flutter-autoroll mentioned this pull request Sep 10, 2024
Roll Flutter from 2e221e7308ba to 24d0b1db0a42 (35 revisions) flutter/packages#7618
Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 10, 2024
0139761Fix TabBar crash with SliverAppBar (flutter/flutter#154485)
b04600a

engine-flutter-autoroll mentioned this pull request Sep 10, 2024
Roll Flutter from 2e221e7308ba to d88e69289562 (36 revisions) flutter/packages#7619
Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 10, 2024
0139761Fix TabBar crash with SliverAppBar (flutter/flutter#154485)
f9687fc

engine-flutter-autoroll mentioned this pull request Sep 10, 2024
Roll Flutter from 2e221e7308ba to 55af75d57bc7 (37 revisions) flutter/packages#7620
Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 10, 2024
0139761Fix TabBar crash with SliverAppBar (flutter/flutter#154485)
3f52084

engine-flutter-autoroll mentioned this pull request Sep 11, 2024
Roll Flutter from 2e221e7308ba to fadbf4447172 (55 revisions) flutter/packages#7623
Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 11, 2024
0139761Fix TabBar crash with SliverAppBar (flutter/flutter#154485)
82899f5

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 11, 2024
0139761Fix TabBar crash with SliverAppBar (flutter/flutter#154485)
15166bb

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 11, 2024
0139761Fix TabBar crash with SliverAppBar (flutter/flutter#154485)
69aa08f

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 11, 2024
0139761Fix TabBar crash with SliverAppBar (flutter/flutter#154485)
dc08861

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 11, 2024
0139761Fix TabBar crash with SliverAppBar (flutter/flutter#154485)
33fa013

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 11, 2024
0139761Fix TabBar crash with SliverAppBar (flutter/flutter#154485)
b321f17

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 11, 2024
0139761Fix TabBar crash with SliverAppBar (flutter/flutter#154485)
3fdc92f

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 12, 2024
0139761Fix TabBar crash with SliverAppBar (flutter/flutter#154485)
dbaca14

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 12, 2024
0139761Fix TabBar crash with SliverAppBar (flutter/flutter#154485)
a62d11b

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 12, 2024
0139761Fix TabBar crash with SliverAppBar (flutter/flutter#154485)
e22ed48

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 12, 2024
0139761Fix TabBar crash with SliverAppBar (flutter/flutter#154485)
b4f6c09

nate-thegrate mentioned this pull request Nov 5, 2024
Fix update order of SliverAppBar #158159
Merged
9 tasks

nate-thegrate mentioned this pull request Dec 4, 2024
Fix unexpected shown of Scrollbar #159386
Merged
9 tasks

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 11, 2024
0139761Fix TabBar crash with SliverAppBar (flutter/flutter#154485)
6799a90

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 12, 2024
0139761Fix TabBar crash with SliverAppBar (flutter/flutter#154485)
4e3f084

Navigation Menu

Uh oh!

Fix TabBar crash with SliverAppBar - #154485

Fix TabBar crash with SliverAppBar#154485
auto-submit[bot] merged 4 commits into
flutter:masterfrom
hgraceb:tabs

hgraceb commented Sep 1, 2024

Uh oh!

nate-thegrate left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

nate-thegrate left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

TahaTesser left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

hgraceb commented Sep 1, 2024

Pre-launch Checklist

Uh oh!

nate-thegrate left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

nate-thegrate left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

TahaTesser left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants