`RenderParagraph` should invalidate its `_SelectableFragment`s cached rects on window size updates by Renzo-Olivares · Pull Request #155719 · flutter/flutter

Renzo-Olivares · 2024-09-25T22:54:52Z

Fixes#155143
Fixes#120578

Pre-launch Checklist

I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
I read the [Tree Hygiene] wiki page, which explains my responsibilities.
I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
I signed the [CLA].
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is [test-exempt].
I followed the [breaking change policy] and added [Data Driven Fixes] where supported.
All existing and new tests are passing.

justinmc

LGTM 👍

justinmc · 2024-09-26T20:56:49Z


 @override
 void performLayout() {
+ _lastSelectableFragments?.forEach((_SelectableFragment element) => element.didChangeParagraphLayout());


Should this happen at the end of performLayout?

I think it should be fine here, since all we do is null the _cachedRect. We also call this at the beginning of markNeedsLayout, but that doesn't catch cases where the window resizes.

justinmc · 2024-09-26T20:57:35Z

+ await gesture.up();
+ await tester.pumpAndSettle();
+ }, variant: TargetPlatformVariant.all(),
+ skip: kIsWeb); // https://github.com/flutter/flutter/issues/125582.


Nit: Closing parenthesis on the next line I think?

…happen when the window is resized

…s cached rects on window size updates (flutter/flutter#155719)

Manual roll requested by stuartmorgan@google.com flutter/flutter@fa402c8...ead6b0d 2024-09-27 kustermann@google.com Remove left-over traces of "link-dry-run" - which isn't used anywhere in flutter (flutter/flutter#155820) 2024-09-27 engine-flutter-autoroll@skia.org Roll Flutter Engine from e57b440ec4ee to 7c603de2dca7 (5 revisions) (flutter/flutter#155811) 2024-09-27 bruno.leroux@gmail.com Fix DropdownMenu rendered behind AppBar (flutter/flutter#155539) 2024-09-27 engine-flutter-autoroll@skia.org Roll Flutter Engine from 53517772a5b0 to e57b440ec4ee (8 revisions) (flutter/flutter#155799) 2024-09-27 ditman@gmail.com Throw StateError when implicitView is null on `wrapWithDefaultView`. (flutter/flutter#155734) 2024-09-27 34871572+gmackall@users.noreply.github.com Roll packages manually (flutter/flutter#155786) 2024-09-27 rmolivares@renzo-olivares.dev fix: SelectableText should handle focus changes (flutter/flutter#155771) 2024-09-27 34871572+gmackall@users.noreply.github.com Use flutter from in same repo (not path) in `generate_gradle_lockfiles.dart` (again) (flutter/flutter#155794) 2024-09-26 34871572+gmackall@users.noreply.github.com Use flutter from in same repo (not path) in `generate_gradle_lockfiles.dart` (flutter/flutter#155790) 2024-09-26 rmolivares@renzo-olivares.dev `RenderParagraph` should invalidate its `_SelectableFragment`s cached rects on window size updates (flutter/flutter#155719) 2024-09-26 zeqinjie@qq.com Fix broken text field with set hint and min and max lines(#153183) (flutter/flutter#153235) 2024-09-26 engine-flutter-autoroll@skia.org Roll Flutter Engine from 9e6133e8d906 to 53517772a5b0 (1 revision) (flutter/flutter#155772) 2024-09-26 ian@hixie.ch Fix line-wrapping in `flutter create` error message. (flutter/flutter#150325) 2024-09-26 christopherfujino@gmail.com remove fujino from CODEOWNERS (flutter/flutter#155369) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC camillesimon@google.com,stuartmorgan@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

…s cached rects on window size updates (flutter/flutter#155719)

) Manual roll requested by stuartmorgan@google.com flutter/flutter@fa402c8...ead6b0d 2024-09-27 kustermann@google.com Remove left-over traces of "link-dry-run" - which isn't used anywhere in flutter (flutter/flutter#155820) 2024-09-27 engine-flutter-autoroll@skia.org Roll Flutter Engine from e57b440ec4ee to 7c603de2dca7 (5 revisions) (flutter/flutter#155811) 2024-09-27 bruno.leroux@gmail.com Fix DropdownMenu rendered behind AppBar (flutter/flutter#155539) 2024-09-27 engine-flutter-autoroll@skia.org Roll Flutter Engine from 53517772a5b0 to e57b440ec4ee (8 revisions) (flutter/flutter#155799) 2024-09-27 ditman@gmail.com Throw StateError when implicitView is null on `wrapWithDefaultView`. (flutter/flutter#155734) 2024-09-27 34871572+gmackall@users.noreply.github.com Roll packages manually (flutter/flutter#155786) 2024-09-27 rmolivares@renzo-olivares.dev fix: SelectableText should handle focus changes (flutter/flutter#155771) 2024-09-27 34871572+gmackall@users.noreply.github.com Use flutter from in same repo (not path) in `generate_gradle_lockfiles.dart` (again) (flutter/flutter#155794) 2024-09-26 34871572+gmackall@users.noreply.github.com Use flutter from in same repo (not path) in `generate_gradle_lockfiles.dart` (flutter/flutter#155790) 2024-09-26 rmolivares@renzo-olivares.dev `RenderParagraph` should invalidate its `_SelectableFragment`s cached rects on window size updates (flutter/flutter#155719) 2024-09-26 zeqinjie@qq.com Fix broken text field with set hint and min and max lines(#153183) (flutter/flutter#153235) 2024-09-26 engine-flutter-autoroll@skia.org Roll Flutter Engine from 9e6133e8d906 to 53517772a5b0 (1 revision) (flutter/flutter#155772) 2024-09-26 ian@hixie.ch Fix line-wrapping in `flutter create` error message. (flutter/flutter#150325) 2024-09-26 christopherfujino@gmail.com remove fujino from CODEOWNERS (flutter/flutter#155369) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC camillesimon@google.com,stuartmorgan@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

github-actionsBot added the framework flutter/packages/flutter repository. See also f: labels. label Sep 25, 2024

Renzo-Olivares changed the title ~~RenderParagraph should invalidate its _SelectableFragments cached rects on window size change~~RenderParagraph should invalidate its _SelectableFragments cached rects on window size updatesSep 25, 2024

Renzo-Olivares changed the title ~~RenderParagraph should invalidate its _SelectableFragments cached rects on window size updates~~RenderParagraph should invalidate its _SelectableFragments cached rects on window size updatesSep 25, 2024

Renzo-Olivares requested a review from justinmc September 25, 2024 22:57

Renzo-Olivares mentioned this pull request Sep 26, 2024
paragraph.dart _cachedRect is not refreshed after the window width changes, which results in limited selection #155143
Closed

justinmc approved these changes Sep 26, 2024
View reviewed changes

Renzo Olivares added 4 commits September 26, 2024 15:07

Should invalidate _cachedRect when performLayout is called, this can …
aceecad
…happen when the window is resized

Add regression test
ee44045

skip test for web, due to issue with html renderer
15057c0

address reviewer comments
de7efe5

Renzo-Olivares added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 26, 2024

auto-submitBot merged commit 9a64920 into flutter:masterSep 26, 2024

engine-flutter-autoroll mentioned this pull request Sep 27, 2024
Roll Flutter from fa402c8057a1 to ead6b0d17c89 (14 revisions) flutter/packages#7718
Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 27, 2024
9a64920RenderParagraphshould invalidate its_SelectableFragment…
1b0a57c
…s cached rects on window size updates (flutter/flutter#155719)

engine-flutter-autoroll mentioned this pull request Sep 27, 2024
Roll Flutter from fa402c8057a1 to ead6b0d17c89 (14 revisions) flutter/packages#7719
Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 27, 2024
9a64920RenderParagraphshould invalidate its_SelectableFragment…
1576342
…s cached rects on window size updates (flutter/flutter#155719)

engine-flutter-autoroll mentioned this pull request Sep 27, 2024
Roll Flutter from fa402c8057a1 to 180f40108bcc (15 revisions) flutter/packages#7720
Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 27, 2024
9a64920RenderParagraphshould invalidate its_SelectableFragment…
9b04e6c
…s cached rects on window size updates (flutter/flutter#155719)

Piinks mentioned this pull request Sep 27, 2024
Flutter Framework Team: Notable Commits #121415
Closed

engine-flutter-autoroll mentioned this pull request Sep 28, 2024
Roll Flutter from fa402c8057a1 to 9f88de930bb5 (24 revisions) flutter/packages#7726
Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 28, 2024
9a64920RenderParagraphshould invalidate its_SelectableFragment…
942e7bf
…s cached rects on window size updates (flutter/flutter#155719)

engine-flutter-autoroll mentioned this pull request Sep 28, 2024
Roll Flutter from fa402c8057a1 to 9f88de930bb5 (24 revisions) flutter/packages#7727
Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 28, 2024
9a64920RenderParagraphshould invalidate its_SelectableFragment…
2a0ded8
…s cached rects on window size updates (flutter/flutter#155719)

engine-flutter-autoroll mentioned this pull request Sep 29, 2024
Roll Flutter from fa402c8057a1 to 4fdfbd4dde8a (28 revisions) flutter/packages#7728
Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 29, 2024
9a64920RenderParagraphshould invalidate its_SelectableFragment…
286dc3f
…s cached rects on window size updates (flutter/flutter#155719)

engine-flutter-autoroll mentioned this pull request Sep 29, 2024
Roll Flutter from fa402c8057a1 to 4fdfbd4dde8a (28 revisions) flutter/packages#7729
Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 29, 2024
9a64920RenderParagraphshould invalidate its_SelectableFragment…
81259d1
…s cached rects on window size updates (flutter/flutter#155719)

engine-flutter-autoroll mentioned this pull request Sep 30, 2024
Roll Flutter from fa402c8057a1 to e3828ec94022 (33 revisions) flutter/packages#7736
Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 30, 2024
9a64920RenderParagraphshould invalidate its_SelectableFragment…
e71042b
…s cached rects on window size updates (flutter/flutter#155719)

engine-flutter-autoroll mentioned this pull request Sep 30, 2024
Roll Flutter from fa402c8057a1 to 84f65686d999 (34 revisions) flutter/packages#7737
Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 1, 2024
9a64920RenderParagraphshould invalidate its_SelectableFragment…
d82d24a
…s cached rects on window size updates (flutter/flutter#155719)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 1, 2024
9a64920RenderParagraphshould invalidate its_SelectableFragment…
d4ee281
…s cached rects on window size updates (flutter/flutter#155719)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 1, 2024
9a64920RenderParagraphshould invalidate its_SelectableFragment…
5224ea5
…s cached rects on window size updates (flutter/flutter#155719)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 1, 2024
9a64920RenderParagraphshould invalidate its_SelectableFragment…
9c40735
…s cached rects on window size updates (flutter/flutter#155719)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 2, 2024
9a64920RenderParagraphshould invalidate its_SelectableFragment…
4e1362c
…s cached rects on window size updates (flutter/flutter#155719)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 2, 2024
9a64920RenderParagraphshould invalidate its_SelectableFragment…
aadb073
…s cached rects on window size updates (flutter/flutter#155719)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 2, 2024
9a64920RenderParagraphshould invalidate its_SelectableFragment…
7cc4a59
…s cached rects on window size updates (flutter/flutter#155719)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 2, 2024
9a64920RenderParagraphshould invalidate its_SelectableFragment…
f7d2e09
…s cached rects on window size updates (flutter/flutter#155719)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 2, 2024
9a64920RenderParagraphshould invalidate its_SelectableFragment…
0fb3e04
…s cached rects on window size updates (flutter/flutter#155719)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 2, 2024
9a64920RenderParagraphshould invalidate its_SelectableFragment…
d10ab0e
…s cached rects on window size updates (flutter/flutter#155719)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 3, 2024
9a64920RenderParagraphshould invalidate its_SelectableFragment…
b61b816
…s cached rects on window size updates (flutter/flutter#155719)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 3, 2024
9a64920RenderParagraphshould invalidate its_SelectableFragment…
b337ada
…s cached rects on window size updates (flutter/flutter#155719)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 3, 2024
9a64920RenderParagraphshould invalidate its_SelectableFragment…
ae245af
…s cached rects on window size updates (flutter/flutter#155719)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 3, 2024
9a64920RenderParagraphshould invalidate its_SelectableFragment…
9faab99
…s cached rects on window size updates (flutter/flutter#155719)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 3, 2024
9a64920RenderParagraphshould invalidate its_SelectableFragment…
7f7dfa5
…s cached rects on window size updates (flutter/flutter#155719)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 3, 2024
9a64920RenderParagraphshould invalidate its_SelectableFragment…
dbccbb4
…s cached rects on window size updates (flutter/flutter#155719)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 4, 2024
9a64920RenderParagraphshould invalidate its_SelectableFragment…
f4115e8
…s cached rects on window size updates (flutter/flutter#155719)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 4, 2024
9a64920RenderParagraphshould invalidate its_SelectableFragment…
68488bc
…s cached rects on window size updates (flutter/flutter#155719)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 4, 2024
9a64920RenderParagraphshould invalidate its_SelectableFragment…
b07e348
…s cached rects on window size updates (flutter/flutter#155719)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 5, 2024
9a64920RenderParagraphshould invalidate its_SelectableFragment…
86d7f70
…s cached rects on window size updates (flutter/flutter#155719)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 5, 2024
9a64920RenderParagraphshould invalidate its_SelectableFragment…
337f5a7
…s cached rects on window size updates (flutter/flutter#155719)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 6, 2024
9a64920RenderParagraphshould invalidate its_SelectableFragment…
4191a2c
…s cached rects on window size updates (flutter/flutter#155719)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 6, 2024
9a64920RenderParagraphshould invalidate its_SelectableFragment…
aa0617a
…s cached rects on window size updates (flutter/flutter#155719)

engine-flutter-autoroll mentioned this pull request Oct 7, 2024
Manual roll Flutter from fa402c8057a1 to ead6b0d17c89 (14 revisions) flutter/packages#7806
Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 7, 2024
9a64920RenderParagraphshould invalidate its_SelectableFragment…
9862a25
…s cached rects on window size updates (flutter/flutter#155719)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 11, 2024
9a64920RenderParagraphshould invalidate its_SelectableFragment…
3524325
…s cached rects on window size updates (flutter/flutter#155719)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 12, 2024
9a64920RenderParagraphshould invalidate its_SelectableFragment…
0421e17
…s cached rects on window size updates (flutter/flutter#155719)

Navigation Menu

Uh oh!

`RenderParagraph` should invalidate its `_SelectableFragment`s cached rects on window size updates - #155719

`RenderParagraph` should invalidate its `_SelectableFragment`s cached rects on window size updates#155719
auto-submit[bot] merged 4 commits into
flutter:masterfrom
Renzo-Olivares:sa-screen-resize-fix

Renzo-Olivares commented Sep 25, 2024•
edited
Loading

Uh oh!

justinmc left a comment

Uh oh!

justinmcSep 26, 2024

Uh oh!

Renzo-OlivaresSep 26, 2024•
edited
Loading

Uh oh!

justinmcSep 26, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

Renzo-Olivares commented Sep 25, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-launch Checklist

Uh oh!

justinmc left a comment

Choose a reason for hiding this comment

Uh oh!

justinmcSep 26, 2024

Choose a reason for hiding this comment

Uh oh!

Renzo-OlivaresSep 26, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

justinmcSep 26, 2024

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Renzo-Olivares commented Sep 25, 2024•
edited
Loading

Renzo-OlivaresSep 26, 2024•
edited
Loading