Skip to content

Remove dependency on web_tests/artifacts. - #160700

Merged
auto-submit[bot] merged 4 commits into
flutter:masterfrom
eyebrowsoffire:remove_artifacts_dependency
Dec 22, 2024
Merged

Remove dependency on web_tests/artifacts.#160700
auto-submit[bot] merged 4 commits into
flutter:masterfrom
eyebrowsoffire:remove_artifacts_dependency

Conversation

@eyebrowsoffire

Copy link
Copy Markdown
Contributor

We no longer pass web_tests/artifacts via CAS, so we need to remove it as a dependency.

We no longer pass `web_tests/artifacts` via CAS, so we need to remove it
as a dependency.
@flutter-dashboard

Copy link
Copy Markdown

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group.

@github-actionsgithub-actionsBot added the engine flutter/engine related. See also e: labels. label Dec 21, 2024

@yjbanovyjbanov left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@eyebrowsoffireeyebrowsoffire added the autosubmit Merge PR when tree becomes green via auto submit App label Dec 21, 2024
@auto-submitauto-submitBot removed the autosubmit Merge PR when tree becomes green via auto submit App label Dec 21, 2024
@auto-submit

Copy link
Copy Markdown
Contributor

auto label is removed for flutter/flutter/160700, due to - The status or check suite Windows build_tests_6_9 has failed. Please fix the issues identified (or deflake) before re-applying this label.

@jtmcdolejtmcdole added the autosubmit Merge PR when tree becomes green via auto submit App label Dec 22, 2024
@auto-submit
auto-submitBot added this pull request to the merge queueDec 22, 2024
Merged via the queue into flutter:master with commit cb40d94Dec 22, 2024
@flutter-dashboardflutter-dashboardBot removed the autosubmit Merge PR when tree becomes green via auto submit App label Dec 22, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 6, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 6, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 6, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 7, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 7, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 7, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 7, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 7, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 7, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 7, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 7, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 8, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 8, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 8, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 8, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 12, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 13, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 13, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 6, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 7, 2025
@eyebrowsoffire
eyebrowsoffire deleted the remove_artifacts_dependency branch December 12, 2025 21:53
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

engineflutter/engine related. See also e: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@eyebrowsoffire@yjbanov@jtmcdole