Remove default for stripped option in `engine/src/flutter/tools/gn`, don't strip by default on android by gmackall · Pull Request #161546 · flutter/flutter

gmackall · 2025-01-13T20:52:53Z

Remake of flutter-team-archive/engine#52852.

Makes it so that stripped defaults to false for android in gn arguments, i.e. we don't strip the Android engine builds. AGP does this by default when the NDK is installed (and we download it automatically now after #159756).

In testing, the step that AGP does to strip symbols adds ~1-2 seconds to the build.

Adds a tool verification for release app bundle builds that checks to make sure we have stripped the debug symbols and placed them in the BUNDLE-METADATA directory. The check is done by invoking apkanalyzer, which takes ~0.5 seconds, which is why the check is only enabled for release builds.

BEFORE LANDING: I need to follow up on flutter-team-archive/engine#50443 (comment), to ensure we start stripping symbols internally as well.

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
I followed the breaking change policy and added Data Driven Fixes where supported.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

reidbaker · 2025-01-30T16:22:27Z

+ processManager.addCommand(
+ const FakeCommand(
+ command: <String>[
+ 'gradlew',


There are a lot of flags here that probably came from the flutter tool. Later when the tool is changed and we need to update this test it will be harder to figure out why.
link where you came up with these flags and their values.

Pulled out to a constant which will make updating easy. For where they came from, I just copied them from the existing tests. I can go find where all the flags come from if you think it is worthwhile

bkonyi

I think we can share a lot of the logic between tests, so it's probably worth taking another look and refactoring them.

…ls/gn`, don't strip by default on android (flutter/flutter#161546)

flutter#161546 changed the stripped option with the intent to be true for android, and false for all other targets, but the check never worked as intended because parser store_true action default value is False so the final else was never used. This fixes the build size increase that was noticed on flutter 3.32 for linux targets

release build got much bigger since flutter 3.32 (for debug it went from 83MB to 385MB) This is apparently just because the lib is no longer stripped since [1] This looks like a bug since we don't target android (tentative fix in [2]), but until that lands just set --stripped manually. Even if there is no C symbol dart stacktraces are available so most people don't need these. Link: flutter/flutter#161546 [1] Link: flutter/flutter#181984 [2]

flutter#161546 changed the stripped option with the intent to be true for android, and false for all other targets, but the check never worked as intended because parser store_true action default value is False so the final else was never used. This fixes the build size increase that was noticed on flutter 3.32 for linux targets

#161546 changed the stripped option with the intent to be true for android, and false for all other targets, but the check never worked as intended because parser store_true action default value is False so the final else was never used. This fixes the build size increase that was noticed on flutter 3.32 for linux targets Fixes#181983 ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [ ] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [ ] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [ ] I added new tests to check the change I am making, or this PR is [test-exempt]. - [ ] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [ ] All existing and new tests are passing.

flutter#161546 changed the stripped option with the intent to be true for android, and false for all other targets, but the check never worked as intended because parser store_true action default value is False so the final else was never used. This fixes the build size increase that was noticed on flutter 3.32 for linux targets Fixesflutter#181983 ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [ ] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [ ] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [ ] I added new tests to check the change I am making, or this PR is [test-exempt]. - [ ] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [ ] All existing and new tests are passing.

remake engine pr changing default for symbol stripping on android
cb9d6c7

gmackall mentioned this pull request Jan 13, 2025
Remove default for stripped option, don't strip by default on android flutter-team-archive/engine#52852
Closed
8 tasks

github-actionsBot added the engine flutter/engine related. See also e: labels. label Jan 13, 2025

gmackalland others added 4 commits January 27, 2025 08:53

Merge branch 'master' into remake_dont_strip_android_symbols
83a2a40

Merge branch 'flutter:master' into remake_dont_strip_android_symbols
8dfb472

Merge branch 'flutter:master' into remake_dont_strip_android_symbols
49fc677

start for enforcing app bundles have debug symbols included
8adad84

github-actionsBot added the tool Affects the "flutter" command-line tool. See also t: labels. label Jan 29, 2025

mackall-workand others added 13 commits January 29, 2025 12:34

enforce check, format
0be2826

only verify this for aab
d6e1f1e

Merge branch 'master' into remake_dont_strip_android_symbols
4cdf4cf

push missed name change
74877d6

apply to each architecture, and make only for release
6350337

format
7ab7370

only test for at least one arch, instead of all
d0d975f

its apkanalyzer.bat on windows
17f0772

add tests
f46259e

fix test name
6e5fcff

test to ensure we don't invoke apkanalyzer in debug
1b9913f

make the test not hardcoded
3b1b7b9

format
4cae103

gmackall marked this pull request as ready for review January 30, 2025 01:22

Merge branch 'master' into remake_dont_strip_android_symbols
f5ee7bc

gmackall requested review from a team and bkonyi January 30, 2025 15:34

gmackall changed the title ~~[remake] Remove default for stripped option, don't strip by default on android~~Remove default for stripped option in engine/src/flutter/tools/gn, don't strip by default on androidJan 30, 2025

reidbaker reviewed Jan 30, 2025
View reviewed changes

pull out common portions of test gradle command, and use a group
0a3ab63

bkonyi reviewed Jan 30, 2025
View reviewed changes

pull apkanalyzer output to top group level
7b1201b

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 9, 2025
df114fbRemove default for stripped option in `engine/src/flutter/too…
a2cef5e
…ls/gn`, don't strip by default on android (flutter/flutter#161546)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 9, 2025
df114fbRemove default for stripped option in `engine/src/flutter/too…
738a15f
…ls/gn`, don't strip by default on android (flutter/flutter#161546)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 10, 2025
df114fbRemove default for stripped option in `engine/src/flutter/too…
9cf5ed9
…ls/gn`, don't strip by default on android (flutter/flutter#161546)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 10, 2025
df114fbRemove default for stripped option in `engine/src/flutter/too…
8071506
…ls/gn`, don't strip by default on android (flutter/flutter#161546)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 10, 2025
df114fbRemove default for stripped option in `engine/src/flutter/too…
ba8ca9b
…ls/gn`, don't strip by default on android (flutter/flutter#161546)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 10, 2025
df114fbRemove default for stripped option in `engine/src/flutter/too…
1b00a8e
…ls/gn`, don't strip by default on android (flutter/flutter#161546)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 10, 2025
df114fbRemove default for stripped option in `engine/src/flutter/too…
21bf33e
…ls/gn`, don't strip by default on android (flutter/flutter#161546)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 11, 2025
df114fbRemove default for stripped option in `engine/src/flutter/too…
6131f72
…ls/gn`, don't strip by default on android (flutter/flutter#161546)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 11, 2025
df114fbRemove default for stripped option in `engine/src/flutter/too…
7b3ae3e
…ls/gn`, don't strip by default on android (flutter/flutter#161546)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 11, 2025
df114fbRemove default for stripped option in `engine/src/flutter/too…
c196eff
…ls/gn`, don't strip by default on android (flutter/flutter#161546)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 11, 2025
df114fbRemove default for stripped option in `engine/src/flutter/too…
58196bd
…ls/gn`, don't strip by default on android (flutter/flutter#161546)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 11, 2025
df114fbRemove default for stripped option in `engine/src/flutter/too…
287c6b8
…ls/gn`, don't strip by default on android (flutter/flutter#161546)

gmackall mentioned this pull request Mar 3, 2025
et: debug binaries are stripped on linux #153585
Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025
df114fbRemove default for stripped option in `engine/src/flutter/too…
5d6d11e
…ls/gn`, don't strip by default on android (flutter/flutter#161546)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025
df114fbRemove default for stripped option in `engine/src/flutter/too…
788d5bc
…ls/gn`, don't strip by default on android (flutter/flutter#161546)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 21, 2025
df114fbRemove default for stripped option in `engine/src/flutter/too…
fd0a2af
…ls/gn`, don't strip by default on android (flutter/flutter#161546)

jason-simmons mentioned this pull request Jun 4, 2025
Flutter prebuild binaries have increased significantly between 3.29.3 and 3.32.0 #169330
Closed

martinetd mentioned this pull request Feb 6, 2026
flutter engine binary size increased threefold in 3.32 #181983
Closed

martinetd mentioned this pull request Feb 6, 2026
[gn] fix --stripped being disabled for all targets #181984
Merged
9 tasks

martinetd mentioned this pull request Feb 6, 2026
release: strip flutter engine .so again flutter-elinux/flutter-embedded-linux#11
Merged

This was referenced Feb 23, 2026
[Play Store] ANR Stacktraces from flutter in playstore dashboard #182653
Closed
docs: document Play Console symbol upload for Android desymbolication #182984
Closed
docs: document Play Console symbol upload for Android desymbolication #182985
Closed

Navigation Menu

Uh oh!

Remove default for stripped option in `engine/src/flutter/tools/gn`, don't strip by default on android - #161546

Remove default for stripped option in `engine/src/flutter/tools/gn`, don't strip by default on android#161546
auto-submit[bot] merged 27 commits into
flutter:masterfrom
gmackall:remake_dont_strip_android_symbols

gmackall commented Jan 13, 2025•
edited
Loading

Uh oh!

Uh oh!

Uh oh!

reidbakerJan 30, 2025

Uh oh!

gmackallJan 30, 2025

Uh oh!

Uh oh!

Uh oh!

bkonyi left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Uh oh!

Conversation

gmackall commented Jan 13, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-launch Checklist

Uh oh!

Uh oh!

Uh oh!

reidbakerJan 30, 2025

Choose a reason for hiding this comment

Uh oh!

gmackallJan 30, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

bkonyi left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

gmackall commented Jan 13, 2025•
edited
Loading