[iOS] switch iOS to slimpeller variant. by jonahwilliams · Pull Request #163808 · flutter/flutter

jonahwilliams · 2025-02-21T01:33:08Z

Now that skia can no longer be used on both iOS devices and Simulators, we can switch the iOS engine to the "slimpeller" variant which removes some (not all!) of the Skia dependencies. This should reduce binary size and build time.

I also did some cleanups as some tests we're still opting into Skia behaviors (though not actually running skia) and we now flag these as errors.

jmagman

🎉

The iOS scenario tests used run twice, once with Impeller and then again with "Skia" (I guess both Impeller now), looks like you got some of it in flutter-team-archive/engine#56706 but there's still a few things to clean up:

flutter/engine/src/flutter/testing/ios_scenario_app/bin/run_ios_tests.dart

Line 135 in 7d23780

if (withImpeller) {

https://github.com/flutter/flutter/blob/master/engine/src/flutter/testing/ios_scenario_app/ios/Scenarios/Scenarios/Info_Skia.plist

You could also file an issue and I can look.

jmagman · 2025-02-22T00:37:16Z

This should reduce binary size and build time.

Is this the benchmark test to watch for binary size?

https://flutter-flutter-perf.luci.app/e/?queries=sub_result%3Dflutter_framework_uncompressed_bytes&selected=commit%3D2801225%26name%3D%252Carch%253Darm%252Cbranch%253Dmaster%252Cconfig%253Ddefault%252Cdevice_type%253DiPhone_11%252Cdevice_version%253Dnone%252Chost_type%253Dmac%252Csub_result%253Dflutter_framework_uncompressed_bytes%252Ctest%253Dhello_world_ios__compile%252C

jonahwilliams · 2025-02-22T00:43:58Z

That looks about right. We also have release_size_bytes: https://flutter-flutter-perf.luci.app/e/?queries=device_type%3DiPhone_11%26sub_result%3Drelease_size_bytes&selected=commit%3D2801195%26name%3D%252Carch%253Darm%252Cbranch%253Dmaster%252Cconfig%253Ddefault%252Cdevice_type%253DiPhone_11%252Cdevice_version%253Dnone%252Chost_type%253Dmac%252Csub_result%253Drelease_size_bytes%252Ctest%253Dimitation_game_flutter__compile%252C which might be the whole thing?

jonahwilliams · 2025-02-22T01:54:16Z

From looking at the CI config I don't think we're running it twice anymore, just three times instead:

ios_debug_unopt_sim
ios_debug_unopt_sim_arm64
ios_debug_unopt_sim_arm64_extension_safe

If that isn't expected let me know and I'll file a bug. I don't see two invocations per target though, just one.

chinmaygarde

🎉

`GoldenTestManager` had an option to choose between an `impeller_` and a bare golden name prefix based on the `FLTEnableImpeller` key in the app's Info.plist, and the app had an `Info_Skia.plist` that set this to false. Both of those have been dead code since 2025-02-25 when we stopped reading `FLTEnableImpeller` in flutter#163808, which switched iOS to the slimpeller variant, and no build configuration ever pointed `INFOPLIST_FILE` at `Info_Skia.plist`. It it was only listed in the project navigator for manual use. The only remaining reader of that flag in the tree is the macOS embedder. This removes the branch, both `Info_Skia.plist` files, and the now-dead `FLTEnableImpeller` key from the Scenarios app. We keep the `impeller_` tag on the goldens even though it's redundant, since that involves touching a bunch of PNGs. If we ever need to do that, we can do it separately. No test changes, or all test changes depending how you look at it, but either way this is dead code removal. Issue: flutter#190041 Issue: flutter#112232

`GoldenTestManager` had an option to choose between an `impeller_` and a bare golden name prefix based on the `FLTEnableImpeller` key in the app's Info.plist, and the app had an `Info_Skia.plist` that set this to false. Both of those have been dead code since 2025-02-25 when we stopped reading `FLTEnableImpeller` in flutter#163808, which switched iOS to the slimpeller variant, and no build configuration ever pointed `INFOPLIST_FILE` at `Info_Skia.plist`. It it was only listed in the project navigator for manual use. The only remaining reader of that flag in the tree is the macOS embedder. This removes the branch, both `Info_Skia.plist` files, and the now-dead `FLTEnableImpeller` key from the Scenarios app. We keep the `impeller_` tag on the goldens even though it's redundant, since that involves touching a bunch of PNGs. If we ever need to do that, we can do it separately. No test changes, or all test changes depending how you look at it, but either way this is dead code removal. Issue: flutter#190041 Issue: flutter#112232  ## Pre-launch Checklist - [X] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [X] I read the [AI contribution guidelines] and understand my responsibilities, or I am not using AI tools. - [X] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [X] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [X] I signed the [CLA]. - [X] I listed at least one issue that this PR fixes in the description above. - [X] I updated/added relevant documentation (doc comments with `///`). - [X] I added new tests to check the change I am making, or this PR is [test-exempt]. - [X] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [X] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. If this change needs to override an active code freeze, provide a comment explaining why. The code freeze workflow can be overridden by code reviewers. See pinned issues for any active code freezes with guidance. **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.  [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [AI contribution guidelines]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#ai-contribution-guidelines [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md

[iOS] switch iOS to slimpeller variant.
e41727e

github-actionsBot added platform-ios iOS applications specifically engine flutter/engine related. See also e: labels. team-ios Owned by iOS platform team labels Feb 21, 2025

jonahwilliams added 5 commits February 20, 2025 21:55

++
4bb01cb

more updates.
76f5a24

more updates.
16284cf

lint.
e651d75

more lint tweaks.
c0f4124

jonahwilliams marked this pull request as ready for review February 21, 2025 22:49

++
47bd089

jonahwilliams requested review from chinmaygarde and jmagman February 21, 2025 23:52

jmagman reviewed Feb 22, 2025
View reviewed changes

remove with impeller flag from ios scenario app script.
1974755

jonahwilliams requested a review from jmagman February 24, 2025 16:51

chinmaygarde approved these changes Feb 24, 2025
View reviewed changes

jonahwilliams added the autosubmit Merge PR when tree becomes green via auto submit App label Feb 24, 2025

auto-submitBot added this pull request to the merge queue Feb 24, 2025

Merged via the queue into flutter:master with commit a488d10Feb 24, 2025

flutter-dashboardBot removed the autosubmit Merge PR when tree becomes green via auto submit App label Feb 24, 2025

engine-flutter-autoroll mentioned this pull request Feb 25, 2025
Roll Flutter from 911aa7547ed7 to 641765e283cf (42 revisions) flutter/packages#8699
Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 25, 2025
a488d10[iOS] switch iOS to slimpeller variant. (flutter/flutter#163808)
08089c6

engine-flutter-autoroll mentioned this pull request Feb 25, 2025
Roll Flutter from 911aa7547ed7 to 5a8f23c3dcf0 (43 revisions) flutter/packages#8701
Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 25, 2025
a488d10[iOS] switch iOS to slimpeller variant. (flutter/flutter#163808)
b44eaba

engine-flutter-autoroll mentioned this pull request Feb 25, 2025
Roll Flutter from 911aa7547ed7 to 73b518d0c36e (44 revisions) flutter/packages#8702
Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 25, 2025
a488d10[iOS] switch iOS to slimpeller variant. (flutter/flutter#163808)
4437588

engine-flutter-autoroll mentioned this pull request Feb 25, 2025
Roll Flutter from 911aa7547ed7 to be1938aa1cbe (45 revisions) flutter/packages#8703
Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 25, 2025
a488d10[iOS] switch iOS to slimpeller variant. (flutter/flutter#163808)
e3ddcbc

engine-flutter-autoroll mentioned this pull request Feb 25, 2025
Roll Flutter from 911aa7547ed7 to 289993ab8347 (46 revisions) flutter/packages#8704
Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 25, 2025
a488d10[iOS] switch iOS to slimpeller variant. (flutter/flutter#163808)
8eb1f42

engine-flutter-autoroll mentioned this pull request Feb 25, 2025
Roll Flutter from 911aa7547ed7 to 940fb3c8b1ad (47 revisions) flutter/packages#8705
Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 25, 2025
a488d10[iOS] switch iOS to slimpeller variant. (flutter/flutter#163808)
47a834b

engine-flutter-autoroll mentioned this pull request Feb 25, 2025
Roll Flutter from 911aa7547ed7 to 70b7664ba297 (48 revisions) flutter/packages#8706
Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 25, 2025
a488d10[iOS] switch iOS to slimpeller variant. (flutter/flutter#163808)
1162c2a

engine-flutter-autoroll mentioned this pull request Feb 26, 2025
Roll Flutter from 911aa7547ed7 to 80233283c31e (71 revisions) flutter/packages#8714
Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 26, 2025
a488d10[iOS] switch iOS to slimpeller variant. (flutter/flutter#163808)
1c1fa37

engine-flutter-autoroll mentioned this pull request Feb 26, 2025
Roll Flutter from 911aa7547ed7 to 3d018b5924fe (72 revisions) flutter/packages#8717
Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 26, 2025
a488d10[iOS] switch iOS to slimpeller variant. (flutter/flutter#163808)
9da0afc

engine-flutter-autoroll mentioned this pull request Feb 26, 2025
Roll Flutter from 911aa7547ed7 to e039a911c5e5 (73 revisions) flutter/packages#8719
Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 26, 2025
a488d10[iOS] switch iOS to slimpeller variant. (flutter/flutter#163808)
c609be0

engine-flutter-autoroll mentioned this pull request Feb 26, 2025
Roll Flutter from 911aa7547ed7 to 8b3f5f4a2f7d (74 revisions) flutter/packages#8720
Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 26, 2025
a488d10[iOS] switch iOS to slimpeller variant. (flutter/flutter#163808)
2f4e7d4

engine-flutter-autoroll mentioned this pull request Feb 26, 2025
Roll Flutter from 911aa7547ed7 to af15a1eb7684 (75 revisions) flutter/packages#8721
Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 26, 2025
a488d10[iOS] switch iOS to slimpeller variant. (flutter/flutter#163808)
af4a428

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 26, 2025
a488d10[iOS] switch iOS to slimpeller variant. (flutter/flutter#163808)
db2b740

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 27, 2025
a488d10[iOS] switch iOS to slimpeller variant. (flutter/flutter#163808)
666a6ca

engine-flutter-autoroll mentioned this pull request Feb 27, 2025
Manual roll Flutter from 16592066d70b to ac9f68b12da8 (46 revisions) flutter/packages#8729
Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 27, 2025
a488d10[iOS] switch iOS to slimpeller variant. (flutter/flutter#163808)
01e3356

Piinks mentioned this pull request Mar 7, 2025
Flutter Notable Commits - 2025 #161460
Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025
a488d10[iOS] switch iOS to slimpeller variant. (flutter/flutter#163808)
9827ffd

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025
a488d10[iOS] switch iOS to slimpeller variant. (flutter/flutter#163808)
53868b9

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 21, 2025
a488d10[iOS] switch iOS to slimpeller variant. (flutter/flutter#163808)
0947557

cbracken mentioned this pull request Aug 10, 2026
iOS: Remove the Scenarios app Skia golden test option #190827
Merged
10 tasks

Navigation Menu

Uh oh!

[iOS] switch iOS to slimpeller variant. - #163808

[iOS] switch iOS to slimpeller variant.#163808
auto-submit[bot] merged 8 commits into
flutter:masterfrom
jonahwilliams:remove_flags

jonahwilliams commented Feb 21, 2025•
edited
Loading

Uh oh!

jmagman left a comment

Uh oh!

jmagman commented Feb 22, 2025

Uh oh!

jonahwilliams commented Feb 22, 2025

Uh oh!

jonahwilliams commented Feb 22, 2025

Uh oh!

chinmaygarde left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

jonahwilliams commented Feb 21, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jmagman left a comment

Choose a reason for hiding this comment

Uh oh!

jmagman commented Feb 22, 2025

Uh oh!

jonahwilliams commented Feb 22, 2025

Uh oh!

jonahwilliams commented Feb 22, 2025

Uh oh!

chinmaygarde left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

jonahwilliams commented Feb 21, 2025•
edited
Loading