Disable a couple of entries in `android_java17_dependency_smoke_tests` by gmackall · Pull Request #167604 · flutter/flutter

gmackall · 2025-04-22T22:46:36Z

This target is frequently timing out. We should prioritize tackling #167495, but in the meantime the flake rate is too high. To avoid disabling the target entirely, disable a couple of entries that are testing the same AGP version (but with different Gradle and Kotlin versions).

Partially fixes#167263.

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
I followed the breaking change policy and added Data Driven Fixes where supported.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Piinks

LGTM

gmackall · 2025-04-22T22:56:42Z

- VersionTuple(agpVersion: '8.7.0', gradleVersion: '8.9', kotlinVersion: '2.1.0'),
 VersionTuple(agpVersion: '8.7.0', gradleVersion: '8.12', kotlinVersion: '2.1.0'),
 ];
+// TODO(jesswrd): Re enable the following VersionTuples after splitting the test target into multiple.


@jesswrd just fyi I assigned the todo to you because you are going to work on the issue, hopefully that is fine

…ke_tests` (flutter/flutter#167604)

disable a couple duplicates
eba82f4

gmackall marked this pull request as ready for review April 22, 2025 22:47

gmackall requested a review from matanlurey as a code owner April 22, 2025 22:47

gmackall requested review from a team and Piinks April 22, 2025 22:47

matanlurey approved these changes Apr 22, 2025
View reviewed changes

Piinks approved these changes Apr 22, 2025
View reviewed changes

gmackall commented Apr 22, 2025
View reviewed changes

gmackall added autosubmit Merge PR when tree becomes green via auto submit App and removed autosubmit Merge PR when tree becomes green via auto submit App labels Apr 22, 2025

auto-submitBot added this pull request to the merge queue Apr 22, 2025

Merged via the queue into flutter:master with commit 9edfbbfApr 23, 2025

flutter-dashboardBot removed the autosubmit Merge PR when tree becomes green via auto submit App label Apr 23, 2025

engine-flutter-autoroll mentioned this pull request Apr 23, 2025
Roll Flutter from cfb887cd5f41 to 2ffcab0a184a (34 revisions) flutter/packages#9136
Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 23, 2025
9edfbbfDisable a couple of entries in `android_java17_dependency_smo…
d614d6d
…ke_tests` (flutter/flutter#167604)

engine-flutter-autoroll mentioned this pull request Apr 23, 2025
Roll Flutter from cfb887cd5f41 to b73450f8f266 (35 revisions) flutter/packages#9137
Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 23, 2025
9edfbbfDisable a couple of entries in `android_java17_dependency_smo…
08035a4
…ke_tests` (flutter/flutter#167604)

engine-flutter-autoroll mentioned this pull request Apr 23, 2025
Roll Flutter from cfb887cd5f41 to b73450f8f266 (35 revisions) flutter/packages#9138
Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 23, 2025
9edfbbfDisable a couple of entries in `android_java17_dependency_smo…
f456538
…ke_tests` (flutter/flutter#167604)

engine-flutter-autoroll mentioned this pull request Apr 23, 2025
Roll Flutter from cfb887cd5f41 to 4b4b1dd483d7 (37 revisions) flutter/packages#9139
Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 23, 2025
9edfbbfDisable a couple of entries in `android_java17_dependency_smo…
201be98
…ke_tests` (flutter/flutter#167604)

engine-flutter-autoroll mentioned this pull request Apr 23, 2025
Roll Flutter from cfb887cd5f41 to 7b3e77cd4418 (39 revisions) flutter/packages#9140
Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 23, 2025
9edfbbfDisable a couple of entries in `android_java17_dependency_smo…
9a90da4
…ke_tests` (flutter/flutter#167604)

engine-flutter-autoroll mentioned this pull request Apr 24, 2025
Roll Flutter from cfb887cd5f41 to 0f8beea2c2c0 (57 revisions) flutter/packages#9143
Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 24, 2025
9edfbbfDisable a couple of entries in `android_java17_dependency_smo…
cfc211d
…ke_tests` (flutter/flutter#167604)

engine-flutter-autoroll mentioned this pull request Apr 24, 2025
Roll Flutter from cfb887cd5f41 to 138b10a68be7 (60 revisions) flutter/packages#9144
Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 24, 2025
9edfbbfDisable a couple of entries in `android_java17_dependency_smo…
8d22b37
…ke_tests` (flutter/flutter#167604)

engine-flutter-autoroll mentioned this pull request Apr 24, 2025
Roll Flutter from cfb887cd5f41 to 992b6cb5b119 (62 revisions) flutter/packages#9145
Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 28, 2025
9edfbbfDisable a couple of entries in `android_java17_dependency_smo…
cc5776a
…ke_tests` (flutter/flutter#167604)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 28, 2025
9edfbbfDisable a couple of entries in `android_java17_dependency_smo…
c6d1fb2
…ke_tests` (flutter/flutter#167604)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 29, 2025
9edfbbfDisable a couple of entries in `android_java17_dependency_smo…
affbcad
…ke_tests` (flutter/flutter#167604)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 29, 2025
9edfbbfDisable a couple of entries in `android_java17_dependency_smo…
327ae45
…ke_tests` (flutter/flutter#167604)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 29, 2025
9edfbbfDisable a couple of entries in `android_java17_dependency_smo…
39e6517
…ke_tests` (flutter/flutter#167604)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 30, 2025
9edfbbfDisable a couple of entries in `android_java17_dependency_smo…
6546648
…ke_tests` (flutter/flutter#167604)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 30, 2025
9edfbbfDisable a couple of entries in `android_java17_dependency_smo…
54fea3a
…ke_tests` (flutter/flutter#167604)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 1, 2025
9edfbbfDisable a couple of entries in `android_java17_dependency_smo…
77eab09
…ke_tests` (flutter/flutter#167604)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 1, 2025
9edfbbfDisable a couple of entries in `android_java17_dependency_smo…
f9e97c3
…ke_tests` (flutter/flutter#167604)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 1, 2025
9edfbbfDisable a couple of entries in `android_java17_dependency_smo…
7333fe1
…ke_tests` (flutter/flutter#167604)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 1, 2025
9edfbbfDisable a couple of entries in `android_java17_dependency_smo…
deb804c
…ke_tests` (flutter/flutter#167604)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 1, 2025
9edfbbfDisable a couple of entries in `android_java17_dependency_smo…
42a3e47
…ke_tests` (flutter/flutter#167604)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 1, 2025
9edfbbfDisable a couple of entries in `android_java17_dependency_smo…
a7ffde0
…ke_tests` (flutter/flutter#167604)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 1, 2025
9edfbbfDisable a couple of entries in `android_java17_dependency_smo…
69cf56e
…ke_tests` (flutter/flutter#167604)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 2, 2025
9edfbbfDisable a couple of entries in `android_java17_dependency_smo…
c3665cf
…ke_tests` (flutter/flutter#167604)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 2, 2025
9edfbbfDisable a couple of entries in `android_java17_dependency_smo…
ec52d78
…ke_tests` (flutter/flutter#167604)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 2, 2025
9edfbbfDisable a couple of entries in `android_java17_dependency_smo…
2690459
…ke_tests` (flutter/flutter#167604)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 2, 2025
9edfbbfDisable a couple of entries in `android_java17_dependency_smo…
560f38f
…ke_tests` (flutter/flutter#167604)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 2, 2025
9edfbbfDisable a couple of entries in `android_java17_dependency_smo…
939c275
…ke_tests` (flutter/flutter#167604)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 3, 2025
9edfbbfDisable a couple of entries in `android_java17_dependency_smo…
c29671e
…ke_tests` (flutter/flutter#167604)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 3, 2025
9edfbbfDisable a couple of entries in `android_java17_dependency_smo…
ceb26b0
…ke_tests` (flutter/flutter#167604)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 4, 2025
9edfbbfDisable a couple of entries in `android_java17_dependency_smo…
3eab39b
…ke_tests` (flutter/flutter#167604)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 5, 2025
9edfbbfDisable a couple of entries in `android_java17_dependency_smo…
4511023
…ke_tests` (flutter/flutter#167604)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 5, 2025
9edfbbfDisable a couple of entries in `android_java17_dependency_smo…
258b4a2
…ke_tests` (flutter/flutter#167604)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 5, 2025
9edfbbfDisable a couple of entries in `android_java17_dependency_smo…
cf27d62
…ke_tests` (flutter/flutter#167604)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 5, 2025
9edfbbfDisable a couple of entries in `android_java17_dependency_smo…
4ce166d
…ke_tests` (flutter/flutter#167604)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 5, 2025
9edfbbfDisable a couple of entries in `android_java17_dependency_smo…
ce1296f
…ke_tests` (flutter/flutter#167604)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 5, 2025
9edfbbfDisable a couple of entries in `android_java17_dependency_smo…
47dcc1f
…ke_tests` (flutter/flutter#167604)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 5, 2025
9edfbbfDisable a couple of entries in `android_java17_dependency_smo…
e0e5a9b
…ke_tests` (flutter/flutter#167604)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 5, 2025
9edfbbfDisable a couple of entries in `android_java17_dependency_smo…
59b97ca
…ke_tests` (flutter/flutter#167604)

Navigation Menu

Uh oh!

Disable a couple of entries in `android_java17_dependency_smoke_tests` - #167604

Disable a couple of entries in `android_java17_dependency_smoke_tests`#167604
auto-submit[bot] merged 1 commit into
flutter:masterfrom
gmackall:disable_some_agp_tests

gmackall commented Apr 22, 2025•
edited
Loading

Uh oh!

Piinks left a comment

Uh oh!

gmackallApr 22, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

gmackall commented Apr 22, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-launch Checklist

Uh oh!

Piinks left a comment

Choose a reason for hiding this comment

Uh oh!

gmackallApr 22, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

gmackall commented Apr 22, 2025•
edited
Loading