Skip to content

[Impeller] disable vivante from using impeller gles/vulkan. - #169760

Merged
matanlurey merged 2 commits into
flutter:masterfrom
jonahwilliams:disable_vivante_vulkan
May 30, 2025
Merged

[Impeller] disable vivante from using impeller gles/vulkan.#169760
matanlurey merged 2 commits into
flutter:masterfrom
jonahwilliams:disable_vivante_vulkan

Conversation

@jonahwilliams

Copy link
Copy Markdown
Contributor

Fixes#167850

@flutter-dashboard

Copy link
Copy Markdown

It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging.

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.If you believe this PR qualifies for a test exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group.

@github-actionsgithub-actionsBot added platform-android Android applications specifically engine flutter/engine related. See also e: labels. e: impeller Impeller rendering backend issues and features requests labels May 30, 2025
@flutter-dashboard

Copy link
Copy Markdown

Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change).

If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review.

For more guidance, visit Writing a golden file test for package:flutter.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Changes reported for pull request #169760 at sha caf10a3

@flutter-dashboardflutter-dashboardBot added the will affect goldens Changes to golden files label May 30, 2025
@jonahwilliamsjonahwilliams added the autosubmit Merge PR when tree becomes green via auto submit App label May 30, 2025
@auto-submit
auto-submitBot added this pull request to the merge queueMay 30, 2025
@matanlurey

Copy link
Copy Markdown
Contributor

Secondary rate limiting ruined this item in the merge queue.

@matanlurey
matanlurey removed this pull request from the merge queue due to a manual request May 30, 2025
@flutter-dashboardflutter-dashboardBot removed the autosubmit Merge PR when tree becomes green via auto submit App label May 30, 2025
@matanlurey
matanlurey added this pull request to the merge queueMay 30, 2025
Merged via the queue into flutter:master with commit 6dd8814May 30, 2025
@rekire

Copy link
Copy Markdown
Contributor

What do you think @jonahwilliams is it worth to cherry pick this PR to get it sooner on stable? I really would like to avoid opting out of impeller in general to support that device.

rekire pushed a commit to rekire/flutter-fork that referenced this pull request Jun 6, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

e: impellerImpeller rendering backend issues and features requestsengineflutter/engine related. See also e: labels.platform-androidAndroid applications specificallywill affect goldensChanges to golden files

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The vivante graphic chip seems to be incompatible with impeller

3 participants

@jonahwilliams@matanlurey@rekire