Uh oh!
There was an error while loading. Please reload this page.
Add missing M3 tests for InputDecoration.floatingLabelAlignment - #170903
Merged
auto-submit[bot] merged 2 commits intoJun 26, 2025
Merged
Conversation
blerouxforce-pushed
the
migrate_InputDecoration.floatingLabelAlignment_tests_to_M3
branch
2 times, most recently
from
June 24, 2025 08:06
88e90d7 to
7c8aaabCompareQuncCccccc
approved these changes
Jun 25, 2025
QuncCccccc
left a comment
Contributor
There was a problem hiding this comment.
LGTM with nits:) Thanks for helping improve the test coverage!
| alignment: FloatingLabelAlignment.center, | ||
| ), | ||
| ); | ||
| // (decorator (800) / icon (40)) / 2 |
Contributor
There was a problem hiding this comment.
Suggested change
| // (decorator (800) / icon (40)) / 2 | |
| // (decorator (800) - icon (40)) / 2 |
| borderIsOutline: true, | ||
| ), | ||
| ); | ||
| // (decorator (800) / icon (40)) / 2 |
Contributor
There was a problem hiding this comment.
Suggested change
| // (decorator (800) / icon (40)) / 2 | |
| // (decorator (800) - icon (40)) / 2 |
blerouxforce-pushed
the
migrate_InputDecoration.floatingLabelAlignment_tests_to_M3
branch
from
June 25, 2025 08:18
7c8aaab to
7f9848fCompareContributor
autosubmit label was removed for flutter/flutter/170903, because Pull request flutter/flutter/170903 is not in a mergeable state. |
Contributor
autosubmit label was removed for flutter/flutter/170903, because Pull request flutter/flutter/170903 is not in a mergeable state. |
blerouxforce-pushed
the
migrate_InputDecoration.floatingLabelAlignment_tests_to_M3
branch
from
June 25, 2025 09:30
7f9848f to
da704e8CompareQuncCcccccforce-pushed
the
migrate_InputDecoration.floatingLabelAlignment_tests_to_M3
branch
from
June 25, 2025 17:30
da704e8 to
3f578d9Compareblerouxforce-pushed
the
migrate_InputDecoration.floatingLabelAlignment_tests_to_M3
branch
from
June 26, 2025 06:13
1e946d8 to
9863d2eCompareQuncCcccccforce-pushed
the
migrate_InputDecoration.floatingLabelAlignment_tests_to_M3
branch
from
June 26, 2025 18:13
9863d2e to
dc2245cCompareQuncCccccc
commented
Jun 26, 2025
Contributor
The google testing failures show infra error and look unrelated to this PR changes. Rebased master and rerunning the tests. |
bleroux
deleted the
migrate_InputDecoration.floatingLabelAlignment_tests_to_M3
branch
June 26, 2025 19:51
engine-flutter-autoroll added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 27, 2025
engine-flutter-autoroll added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jul 1, 2025
engine-flutter-autoroll added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jul 1, 2025
engine-flutter-autoroll added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jul 1, 2025
engine-flutter-autoroll added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jul 1, 2025
engine-flutter-autoroll added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jul 1, 2025
engine-flutter-autoroll added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jul 1, 2025
engine-flutter-autoroll added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jul 1, 2025
engine-flutter-autoroll added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jul 2, 2025
engine-flutter-autoroll added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jul 2, 2025
engine-flutter-autoroll added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jul 2, 2025
engine-flutter-autoroll added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jul 2, 2025
engine-flutter-autoroll added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jul 2, 2025
engine-flutter-autoroll added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jul 3, 2025
engine-flutter-autoroll added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jul 3, 2025
engine-flutter-autoroll added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jul 3, 2025
engine-flutter-autoroll added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jul 3, 2025
engine-flutter-autoroll added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jul 3, 2025
engine-flutter-autoroll added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jul 4, 2025
engine-flutter-autoroll added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jul 4, 2025
engine-flutter-autoroll added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jul 4, 2025
engine-flutter-autoroll added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jul 5, 2025
engine-flutter-autoroll added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jul 5, 2025
engine-flutter-autoroll added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jul 6, 2025
engine-flutter-autoroll added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jul 6, 2025
engine-flutter-autoroll added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jul 6, 2025
engine-flutter-autoroll added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jul 7, 2025
engine-flutter-autoroll added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jul 7, 2025
engine-flutter-autoroll added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jul 7, 2025
mboetger pushed a commit
to mboetger/flutter
that referenced
this pull request
Jul 21, 2025
…ter#170903) ## Description This PR adds missing M3 tests for InputDecoration.floatingLabelAlignment. ## Related Issue Will help to complete flutter#168981 ## Tests Adds 8 tests (based on existing M2 tests).
engine-flutter-autoroll added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds missing M3 tests for InputDecoration.floatingLabelAlignment.
Related Issue
Will help to complete #168981
Tests
Adds 8 tests (based on existing M2 tests).