Skip to content

Roll Abseil and remove a workaround for a Fuchsia target that was unable to build Abseil - #172665

Merged
auto-submit[bot] merged 3 commits into
flutter:masterfrom
jason-simmons:roll_abseil_072325
Jul 24, 2025
Merged

Roll Abseil and remove a workaround for a Fuchsia target that was unable to build Abseil#172665
auto-submit[bot] merged 3 commits into
flutter:masterfrom
jason-simmons:roll_abseil_072325

Conversation

@jason-simmons

Copy link
Copy Markdown
Member

Flutter was avoiding dependencies on Abseil's flat_hash_map library on Fuchsia because it brought in a time zone library that required the Fuchsia SDK. This PR rolls Abseil to a commit that fixes the path to the Fuchsia SDK.

…ble to build Abseil
Flutter was avoiding dependencies on Abseil's flat_hash_map library on Fuchsia because it brought in a time zone library that required the Fuchsia SDK. This PR rolls Abseil to a commit that fixes the path to the Fuchsia SDK.
@github-actionsgithub-actionsBot added engine flutter/engine related. See also e: labels. e: impeller Impeller rendering backend issues and features requests labels Jul 23, 2025
#define IMPELLER_TYPOGRAPHER_USE_STD_HASH
#else
#include "flutter/third_party/abseil-cpp/absl/container/flat_hash_map.h"
#endif

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's more stuff below that should be deleted (see where there is an #if IMPELLER_TYPOGRAPHER_USE_STD_HASH)

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you can also delete AbslHashAdapter and AbslHashAdapterCombiner since they are no longer used anymore.

#define IMPELLER_TYPOGRAPHER_USE_STD_HASH
#else
#include "flutter/third_party/abseil-cpp/absl/container/flat_hash_map.h"
#endif

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you can also delete AbslHashAdapter and AbslHashAdapterCombiner since they are no longer used anymore.

@jason-simmons

Copy link
Copy Markdown
MemberAuthor

Done - looked at 6d390bf and I think everything introduced there for the hash workaround has been removed

@eyebrowsoffireeyebrowsoffire left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you for the fix!

@jason-simmonsjason-simmons added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 23, 2025
@auto-submit
auto-submitBot added this pull request to the merge queueJul 24, 2025
Merged via the queue into flutter:master with commit dd302cbJul 24, 2025
178 of 179 checks passed
@flutter-dashboardflutter-dashboardBot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jul 24, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 24, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 24, 2025
auto-submitBot pushed a commit to flutter/packages that referenced this pull request Jul 24, 2025
flutter/flutter@afba7d7...20788c0
2025-07-24 engine-flutter-autoroll@skia.org Roll Packages from 9c85e5e to 963550c (4 revisions) (flutter/flutter#172696)
2025-07-24 sokolovskyi.konstantin@gmail.com Add missing deprecations to CupertinoDynamicColor. (flutter/flutter#171160)
2025-07-24 engine-flutter-autoroll@skia.org Roll Dart SDK from a181fe571dc8 to 26dece893751 (2 revisions) (flutter/flutter#172683)
2025-07-24 jssaadeh@outlook.com Migrate to null aware elements - Part 1 (flutter/flutter#172198)
2025-07-24 30870216+gaaclarke@users.noreply.github.com licenses_cpp: implements extracting regions from matched text (flutter/flutter#172655)
2025-07-24 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#172677)
2025-07-24 fluttergithubbot@gmail.com Marks Mac_ios keyboard_hot_restart_ios to be unflaky (flutter/flutter#168053)
2025-07-24 jason-simmons@users.noreply.github.com Roll Abseil and remove a workaround for a Fuchsia target that was unable to build Abseil (flutter/flutter#172665)
2025-07-24 arindamk410@gmail.com Add `automaticallyImplyActions` property to AppBar (flutter/flutter#171113)
2025-07-24 koji.wakamiya@gmail.com fix: TabBar fontFamily inheritance with custom label styles (flutter/flutter#171699)
2025-07-23 fluttergithubbot@gmail.com Marks Linux_mokey new_gallery__crane_perf to be unflaky (flutter/flutter#167633)
2025-07-23 34871572+gmackall@users.noreply.github.com [android] Fix broken `--android-skip-build-dependency-validation` flag (flutter/flutter#172581)
2025-07-23 pedromassango.developer@gmail.com Fix: Ensure Text widget locale is included in semantics language tag (flutter/flutter#172034)
2025-07-23 jhy03261997@gmail.com [Web][a11y] Update selected chips semantics (flutter/flutter#172660)
2025-07-23 engine-flutter-autoroll@skia.org Roll Skia from eea1c33fbe84 to 094ac350125f (29 revisions) (flutter/flutter#172664)
2025-07-23 fluttergithubbot@gmail.com Marks Mac_arm64_ios imitation_game_flutter to be unflaky (flutter/flutter#168052)
2025-07-23 engine-flutter-autoroll@skia.org Roll Dart SDK from a31774a3d049 to a181fe571dc8 (2 revisions) (flutter/flutter#172667)
2025-07-23 okorohelijah@google.com Adapt xcresult parser for Xcode 16 changes (flutter/flutter#172596)
2025-07-23 jason-simmons@users.noreply.github.com Update excluded_files to match the current output of the old license checker (flutter/flutter#172670)
2025-07-23 a-siva@users.noreply.github.com Manual Roll of Dart SDK from da9e0299c120 to a31774a3d049 (flutter/flutter#172616)
2025-07-23 34871572+gmackall@users.noreply.github.com [FGP] Small restructuring of Android Studio native flutter dependency support (flutter/flutter#172651)
2025-07-23 30870216+gaaclarke@users.noreply.github.com revert: Replaces legacy licenses check with licenses_cpp (flutter/flutter#172568)
2025-07-23 codefu@google.com fix: size-exp naming (flutter/flutter#172647)
2025-07-23 engine-flutter-autoroll@skia.org Roll Fuchsia Test Scripts from MnFlN7VWM_7h7EmBV... to BWj3yYC74ud58QhN0... (flutter/flutter#172646)
2025-07-23 flar@google.com [DisplayList] implement shadow bounds without relying on Skia utilities (flutter/flutter#172572)
2025-07-23 matanlurey@users.noreply.github.com Update `dev/bots/post_process_docs.dart` to use `flutter.version.json` (flutter/flutter#172601)
2025-07-23 matanlurey@users.noreply.github.com Emit a warning on `--[no-]disable-dds`, preferring `--no-dds` (flutter/flutter#172595)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC stuartmorgan@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
azatech pushed a commit to azatech/flutter that referenced this pull request Jul 28, 2025
…ble to build Abseil (flutter#172665)
Flutter was avoiding dependencies on Abseil's flat_hash_map library on
Fuchsia because it brought in a time zone library that required the
Fuchsia SDK. This PR rolls Abseil to a commit that fixes the path to the
Fuchsia SDK.
vashworth pushed a commit to vashworth/packages that referenced this pull request Jul 30, 2025
flutter/flutter@afba7d7...20788c0
2025-07-24 engine-flutter-autoroll@skia.org Roll Packages from 9c85e5e to 963550c (4 revisions) (flutter/flutter#172696)
2025-07-24 sokolovskyi.konstantin@gmail.com Add missing deprecations to CupertinoDynamicColor. (flutter/flutter#171160)
2025-07-24 engine-flutter-autoroll@skia.org Roll Dart SDK from a181fe571dc8 to 26dece893751 (2 revisions) (flutter/flutter#172683)
2025-07-24 jssaadeh@outlook.com Migrate to null aware elements - Part 1 (flutter/flutter#172198)
2025-07-24 30870216+gaaclarke@users.noreply.github.com licenses_cpp: implements extracting regions from matched text (flutter/flutter#172655)
2025-07-24 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#172677)
2025-07-24 fluttergithubbot@gmail.com Marks Mac_ios keyboard_hot_restart_ios to be unflaky (flutter/flutter#168053)
2025-07-24 jason-simmons@users.noreply.github.com Roll Abseil and remove a workaround for a Fuchsia target that was unable to build Abseil (flutter/flutter#172665)
2025-07-24 arindamk410@gmail.com Add `automaticallyImplyActions` property to AppBar (flutter/flutter#171113)
2025-07-24 koji.wakamiya@gmail.com fix: TabBar fontFamily inheritance with custom label styles (flutter/flutter#171699)
2025-07-23 fluttergithubbot@gmail.com Marks Linux_mokey new_gallery__crane_perf to be unflaky (flutter/flutter#167633)
2025-07-23 34871572+gmackall@users.noreply.github.com [android] Fix broken `--android-skip-build-dependency-validation` flag (flutter/flutter#172581)
2025-07-23 pedromassango.developer@gmail.com Fix: Ensure Text widget locale is included in semantics language tag (flutter/flutter#172034)
2025-07-23 jhy03261997@gmail.com [Web][a11y] Update selected chips semantics (flutter/flutter#172660)
2025-07-23 engine-flutter-autoroll@skia.org Roll Skia from eea1c33fbe84 to 094ac350125f (29 revisions) (flutter/flutter#172664)
2025-07-23 fluttergithubbot@gmail.com Marks Mac_arm64_ios imitation_game_flutter to be unflaky (flutter/flutter#168052)
2025-07-23 engine-flutter-autoroll@skia.org Roll Dart SDK from a31774a3d049 to a181fe571dc8 (2 revisions) (flutter/flutter#172667)
2025-07-23 okorohelijah@google.com Adapt xcresult parser for Xcode 16 changes (flutter/flutter#172596)
2025-07-23 jason-simmons@users.noreply.github.com Update excluded_files to match the current output of the old license checker (flutter/flutter#172670)
2025-07-23 a-siva@users.noreply.github.com Manual Roll of Dart SDK from da9e0299c120 to a31774a3d049 (flutter/flutter#172616)
2025-07-23 34871572+gmackall@users.noreply.github.com [FGP] Small restructuring of Android Studio native flutter dependency support (flutter/flutter#172651)
2025-07-23 30870216+gaaclarke@users.noreply.github.com revert: Replaces legacy licenses check with licenses_cpp (flutter/flutter#172568)
2025-07-23 codefu@google.com fix: size-exp naming (flutter/flutter#172647)
2025-07-23 engine-flutter-autoroll@skia.org Roll Fuchsia Test Scripts from MnFlN7VWM_7h7EmBV... to BWj3yYC74ud58QhN0... (flutter/flutter#172646)
2025-07-23 flar@google.com [DisplayList] implement shadow bounds without relying on Skia utilities (flutter/flutter#172572)
2025-07-23 matanlurey@users.noreply.github.com Update `dev/bots/post_process_docs.dart` to use `flutter.version.json` (flutter/flutter#172601)
2025-07-23 matanlurey@users.noreply.github.com Emit a warning on `--[no-]disable-dds`, preferring `--no-dds` (flutter/flutter#172595)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC stuartmorgan@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
ksokolovskyi pushed a commit to ksokolovskyi/flutter that referenced this pull request Aug 19, 2025
…ble to build Abseil (flutter#172665)
Flutter was avoiding dependencies on Abseil's flat_hash_map library on
Fuchsia because it brought in a time zone library that required the
Fuchsia SDK. This PR rolls Abseil to a commit that fixes the path to the
Fuchsia SDK.
mboetger pushed a commit to mboetger/flutter that referenced this pull request Sep 18, 2025
…ble to build Abseil (flutter#172665)
Flutter was avoiding dependencies on Abseil's flat_hash_map library on
Fuchsia because it brought in a time zone library that required the
Fuchsia SDK. This PR rolls Abseil to a commit that fixes the path to the
Fuchsia SDK.
korca0220 pushed a commit to korca0220/flutter that referenced this pull request Sep 22, 2025
…ble to build Abseil (flutter#172665)
Flutter was avoiding dependencies on Abseil's flat_hash_map library on
Fuchsia because it brought in a time zone library that required the
Fuchsia SDK. This PR rolls Abseil to a commit that fixes the path to the
Fuchsia SDK.
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 12, 2025
lucaantonelli pushed a commit to lucaantonelli/flutter that referenced this pull request Nov 21, 2025
…ble to build Abseil (flutter#172665)
Flutter was avoiding dependencies on Abseil's flat_hash_map library on
Fuchsia because it brought in a time zone library that required the
Fuchsia SDK. This PR rolls Abseil to a commit that fixes the path to the
Fuchsia SDK.
creatorpiyush pushed a commit to creatorpiyush/packages that referenced this pull request Jun 10, 2026
flutter/flutter@afba7d7...20788c0
2025-07-24 engine-flutter-autoroll@skia.org Roll Packages from 9c85e5e to 963550c (4 revisions) (flutter/flutter#172696)
2025-07-24 sokolovskyi.konstantin@gmail.com Add missing deprecations to CupertinoDynamicColor. (flutter/flutter#171160)
2025-07-24 engine-flutter-autoroll@skia.org Roll Dart SDK from a181fe571dc8 to 26dece893751 (2 revisions) (flutter/flutter#172683)
2025-07-24 jssaadeh@outlook.com Migrate to null aware elements - Part 1 (flutter/flutter#172198)
2025-07-24 30870216+gaaclarke@users.noreply.github.com licenses_cpp: implements extracting regions from matched text (flutter/flutter#172655)
2025-07-24 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#172677)
2025-07-24 fluttergithubbot@gmail.com Marks Mac_ios keyboard_hot_restart_ios to be unflaky (flutter/flutter#168053)
2025-07-24 jason-simmons@users.noreply.github.com Roll Abseil and remove a workaround for a Fuchsia target that was unable to build Abseil (flutter/flutter#172665)
2025-07-24 arindamk410@gmail.com Add `automaticallyImplyActions` property to AppBar (flutter/flutter#171113)
2025-07-24 koji.wakamiya@gmail.com fix: TabBar fontFamily inheritance with custom label styles (flutter/flutter#171699)
2025-07-23 fluttergithubbot@gmail.com Marks Linux_mokey new_gallery__crane_perf to be unflaky (flutter/flutter#167633)
2025-07-23 34871572+gmackall@users.noreply.github.com [android] Fix broken `--android-skip-build-dependency-validation` flag (flutter/flutter#172581)
2025-07-23 pedromassango.developer@gmail.com Fix: Ensure Text widget locale is included in semantics language tag (flutter/flutter#172034)
2025-07-23 jhy03261997@gmail.com [Web][a11y] Update selected chips semantics (flutter/flutter#172660)
2025-07-23 engine-flutter-autoroll@skia.org Roll Skia from eea1c33fbe84 to 094ac350125f (29 revisions) (flutter/flutter#172664)
2025-07-23 fluttergithubbot@gmail.com Marks Mac_arm64_ios imitation_game_flutter to be unflaky (flutter/flutter#168052)
2025-07-23 engine-flutter-autoroll@skia.org Roll Dart SDK from a31774a3d049 to a181fe571dc8 (2 revisions) (flutter/flutter#172667)
2025-07-23 okorohelijah@google.com Adapt xcresult parser for Xcode 16 changes (flutter/flutter#172596)
2025-07-23 jason-simmons@users.noreply.github.com Update excluded_files to match the current output of the old license checker (flutter/flutter#172670)
2025-07-23 a-siva@users.noreply.github.com Manual Roll of Dart SDK from da9e0299c120 to a31774a3d049 (flutter/flutter#172616)
2025-07-23 34871572+gmackall@users.noreply.github.com [FGP] Small restructuring of Android Studio native flutter dependency support (flutter/flutter#172651)
2025-07-23 30870216+gaaclarke@users.noreply.github.com revert: Replaces legacy licenses check with licenses_cpp (flutter/flutter#172568)
2025-07-23 codefu@google.com fix: size-exp naming (flutter/flutter#172647)
2025-07-23 engine-flutter-autoroll@skia.org Roll Fuchsia Test Scripts from MnFlN7VWM_7h7EmBV... to BWj3yYC74ud58QhN0... (flutter/flutter#172646)
2025-07-23 flar@google.com [DisplayList] implement shadow bounds without relying on Skia utilities (flutter/flutter#172572)
2025-07-23 matanlurey@users.noreply.github.com Update `dev/bots/post_process_docs.dart` to use `flutter.version.json` (flutter/flutter#172601)
2025-07-23 matanlurey@users.noreply.github.com Emit a warning on `--[no-]disable-dds`, preferring `--no-dds` (flutter/flutter#172595)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC stuartmorgan@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
bisor0627 pushed a commit to bisor0627/packages that referenced this pull request Jun 19, 2026
flutter/flutter@afba7d7...20788c0
2025-07-24 engine-flutter-autoroll@skia.org Roll Packages from 7cb1626 to f9acfba (4 revisions) (flutter/flutter#172696)
2025-07-24 sokolovskyi.konstantin@gmail.com Add missing deprecations to CupertinoDynamicColor. (flutter/flutter#171160)
2025-07-24 engine-flutter-autoroll@skia.org Roll Dart SDK from a181fe571dc8 to 26dece893751 (2 revisions) (flutter/flutter#172683)
2025-07-24 jssaadeh@outlook.com Migrate to null aware elements - Part 1 (flutter/flutter#172198)
2025-07-24 30870216+gaaclarke@users.noreply.github.com licenses_cpp: implements extracting regions from matched text (flutter/flutter#172655)
2025-07-24 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#172677)
2025-07-24 fluttergithubbot@gmail.com Marks Mac_ios keyboard_hot_restart_ios to be unflaky (flutter/flutter#168053)
2025-07-24 jason-simmons@users.noreply.github.com Roll Abseil and remove a workaround for a Fuchsia target that was unable to build Abseil (flutter/flutter#172665)
2025-07-24 arindamk410@gmail.com Add `automaticallyImplyActions` property to AppBar (flutter/flutter#171113)
2025-07-24 koji.wakamiya@gmail.com fix: TabBar fontFamily inheritance with custom label styles (flutter/flutter#171699)
2025-07-23 fluttergithubbot@gmail.com Marks Linux_mokey new_gallery__crane_perf to be unflaky (flutter/flutter#167633)
2025-07-23 34871572+gmackall@users.noreply.github.com [android] Fix broken `--android-skip-build-dependency-validation` flag (flutter/flutter#172581)
2025-07-23 pedromassango.developer@gmail.com Fix: Ensure Text widget locale is included in semantics language tag (flutter/flutter#172034)
2025-07-23 jhy03261997@gmail.com [Web][a11y] Update selected chips semantics (flutter/flutter#172660)
2025-07-23 engine-flutter-autoroll@skia.org Roll Skia from eea1c33fbe84 to 094ac350125f (29 revisions) (flutter/flutter#172664)
2025-07-23 fluttergithubbot@gmail.com Marks Mac_arm64_ios imitation_game_flutter to be unflaky (flutter/flutter#168052)
2025-07-23 engine-flutter-autoroll@skia.org Roll Dart SDK from a31774a3d049 to a181fe571dc8 (2 revisions) (flutter/flutter#172667)
2025-07-23 okorohelijah@google.com Adapt xcresult parser for Xcode 16 changes (flutter/flutter#172596)
2025-07-23 jason-simmons@users.noreply.github.com Update excluded_files to match the current output of the old license checker (flutter/flutter#172670)
2025-07-23 a-siva@users.noreply.github.com Manual Roll of Dart SDK from da9e0299c120 to a31774a3d049 (flutter/flutter#172616)
2025-07-23 34871572+gmackall@users.noreply.github.com [FGP] Small restructuring of Android Studio native flutter dependency support (flutter/flutter#172651)
2025-07-23 30870216+gaaclarke@users.noreply.github.com revert: Replaces legacy licenses check with licenses_cpp (flutter/flutter#172568)
2025-07-23 codefu@google.com fix: size-exp naming (flutter/flutter#172647)
2025-07-23 engine-flutter-autoroll@skia.org Roll Fuchsia Test Scripts from MnFlN7VWM_7h7EmBV... to BWj3yYC74ud58QhN0... (flutter/flutter#172646)
2025-07-23 flar@google.com [DisplayList] implement shadow bounds without relying on Skia utilities (flutter/flutter#172572)
2025-07-23 matanlurey@users.noreply.github.com Update `dev/bots/post_process_docs.dart` to use `flutter.version.json` (flutter/flutter#172601)
2025-07-23 matanlurey@users.noreply.github.com Emit a warning on `--[no-]disable-dds`, preferring `--no-dds` (flutter/flutter#172595)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC stuartmorgan@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

e: impellerImpeller rendering backend issues and features requestsengineflutter/engine related. See also e: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@jason-simmons@eyebrowsoffire