Skip to content

Add open_jdk to Linux analyze - #173988

Merged
auto-submit[bot] merged 1 commit into
masterfrom
matanlurey-patch-2
Aug 18, 2025
Merged

Add open_jdk to Linux analyze#173988
auto-submit[bot] merged 1 commit into
masterfrom
matanlurey-patch-2

Conversation

@matanlurey

Copy link
Copy Markdown
Contributor

Towards #173986.

This build never declared (either directly or through platform_properties) that it required the Java JDK, and appears to have been "accidentally" getting it installed via a (now expired) cache of the Java JDK.

Towards #173986.
This build _never_ declared (either directly or through `platform_properties`) that it required the Java JDK, and appears to have been "accidentally" getting it installed via a (now expired) cache of the Java JDK.

@gemini-code-assistgemini-code-assistBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request addresses a build dependency issue by explicitly adding open_jdk to the Linux analyze CI target. The change is necessary because the build was implicitly relying on a cached JDK that is no longer available. The change in .ci.yaml is correct and follows the existing format for declaring dependencies. The fix is straightforward and I have no further suggestions.

@reidbakerreidbaker left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#173982 not sure what is different from my pr but approved.

@matanlureymatanlurey added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 18, 2025
@auto-submit
auto-submitBot added this pull request to the merge queueAug 18, 2025
Merged via the queue into master with commit 946f15aAug 18, 2025
162 checks passed
@auto-submit
auto-submitBot deleted the matanlurey-patch-2 branch August 18, 2025 23:40
@flutter-dashboardflutter-dashboardBot removed the autosubmit Merge PR when tree becomes green via auto submit App label Aug 18, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 19, 2025
auto-submitBot pushed a commit to flutter/packages that referenced this pull request Aug 19, 2025
flutter/flutter@2265d94...e65380a
2025-08-19 engine-flutter-autoroll@skia.org Roll Dart SDK from 502455ee300b to 9105d946af95 (3 revisions) (flutter/flutter#174002)
2025-08-18 matanlurey@users.noreply.github.com Add `open_jdk` to `Linux analyze` (flutter/flutter#173988)
2025-08-18 magder@google.com Add "team-ios" label to iOS team triage query (flutter/flutter#173997)
2025-08-18 1063596+reidbaker@users.noreply.github.com Migrate deeplink json creation to public AGP api (flutter/flutter#173794)
2025-08-18 bkonyi@google.com [ Widget Preview ] Don't crash when directory watcher restarts on Windows (flutter/flutter#173987)
2025-08-18 bkonyi@google.com [ Widget Preview ] Don't try to instantiate invalid `@Preview()` applications (flutter/flutter#173984)
2025-08-18 737941+loic-sharma@users.noreply.github.com Explain how to run Google Test tests directly (flutter/flutter#173978)
2025-08-18 58529443+srujzs@users.noreply.github.com [flutter_tools] Use DWDS 25.0.1 (flutter/flutter#173777)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC bmparr@google.com,stuartmorgan@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@matanlureymatanlurey added cp: beta cherry pick this pull request to beta release candidate branch cp: stable cherry pick this pull request to stable release candidate branch labels Aug 19, 2025
flutteractionsbot pushed a commit to flutteractionsbot/flutter that referenced this pull request Aug 19, 2025
Towards flutter#173986.
This build _never_ declared (either directly or through
`platform_properties`) that it required the Java JDK, and appears to
have been "accidentally" getting it installed via a (now expired) cache
of the Java JDK.
flutteractionsbot pushed a commit to flutteractionsbot/flutter that referenced this pull request Aug 19, 2025
Towards flutter#173986.
This build _never_ declared (either directly or through
`platform_properties`) that it required the Java JDK, and appears to
have been "accidentally" getting it installed via a (now expired) cache
of the Java JDK.
WillBLogical pushed a commit to WillBLogical/packages that referenced this pull request Aug 20, 2025
flutter/flutter@2265d94...e65380a
2025-08-19 engine-flutter-autoroll@skia.org Roll Dart SDK from 502455ee300b to 9105d946af95 (3 revisions) (flutter/flutter#174002)
2025-08-18 matanlurey@users.noreply.github.com Add `open_jdk` to `Linux analyze` (flutter/flutter#173988)
2025-08-18 magder@google.com Add "team-ios" label to iOS team triage query (flutter/flutter#173997)
2025-08-18 1063596+reidbaker@users.noreply.github.com Migrate deeplink json creation to public AGP api (flutter/flutter#173794)
2025-08-18 bkonyi@google.com [ Widget Preview ] Don't crash when directory watcher restarts on Windows (flutter/flutter#173987)
2025-08-18 bkonyi@google.com [ Widget Preview ] Don't try to instantiate invalid `@Preview()` applications (flutter/flutter#173984)
2025-08-18 737941+loic-sharma@users.noreply.github.com Explain how to run Google Test tests directly (flutter/flutter#173978)
2025-08-18 58529443+srujzs@users.noreply.github.com [flutter_tools] Use DWDS 25.0.1 (flutter/flutter#173777)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC bmparr@google.com,stuartmorgan@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
gmackall pushed a commit to gmackall/flutter that referenced this pull request Aug 21, 2025
Towards flutter#173986.
This build _never_ declared (either directly or through
`platform_properties`) that it required the Java JDK, and appears to
have been "accidentally" getting it installed via a (now expired) cache
of the Java JDK.
SydneyBao pushed a commit to SydneyBao/flutter that referenced this pull request Aug 22, 2025
Towards flutter#173986.
This build _never_ declared (either directly or through
`platform_properties`) that it required the Java JDK, and appears to
have been "accidentally" getting it installed via a (now expired) cache
of the Java JDK.
SydneyBao pushed a commit to SydneyBao/flutter that referenced this pull request Aug 22, 2025
Towards flutter#173986.
This build _never_ declared (either directly or through
`platform_properties`) that it required the Java JDK, and appears to
have been "accidentally" getting it installed via a (now expired) cache
of the Java JDK.
mboetger pushed a commit to mboetger/flutter that referenced this pull request Sep 18, 2025
Towards flutter#173986.
This build _never_ declared (either directly or through
`platform_properties`) that it required the Java JDK, and appears to
have been "accidentally" getting it installed via a (now expired) cache
of the Java JDK.
korca0220 pushed a commit to korca0220/flutter that referenced this pull request Sep 22, 2025
Towards flutter#173986.
This build _never_ declared (either directly or through
`platform_properties`) that it required the Java JDK, and appears to
have been "accidentally" getting it installed via a (now expired) cache
of the Java JDK.
Jaineel-Mamtora pushed a commit to Jaineel-Mamtora/flutter_forked that referenced this pull request Sep 24, 2025
Towards flutter#173986.
This build _never_ declared (either directly or through
`platform_properties`) that it required the Java JDK, and appears to
have been "accidentally" getting it installed via a (now expired) cache
of the Java JDK.
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 12, 2025
lucaantonelli pushed a commit to lucaantonelli/flutter that referenced this pull request Nov 21, 2025
Towards flutter#173986.
This build _never_ declared (either directly or through
`platform_properties`) that it required the Java JDK, and appears to
have been "accidentally" getting it installed via a (now expired) cache
of the Java JDK.
creatorpiyush pushed a commit to creatorpiyush/packages that referenced this pull request Jun 10, 2026
flutter/flutter@2265d94...e65380a
2025-08-19 engine-flutter-autoroll@skia.org Roll Dart SDK from 502455ee300b to 9105d946af95 (3 revisions) (flutter/flutter#174002)
2025-08-18 matanlurey@users.noreply.github.com Add `open_jdk` to `Linux analyze` (flutter/flutter#173988)
2025-08-18 magder@google.com Add "team-ios" label to iOS team triage query (flutter/flutter#173997)
2025-08-18 1063596+reidbaker@users.noreply.github.com Migrate deeplink json creation to public AGP api (flutter/flutter#173794)
2025-08-18 bkonyi@google.com [ Widget Preview ] Don't crash when directory watcher restarts on Windows (flutter/flutter#173987)
2025-08-18 bkonyi@google.com [ Widget Preview ] Don't try to instantiate invalid `@Preview()` applications (flutter/flutter#173984)
2025-08-18 737941+loic-sharma@users.noreply.github.com Explain how to run Google Test tests directly (flutter/flutter#173978)
2025-08-18 58529443+srujzs@users.noreply.github.com [flutter_tools] Use DWDS 25.0.1 (flutter/flutter#173777)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC bmparr@google.com,stuartmorgan@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cp: betacherry pick this pull request to beta release candidate branchcp: stablecherry pick this pull request to stable release candidate branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@matanlurey@reidbaker