Skip to content

[ Tool ] Roll DWDS to fix ExistingDartDevelopmentServiceException - #174306

Merged
auto-submit[bot] merged 2 commits into
flutter-3.35-candidate.0from
fix_issue_171758
Aug 22, 2025
Merged

[ Tool ] Roll DWDS to fix ExistingDartDevelopmentServiceException#174306
auto-submit[bot] merged 2 commits into
flutter-3.35-candidate.0from
fix_issue_171758

Conversation

@bkonyi

@bkonyibkonyi commented Aug 22, 2025

Copy link
Copy Markdown
Contributor

Fixes#171758

@flutter-dashboard

flutter-dashboardBot commented Aug 22, 2025

Copy link
Copy Markdown

This pull request was opened from and to a release candidate branch. This should only be done as part of the official Flutter release process. If you are attempting to make a regular contribution to the Flutter project, please close this PR and follow the instructions at Tree Hygiene for detailed instructions on contributing to Flutter.

Reviewers: Use caution before merging pull requests to release branches. Ensure the proper procedure has been followed.

@bkonyi
bkonyi requested a review from matanlureyAugust 22, 2025 19:51
@github-actionsgithub-actionsBot added the tool Affects the "flutter" command-line tool. See also t: labels. label Aug 22, 2025
gemini-code-assist[bot]
gemini-code-assistBot reviewed Aug 22, 2025
View reviewed changes

@gemini-code-assistgemini-code-assistBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the dwds dependency from version 24.4.0 to 24.4.0+1 in packages/flutter_tools/pubspec.yaml. This is a standard dependency roll intended to fix an ExistingDartDevelopmentServiceException. The change is straightforward and correct. I have no further feedback as there are no issues of medium or higher severity.

@bkonyi

bkonyi commented Aug 22, 2025

Copy link
Copy Markdown
ContributorAuthor

This change should be cherry picked as #171758 is a top-10 tool crasher.

@bkonyibkonyi added cp: beta cherry pick this pull request to beta release candidate branch cp: stable cherry pick this pull request to stable release candidate branch labels Aug 22, 2025
@matanlureymatanlurey mentioned this pull request Aug 22, 2025
Merged
@matanlurey

matanlurey commented Aug 22, 2025

Copy link
Copy Markdown
Contributor

Failing presubmits are a release-branch regression I'm attempting to fix in flutter/cocoon#4844.

auto-submitBot pushed a commit to flutter/cocoon that referenced this pull request Aug 22, 2025
@matanlurey
Do not provide FPEV for release-branch presubmits that do not touch e…
1f2a843
…ngine (#4844)
I believe this will fix cases such as flutter/flutter#174306 where:
(a) The engine is not touched
(b) We expect the `flutter` tool to resolve an engine for us, i.e. using a content-aware hash
@matanlurey

matanlurey commented Aug 22, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

Trying a re-run with the new Cocoon build.

FPEV is now omitted:
https://ci.chromium.org/ui/p/flutter/builders/try/Linux%20analyze/108889/infra

My hope is that flutter now picks up the engine via the content-aware hash and everything else swims along.

@matanlureymatanlurey added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 22, 2025
@auto-submit
auto-submitBot merged commit 1a6b80d into flutter-3.35-candidate.0Aug 22, 2025
146 checks passed
@auto-submit
auto-submitBot deleted the fix_issue_171758 branch August 22, 2025 21:08
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 26, 2025
@engine-flutter-autoroll
1a6b80d[ Tool ] Roll DWDS to fix `ExistingDartDevelopmentServiceExce…
724f9d2
…ption` (flutter/flutter#174306)
@tirth-patel-nctirth-patel-nc mentioned this pull request Aug 27, 2025
Closed
@reidbakerreidbaker mentioned this pull request Oct 1, 2025
Merged
9 tasks
@bkonyibkonyi mentioned this pull request Oct 1, 2025
Closed
@huycozyhuycozy mentioned this pull request Oct 20, 2025
Closed
@tirth-patel-nctirth-patel-nc mentioned this pull request Nov 7, 2025
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers
@gemini-code-assistgemini-code-assist[bot]gemini-code-assist[bot] left review comments
@matanlureymatanlureymatanlurey approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

autosubmitMerge PR when tree becomes green via auto submit Appcp: betacherry pick this pull request to beta release candidate branchcp: stablecherry pick this pull request to stable release candidate branchtoolAffects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@bkonyi@matanlurey