Skip to content

Make sure that a FlutterLogo doesn't crash in 0x0 environment - #180617

Merged
auto-submit[bot] merged 1 commit into
flutter:masterfrom
ahmedsameha1:handle#6537-FlutterLogo
Jan 12, 2026
Merged

Make sure that a FlutterLogo doesn't crash in 0x0 environment#180617
auto-submit[bot] merged 1 commit into
flutter:masterfrom
ahmedsameha1:handle#6537-FlutterLogo

Conversation

@ahmedsameha1

@ahmedsameha1ahmedsameha1 commented Jan 7, 2026

Copy link
Copy Markdown
Contributor

This is my attempt to handle #6537 for the FlutterLogo widget.

@github-actionsgithub-actionsBot added the framework flutter/packages/flutter repository. See also f: labels. label Jan 7, 2026
gemini-code-assist[bot]
gemini-code-assistBot reviewed Jan 7, 2026
View reviewed changes

@gemini-code-assistgemini-code-assistBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds a regression test for the FlutterLogo widget. The test verifies that the widget does not crash when rendered in a zero-sized area by placing it within a SizedBox.shrink(). My review includes a suggestion to simplify the test's widget tree for conciseness. The provided changes only contain the test addition, and not the associated fix for the crash.

Comment threadpackages/flutter/test/widgets/flutter_logo_test.dart
await tester.pumpWidget(
const Directionality(
textDirection: TextDirection.ltr,
child: Center(child: SizedBox.shrink(child: FlutterLogo())),

@gemini-code-assistgemini-code-assistBotJan 7, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The Center widget is redundant here. SizedBox.shrink() already constrains its child to a 0x0 size, so the Center widget has no effect on the layout of the FlutterLogo. Removing it will make the test's widget tree more minimal and focused on the specific scenario being tested.

 child:SizedBox.shrink(child:FlutterLogo()),

@dkwingsmtdkwingsmt added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 12, 2026
@auto-submit
auto-submitBot added this pull request to the merge queueJan 12, 2026
Merged via the queue into flutter:master with commit 4b5de7dJan 12, 2026
71 checks passed
@flutter-dashboardflutter-dashboardBot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jan 12, 2026
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 12, 2026
@engine-flutter-autoroll
4b5de7dMake sure that a FlutterLogo doesn't crash in 0x0 environment (…
9d5a8db
…flutter/flutter#180617)
@engine-flutter-autorollengine-flutter-autoroll mentioned this pull request Jan 12, 2026
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 12, 2026
@engine-flutter-autoroll
4b5de7dMake sure that a FlutterLogo doesn't crash in 0x0 environment (…
0930db8
…flutter/flutter#180617)
@engine-flutter-autorollengine-flutter-autoroll mentioned this pull request Jan 12, 2026
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 12, 2026
@engine-flutter-autoroll
4b5de7dMake sure that a FlutterLogo doesn't crash in 0x0 environment (…
001420b
…flutter/flutter#180617)
@engine-flutter-autorollengine-flutter-autoroll mentioned this pull request Jan 12, 2026
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 12, 2026
@engine-flutter-autoroll
4b5de7dMake sure that a FlutterLogo doesn't crash in 0x0 environment (…
1f679f2
…flutter/flutter#180617)
@engine-flutter-autorollengine-flutter-autoroll mentioned this pull request Jan 12, 2026
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 12, 2026
@engine-flutter-autoroll
4b5de7dMake sure that a FlutterLogo doesn't crash in 0x0 environment (…
2f808ea
…flutter/flutter#180617)
@engine-flutter-autorollengine-flutter-autoroll mentioned this pull request Jan 12, 2026
Closed
auto-submitBot pushed a commit to flutter/packages that referenced this pull request Jan 12, 2026
@engine-flutter-autoroll
Roll Flutter from3134be8tod81cd3e(11 revisions) (#10779)
9b15014
flutter/flutter@3134be8...d81cd3e
2026-01-12 47866232+chunhtai@users.noreply.github.com Migrate doc and code to use sendAnnounce (flutter/flutter#180776)
2026-01-12 engine-flutter-autoroll@skia.org Roll Packages from 51fe1d9 to e57e7f4 (3 revisions) (flutter/flutter#180846)
2026-01-12 dixita0607@users.noreply.github.com Fix: Allow dartpad embed clipboard-write permission for "Copy to clipboard" functionality (flutter/flutter#178057)
2026-01-12 engine-flutter-autoroll@skia.org Roll Dart SDK from 87fbfd5381b6 to 42fd9ef68c1a (1 revision) (flutter/flutter#180836)
2026-01-12 engine-flutter-autoroll@skia.org Roll Skia from aefdde600f1e to 487a9943210b (3 revisions) (flutter/flutter#180835)
2026-01-12 goderbauer@google.com Bump ffigen (flutter/flutter#180507)
2026-01-12 engine-flutter-autoroll@skia.org Roll Skia from d42a43daa6cf to aefdde600f1e (1 revision) (flutter/flutter#180829)
2026-01-12 ahmedsameha1@gmail.com Make sure that a LongPressDraggable doesn't crash in 0x0 environment (flutter/flutter#180408)
2026-01-12 ahmedsameha1@gmail.com Make sure that a FlutterLogo doesn't crash in 0x0 environment (flutter/flutter#180617)
2026-01-12 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from T_HOCpDjLgzi1SUMq... to VYeyMPe1lyCtlcl-V... (flutter/flutter#180825)
2026-01-11 engine-flutter-autoroll@skia.org Roll Skia from f39cc645b1dd to d42a43daa6cf (2 revisions) (flutter/flutter#180819)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC stuartmorgan@google.com,tarrinneal@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
ivan-vanyusho pushed a commit to ivan-vanyusho/packages that referenced this pull request Jan 26, 2026
@engine-flutter-autoroll@ivan-vanyusho
Roll Flutter from3134be8tod81cd3e(11 revisions) (flutter#10779)
c0837e1
flutter/flutter@3134be8...d81cd3e
2026-01-12 47866232+chunhtai@users.noreply.github.com Migrate doc and code to use sendAnnounce (flutter/flutter#180776)
2026-01-12 engine-flutter-autoroll@skia.org Roll Packages from 51fe1d9 to e57e7f4 (3 revisions) (flutter/flutter#180846)
2026-01-12 dixita0607@users.noreply.github.com Fix: Allow dartpad embed clipboard-write permission for "Copy to clipboard" functionality (flutter/flutter#178057)
2026-01-12 engine-flutter-autoroll@skia.org Roll Dart SDK from 87fbfd5381b6 to 42fd9ef68c1a (1 revision) (flutter/flutter#180836)
2026-01-12 engine-flutter-autoroll@skia.org Roll Skia from aefdde600f1e to 487a9943210b (3 revisions) (flutter/flutter#180835)
2026-01-12 goderbauer@google.com Bump ffigen (flutter/flutter#180507)
2026-01-12 engine-flutter-autoroll@skia.org Roll Skia from d42a43daa6cf to aefdde600f1e (1 revision) (flutter/flutter#180829)
2026-01-12 ahmedsameha1@gmail.com Make sure that a LongPressDraggable doesn't crash in 0x0 environment (flutter/flutter#180408)
2026-01-12 ahmedsameha1@gmail.com Make sure that a FlutterLogo doesn't crash in 0x0 environment (flutter/flutter#180617)
2026-01-12 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from T_HOCpDjLgzi1SUMq... to VYeyMPe1lyCtlcl-V... (flutter/flutter#180825)
2026-01-11 engine-flutter-autoroll@skia.org Roll Skia from f39cc645b1dd to d42a43daa6cf (2 revisions) (flutter/flutter#180819)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC stuartmorgan@google.com,tarrinneal@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
creatorpiyush pushed a commit to creatorpiyush/packages that referenced this pull request Jun 10, 2026
@engine-flutter-autoroll
Roll Flutter from3134be8tod81cd3e(11 revisions) (flutter#10779)
475be17
flutter/flutter@3134be8...d81cd3e
2026-01-12 47866232+chunhtai@users.noreply.github.com Migrate doc and code to use sendAnnounce (flutter/flutter#180776)
2026-01-12 engine-flutter-autoroll@skia.org Roll Packages from 51fe1d9 to e57e7f4 (3 revisions) (flutter/flutter#180846)
2026-01-12 dixita0607@users.noreply.github.com Fix: Allow dartpad embed clipboard-write permission for "Copy to clipboard" functionality (flutter/flutter#178057)
2026-01-12 engine-flutter-autoroll@skia.org Roll Dart SDK from 87fbfd5381b6 to 42fd9ef68c1a (1 revision) (flutter/flutter#180836)
2026-01-12 engine-flutter-autoroll@skia.org Roll Skia from aefdde600f1e to 487a9943210b (3 revisions) (flutter/flutter#180835)
2026-01-12 goderbauer@google.com Bump ffigen (flutter/flutter#180507)
2026-01-12 engine-flutter-autoroll@skia.org Roll Skia from d42a43daa6cf to aefdde600f1e (1 revision) (flutter/flutter#180829)
2026-01-12 ahmedsameha1@gmail.com Make sure that a LongPressDraggable doesn't crash in 0x0 environment (flutter/flutter#180408)
2026-01-12 ahmedsameha1@gmail.com Make sure that a FlutterLogo doesn't crash in 0x0 environment (flutter/flutter#180617)
2026-01-12 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from T_HOCpDjLgzi1SUMq... to VYeyMPe1lyCtlcl-V... (flutter/flutter#180825)
2026-01-11 engine-flutter-autoroll@skia.org Roll Skia from f39cc645b1dd to d42a43daa6cf (2 revisions) (flutter/flutter#180819)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC stuartmorgan@google.com,tarrinneal@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dkwingsmtdkwingsmtdkwingsmt approved these changes
@victorsannivictorsannivictorsanni approved these changes
+1 more reviewer
@gemini-code-assistgemini-code-assist[bot]gemini-code-assist[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

frameworkflutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ahmedsameha1@dkwingsmt@victorsanni