Skip to content

[fuchsia] Place FFI callback stub into the package. - #185307

Merged
auto-submit[bot] merged 1 commit into
flutter:masterfrom
rmacnak-google:fuchsia-new-blob
Apr 29, 2026
Merged

[fuchsia] Place FFI callback stub into the package.#185307
auto-submit[bot] merged 1 commit into
flutter:masterfrom
rmacnak-google:fuchsia-new-blob

Conversation

@rmacnak-google

@rmacnak-googlermacnak-google commented Apr 20, 2026

Copy link
Copy Markdown
Contributor

This is the Flutter side of https://dart-review.googlesource.com/c/sdk/+/495840. The Flutter side should be submitted first, i.e., make the blob available before trying to use it.

Most of the diff is making explicit that previously existing resources go under /pkg/data so that the new resource can go under /pkg/lib like ELF shared libraries do.

@github-actionsgithub-actionsBot added engine flutter/engine related. See also e: labels. platform-fuchsia Fuchsia code specifically labels Apr 20, 2026
@rmacnak-googlermacnak-google added the CICD Run CI/CD label Apr 20, 2026
@github-actionsgithub-actionsBot removed the CICD Run CI/CD label Apr 21, 2026
@rmacnak-googlermacnak-google added the CICD Run CI/CD label Apr 21, 2026
@github-actionsgithub-actionsBot removed the CICD Run CI/CD label Apr 23, 2026
@rmacnak-googlermacnak-google added the CICD Run CI/CD label Apr 23, 2026
@rmacnak-google
rmacnak-google marked this pull request as ready for review April 23, 2026 20:27

@gemini-code-assistgemini-code-assistBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces FFI callback stub generation for Fuchsia Dart and Flutter runners and refactors resource destination paths to explicitly include the 'data/' prefix. Review feedback suggests adding a parameter assertion to the new GN template for consistency, simplifying redundant string interpolation, and including the '--enable_mirrors=false' flag to align the Flutter runner's stub generation with the Dart runner's implementation.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CICDRun CI/CDengineflutter/engine related. See also e: labels.platform-fuchsiaFuchsia code specifically

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@rmacnak-google@jason-simmons