Uh oh!
There was an error while loading. Please reload this page.
[fuchsia] Place FFI callback stub into the package. - #185307
Conversation
402f822 to
0c3175fCompare0c3175f to
8cf82feCompare8cf82fe to
2261888CompareThere was a problem hiding this comment.
Code Review
This pull request introduces FFI callback stub generation for Fuchsia Dart and Flutter runners and refactors resource destination paths to explicitly include the 'data/' prefix. Review feedback suggests adding a parameter assertion to the new GN template for consistency, simplifying redundant string interpolation, and including the '--enable_mirrors=false' flag to align the Flutter runner's stub generation with the Dart runner's implementation.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
This is the Flutter side of https://dart-review.googlesource.com/c/sdk/+/495840. The Flutter side should be submitted first, i.e., make the blob available before trying to use it.
Most of the diff is making explicit that previously existing resources go under /pkg/data so that the new resource can go under /pkg/lib like ELF shared libraries do.