Skip to content

[fuchsia] Ask for VMEX only for JIT. - #185440

Merged
auto-submit[bot] merged 1 commit into
flutter:masterfrom
rmacnak-google:vmex-jit-only
Apr 28, 2026
Merged

[fuchsia] Ask for VMEX only for JIT.#185440
auto-submit[bot] merged 1 commit into
flutter:masterfrom
rmacnak-google:vmex-jit-only

Conversation

@rmacnak-google

@rmacnak-googlermacnak-google commented Apr 22, 2026

Copy link
Copy Markdown
Contributor

Bug: b/501539846

@rmacnak-googlermacnak-google added the CICD Run CI/CD label Apr 22, 2026
@github-actionsgithub-actionsBot added engine flutter/engine related. See also e: labels. platform-fuchsia Fuchsia code specifically labels Apr 22, 2026
@github-actionsgithub-actionsBot removed the CICD Run CI/CD label Apr 23, 2026
@rmacnak-googlermacnak-google added the CICD Run CI/CD label Apr 23, 2026
@flutter-dashboardflutter-dashboardBot removed the CICD Run CI/CD label Apr 23, 2026
@rmacnak-googlermacnak-google added the CICD Run CI/CD label Apr 23, 2026
@rmacnak-google
rmacnak-google marked this pull request as ready for review April 23, 2026 20:28

@gemini-code-assistgemini-code-assistBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request relocates the fuchsia.kernel.VmexResource protocol from common shards to JIT-specific runner manifests for both Dart and Flutter. Review feedback suggests that removing this capability from the common shards may cause regressions in AOT mode, specifically breaking FFI callback functionality which relies on VMEX for thunks.

@flutter-dashboard

Copy link
Copy Markdown

It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging.

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. If you believe this PR qualifies for a test exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group.

@github-actionsgithub-actionsBot removed the CICD Run CI/CD label Apr 28, 2026
@rmacnak-googlermacnak-google added the CICD Run CI/CD label Apr 28, 2026
@rmacnak-googlermacnak-google added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 28, 2026
@auto-submitauto-submitBot removed the autosubmit Merge PR when tree becomes green via auto submit App label Apr 28, 2026
@auto-submit

Copy link
Copy Markdown
Contributor

autosubmit label was removed for flutter/flutter/185440, because - The status or check suite Mac mac_unopt has failed. Please fix the issues identified (or deflake) before re-applying this label.

@rmacnak-googlermacnak-google added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 28, 2026
@auto-submit
auto-submitBot added this pull request to the merge queueApr 28, 2026
Merged via the queue into flutter:master with commit 0a88985Apr 28, 2026
203 of 204 checks passed
@flutter-dashboardflutter-dashboardBot removed the autosubmit Merge PR when tree becomes green via auto submit App label Apr 28, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CICDRun CI/CDengineflutter/engine related. See also e: labels.platform-fuchsiaFuchsia code specifically

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@rmacnak-google@jason-simmons