Uh oh!
There was an error while loading. Please reload this page.
[fuchsia] Ask for VMEX only for JIT. - #185440
Conversation
c5ace4f to
97205b8Compare97205b8 to
bbb69feCompareThere was a problem hiding this comment.
Code Review
This pull request relocates the fuchsia.kernel.VmexResource protocol from common shards to JIT-specific runner manifests for both Dart and Flutter. Review feedback suggests that removing this capability from the common shards may cause regressions in AOT mode, specifically breaking FFI callback functionality which relies on VMEX for thunks.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. If you believe this PR qualifies for a test exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group. |
bbb69fe to
e2d1061Compareautosubmit label was removed for flutter/flutter/185440, because - The status or check suite Mac mac_unopt has failed. Please fix the issues identified (or deflake) before re-applying this label. |
Uh oh!
There was an error while loading. Please reload this page.
Bug: b/501539846