Skip to content

Sized to content for regular and dialog windows on win32 - #186829

Merged
mattkae merged 19 commits into
flutter:masterfrom
canonical:sized-to-content-win32
Jun 11, 2026
Merged

Sized to content for regular and dialog windows on win32#186829
mattkae merged 19 commits into
flutter:masterfrom
canonical:sized-to-content-win32

Conversation

@mattkae

@mattkaemattkae commented May 20, 2026•
edited
Loading

Copy link
Copy Markdown
Contributor

What's new?

How to test?

  1. Run the multiple_windows example app on win32
  2. Go to the window settings dialog and change the "sized to content" boolean for dialogs and regulars
  3. Open up a dialog or a regular window and see that they are sized to their content

Caveat: The example app does not strictly size dialogs and regulars, so they will open up at the current screen dimensions.

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [AI contribution guidelines] and understand my responsibilities, or I am not using AI tools.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • I followed the [breaking change policy] and added [Data Driven Fixes] where supported.
  • All existing and new tests are passing.

@flutter-dashboardflutter-dashboardBot added the CICD Run CI/CD label May 20, 2026
@github-actionsgithub-actionsBot added framework flutter/packages/flutter repository. See also f: labels. engine flutter/engine related. See also e: labels. platform-windows Building on or for Windows specifically d: examples Sample code and demos a: desktop Running on desktop team-windows Owned by the Windows platform team labels May 20, 2026
@github-actionsgithub-actionsBot removed the CICD Run CI/CD label May 21, 2026
@flutter-dashboardflutter-dashboardBot added the CICD Run CI/CD label May 21, 2026
@github-actionsgithub-actionsBot removed the CICD Run CI/CD label May 21, 2026
@flutter-dashboardflutter-dashboardBot added the CICD Run CI/CD label May 21, 2026
@github-actionsgithub-actionsBot removed the CICD Run CI/CD label May 21, 2026
@flutter-dashboardflutter-dashboardBot added the CICD Run CI/CD label May 21, 2026
@github-actionsgithub-actionsBot removed the CICD Run CI/CD label May 21, 2026
@flutter-dashboardflutter-dashboardBot added the CICD Run CI/CD label May 21, 2026
@github-actionsgithub-actionsBot removed the CICD Run CI/CD label May 21, 2026
@flutter-dashboardflutter-dashboardBot added the CICD Run CI/CD label May 21, 2026
@github-actionsgithub-actionsBot removed the CICD Run CI/CD label May 21, 2026
@mattkae
mattkaeforce-pushed the sized-to-content-win32 branch from 376a588 to 6f66e57CompareMay 21, 2026 17:31
@flutter-dashboardflutter-dashboardBot added the CICD Run CI/CD label May 21, 2026
@github-actionsgithub-actionsBot removed the CICD Run CI/CD label May 21, 2026
@flutter-dashboardflutter-dashboardBot added the CICD Run CI/CD label May 21, 2026
@github-actionsgithub-actionsBot removed the CICD Run CI/CD label May 21, 2026
@flutter-dashboardflutter-dashboardBot added the CICD Run CI/CD label May 21, 2026
@mattkae
mattkae requested review from loic-sharma and robert-ancell and removed request for robert-ancellJune 1, 2026 19:45
@mattkaemattkae added the CICD Run CI/CD label Jun 1, 2026
loic-sharma
loic-sharma reviewed Jun 3, 2026
View reviewed changes
Comment threadexamples/multiple_windows/lib/app/dialog_window_content.dart Outdated
loic-sharma
loic-sharma reviewed Jun 3, 2026
View reviewed changes
Comment threadexamples/multiple_windows/lib/app/regular_window_content.dart Outdated
loic-sharma
loic-sharma reviewed Jun 3, 2026
View reviewed changes
Comment threadexamples/multiple_windows/lib/app/window_settings_dialog.dart Outdated
loic-sharma
loic-sharma previously approved these changes Jun 3, 2026
View reviewed changes

@loic-sharmaloic-sharma left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me!

@github-actionsgithub-actionsBot removed the CICD Run CI/CD label Jun 4, 2026
@mattkaemattkae added the CICD Run CI/CD label Jun 4, 2026
@github-actionsgithub-actionsBot removed the CICD Run CI/CD label Jun 4, 2026
@mattkaemattkae added the CICD Run CI/CD label Jun 4, 2026
loic-sharma
loic-sharma approved these changes Jun 4, 2026
View reviewed changes

@loic-sharmaloic-sharma left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-LGTM!

@mattkae
mattkae added this pull request to the merge queueJun 4, 2026
@mattkae
mattkae removed this pull request from the merge queue due to a manual request Jun 4, 2026
@mattkae
mattkae added this pull request to the merge queueJun 9, 2026
@github-merge-queue
github-merge-queueBot removed this pull request from the merge queue due to failed status checks Jun 9, 2026
@mattkae
mattkae added this pull request to the merge queueJun 10, 2026
@github-merge-queue
github-merge-queueBot removed this pull request from the merge queue due to failed status checks Jun 11, 2026
@mattkae
mattkae added this pull request to the merge queueJun 11, 2026
Merged via the queue into flutter:master with commit 6414603Jun 11, 2026
201 checks passed
@mattkae
mattkae deleted the sized-to-content-win32 branch June 11, 2026 14:27
@engine-flutter-autorollengine-flutter-autoroll mentioned this pull request Jun 11, 2026
Merged
auto-submitBot pushed a commit to flutter/packages that referenced this pull request Jun 11, 2026
@engine-flutter-autoroll
Roll Flutter from c0a11291aa8c to 8bdce07b84e1 (13 revisions) (#11885)
2fb6a47
flutter/flutter@c0a1129...8bdce07
2026-06-11 bernaferrari2@gmail.com Make shape border lerp symmetric (flutter/flutter#187282)
2026-06-11 matt.kosarek@canonical.com Sized to content for regular and dialog windows on win32 (flutter/flutter#186829)
2026-06-11 jason-simmons@users.noreply.github.com Ensure that directory names are typed as strings in the CIPD package YAML file generated by merge_and_upload_debug_symbols.py (flutter/flutter#187813)
2026-06-11 stuartmorgan@google.com Add core-packages to ecosystem triage (flutter/flutter#187796)
2026-06-11 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from 8azSyvz57mKcPqTwk... to 2KosSR4ONUjIB7tP_... (flutter/flutter#187842)
2026-06-11 ishaquehassan@gmail.com Document moveStep direction on WidgetController.dragUntilVisible (flutter/flutter#186943)
2026-06-11 ahmedsameha1@gmail.com Add more 0x0 size tests part 11 (flutter/flutter#186822)
2026-06-10 kumarshivam72@gmail.com Fix ShapeDecoration.lerp crash when interpolating between gradient and color (flutter/flutter#187368)
2026-06-10 codedoctor@linwood.dev Reland "Add support for stylus buttons" (flutter/flutter#187629)
2026-06-10 tanyabouman@gmail.com Api docs: typo fix in Navigator (flutter/flutter#187572)
2026-06-10 engine-flutter-autoroll@skia.org Roll Packages from bd297cf to 1b56cde (4 revisions) (flutter/flutter#187784)
2026-06-10 116356835+AbdeMohlbi@users.noreply.github.com Improve docs on MediaQuery: highContrast, invertColors and disableAnimations (flutter/flutter#186614)
2026-06-10 matt.boetger@gmail.com [Android] Test to verify AnnounceSemanticsEvent deprecation warning on API 36 (flutter/flutter#187754)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC louisehsu@google.com,stuartmorgan@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@PiinksPiinks mentioned this pull request Jun 12, 2026
Open
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@loic-sharmaloic-sharmaloic-sharma approved these changes
@knoppknoppAwaiting requested review from knopp
@robert-ancellrobert-ancellAwaiting requested review from robert-ancell
+1 more reviewer
@gemini-code-assistgemini-code-assist[bot]gemini-code-assist[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

a: desktopRunning on desktopCICDRun CI/CDd: examplesSample code and demosengineflutter/engine related. See also e: labels.frameworkflutter/packages/flutter repository. See also f: labels.platform-windowsBuilding on or for Windows specificallyteam-windowsOwned by the Windows platform team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mattkae@robert-ancell@loic-sharma