[web] Keep the keyboard up during an iOS caret drag by flutter-zl · Pull Request #190014 · flutter/flutter

flutter-zl · 2026-07-24T23:44:41Z

Problem
On iOS 27, long-press-dragging the selection caret in a Web TextField dismisses the keyboard mid-gesture. WebKit transiently blurs the hidden input with a null relatedTarget while the document keeps focus, then refocuses it a frame later,and the engine reacted to that blink on two listeners that each tore the input down. A plain input ignores the same blur, so the cause is Flutter's reaction, not a WebKit limitation.

Fix
On iOS both listeners now defer their teardown by 100ms and cancel it if the input refocuses, mirroring the existing #155265 deferred close. Done and tap-away never refocus so they still close, and the deferral is narrowed to the exact drag signature so every other focus transition is unaffected.

Demo
Before: https://flutter-demo-52-before.web.app (keyboard dismisses mid caret drag)
After: https://flutter-demo-52-after.web.app (keyboard stays up)

Repro on iOS 27 Safari: tap the field to raise the keyboard, then long-press and drag the selection caret. Before dismisses; after stays up. Done and tap-away still dismiss.

gemini-code-assist

Code Review

This pull request introduces deferred handling for focusout events and text connection closures on iOS Safari to prevent transient blurs (such as during caret or selection dragging) from prematurely dismissing the keyboard. This is achieved by implementing timers in ViewFocusBinding and DefaultTextEditingStrategy that delay the blur reporting, allowing an immediate refocus to cancel the operation. Corresponding unit tests have been added to verify these changes. There are no review comments, so I have no feedback to provide.

Renzo-Olivares

Just a few small comments. I think the overall approach looks good.

Renzo-Olivares · 2026-08-03T03:23:28Z

+/// iOS caret-drag deferral tests do not depend on the headless browser
+/// reporting the test document as focused. Mirrors
+/// `DefaultTextEditingStrategy.debugDocumentHasFocusOverride`.
+bool? debugViewFocusDocumentHasFocusOverride;


nit: I think we should add a @visibleForTesting if this is only meant to be used in tests.

I see that we do use it in the focus out listener.
I think similar to _documentVisibilityState below, we should have a seperate private variable:
flutter/engine/src/flutter/lib/web_ui/lib/src/engine/text_editing/text_editing.dart
Lines 1536 to 1543 in de01d5d
/// Overrides the result of [domDocument.visibilityState] for testing.
@visibleForTesting
String? debugDocumentVisibilityStateOverride;
boolget _documentHasFocus => debugDocumentHasFocusOverride ?? domDocument.hasFocus();
Stringget _documentVisibilityState =>
debugDocumentVisibilityStateOverride ?? domDocument.visibilityState;

Added a _documentHasFocus getter mirroring DefaultTextEditingStrategy._documentHasFocus, and the focusout listener reads that instead of naming the override directly.

Renzo-Olivares · 2026-08-03T04:04:37Z

+ // https://github.com/flutter/flutter/issues/189744
+ if (isIosSafari) {
+ _pendingBlurConnectionCloseTimer?.cancel();
+ _pendingBlurConnectionCloseTimer = Timer(const Duration(milliseconds: 100), () {


I think we use the same Duration(milliseconds: 100) 2 times in this file and once in view_focus_binding.dart for the same focus related reasons. Consider extracting a shared const member that can be used across both files.

Good catch. Done.

Renzo-Olivares · 2026-08-03T04:07:18Z

+ view.dom.rootElement.append(other);
+ other.focusWithoutScroll();
+ dispatchedViewFocusEvents.clear();
+


Should we be setting debugViewFocusDocumentHasFocusOverride in this test as well?

Renzo-Olivares · 2026-08-03T05:37:05Z

+ /// [ViewFocusBinding] also matches on this class to detect blurs originating
+ /// from the text-editing element, so it is a production contract, not just a
+ /// testing hook.
 static const String textEditingClass = 'flt-text-editing';


Instead of exposing this, have we considered instead adding a public member that signals this is an active text editing client to HybridTextEditing so that we don't expose this and rely on the name of a CSS class. And so the solution also works for a11y. As is it does not because I don't think flt-text-editing is added by SemanticsTextEditingStrategy only DefaultTextEditingStrategy.initializeTextEditing which is overriden by SemanticsTextEditingStrategy.

Replaced with a member on HybridTextEditing:
boolisActiveTextEditingElement(DomElement? element) => isEditing && element !=null&& element == strategy.domElement;

Renzo-Olivares

LGTM, w/ some small docs comments.

Renzo-Olivares · 2026-08-06T18:01:17Z

+ /// [ViewFocusBinding] uses this to recognize a `focusout` that originated
+ /// from the active text-editing element.
+ ///
+ /// Prefer this over matching on [textEditingClass]. That class is applied by


Consider shrinking this paragraph to the below in case [SemanticsTextEditingStrategy] ever changes so this documentation doesn't get stale.
/// Prefer this over matching on [textEditingClass]. That class is /// not guaranteed to be applied by all strategies.

Good suggestion. Done.

Renzo-Olivares · 2026-08-06T18:19:39Z

+///
+/// Sets the real singleton state rather than applying
+/// [HybridTextEditing.textEditingClass], so these tests exercise the same signal
+/// production code reads. The class is only applied by


Consider softening this last sentence to:
The class is not guaranteed to be applied by all text editing strategies, so keying tests off it would not reflect the prodution code.

Good suggestion. Done.

Renzo-Olivares · 2026-08-06T19:48:09Z

- // semantics enabled the live editing element never carries it. Keying off
- // the class left the fix dead under VoiceOver.
+ // `flt-text-editing` class, which is not guaranteed to be applied by all
+ // text editing strategies. An earlier revision matched on the class, which


nit: I would remove this last sentence it's helpful for me as a reviewer but not to contributors in the future.
or maybe change to:
Matching on the class would leave the deferral dead for strategies that do not apply it.

Good suggestion. Done.

Renzo-Olivares

LGTM, thank you for the fix!

auto-submit · 2026-08-06T21:09:56Z

autosubmit label was removed for flutter/flutter/190014, because - The status or check suite Dashboard Checks has failed. Please fix the issues identified (or deflake) before re-applying this label.

auto-submit · 2026-08-07T00:15:39Z

auto label is removed for flutter/flutter/190014, Failed to enqueue flutter/flutter/190014 with HTTP 400: Pull request Required status check "Check Code Freeze" is queued..

auto-submit · 2026-08-07T18:39:39Z

autosubmit label was removed for flutter/flutter/190014, because - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label.

auto-submit · 2026-08-07T19:45:14Z

autosubmit label was removed for flutter/flutter/190014, because - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label.

jtmcdole · 2026-08-11T15:18:48Z

Reason for revert: This is failing in post submit on a suppressed test. Since this is a hard failure, we should revert:

00:10 +400 ~30 -1: text_editing_test.dart: GloballyPositionedTextEditingStrategy closes the text connection on iOS when the input is not refocused after a null-relatedTarget blur [E] Expected: an object with length of <1>
Actual: []
Which: has length of <0>

https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8673753854704709425/+/u/test:_run_suite_safari-dart2js-canvaskit-engine/stdout

flutteractionsbot · 2026-08-11T15:20:05Z

Successfully created revert PR: #190926

@jtmcdole

…190926) Reverts: [[web] Keep the keyboard up during an iOS caret drag](flutter#190014) Initiated by: @jtmcdole Reason for reverting: Original PR Author: @flutter-zl Reviewed By: @Renzo-Olivares The original PR description is provided below: Fixesflutter#189744 **Problem** On iOS 27, long-press-dragging the selection caret in a Web TextField dismisses the keyboard mid-gesture. WebKit transiently blurs the hidden input with a null relatedTarget while the document keeps focus, then refocuses it a frame later,and the engine reacted to that blink on two listeners that each tore the input down. A plain input ignores the same blur, so the cause is Flutter's reaction, not a WebKit limitation. **Fix** On iOS both listeners now defer their teardown by 100ms and cancel it if the input refocuses, mirroring the existing flutter#155265 deferred close. Done and tap-away never refocus so they still close, and the deferral is narrowed to the exact drag signature so every other focus transition is unaffected. **Demo** Before: https://flutter-demo-52-before.web.app (keyboard dismisses mid caret drag) After: https://flutter-demo-52-after.web.app (keyboard stays up) Repro on iOS 27 Safari: tap the field to raise the keyboard, then long-press and drag the selection caret. Before dismisses; after stays up. Done and tap-away still dismiss.

[web] Keep the keyboard up during an iOS caret drag
9fbba74

flutter-dashboardBot added the CICD Run CI/CD label Jul 24, 2026

github-actionsBot added a: text input Entering text in a text field or keyboard related problems engine flutter/engine related. See also e: labels. platform-web Web applications specifically f: focus Focus traversal, gaining or losing focus team-web Owned by Web platform team labels Jul 24, 2026

gemini-code-assistBot reviewed Jul 24, 2026
View reviewed changes

flutter-zl added 2 commits July 24, 2026 16:48

Merge branch 'master' into issue_189744_fix
25dab55

Merge branch 'master' into issue_189744_fix
0ad8540

flutter-zl requested a review from Renzo-Olivares July 27, 2026 17:13

flutter-zl mentioned this pull request Jul 29, 2026
[web] iOS 27: TextField cursor sticks when dragging the caret after text is selected #190242
Closed

Renzo-Olivares reviewed Aug 3, 2026
View reviewed changes

flutter-zl requested a review from Renzo-Olivares August 5, 2026 19:21

flutter-zl added 2 commits August 5, 2026 12:21

Merge branch 'master' into issue_189744_fix
b4d97b9

[web] Key caret-drag deferral off editing state, not CSS class
b1d5e63

flutter-zl force-pushed the issue_189744_fix branch from 5eb2bf6 to b1d5e63Compare August 5, 2026 20:04

Renzo-Olivares previously approved these changes Aug 6, 2026
View reviewed changes

[web] Avoid naming specific strategies in caret-drag docs
c0c762f

flutter-zl dismissed Renzo-Olivares’s stale review via c0c762fAugust 6, 2026 19:31

Renzo-Olivares reviewed Aug 6, 2026
View reviewed changes

flutter-zl requested a review from Renzo-Olivares August 6, 2026 19:49

flutter-zl added 2 commits August 6, 2026 12:49

Merge branch 'master' into issue_189744_fix
997d4b1

[web] Drop reviewer-facing history from a test comment
027a763

Renzo-Olivares approved these changes Aug 6, 2026
View reviewed changes

flutter-zl added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 6, 2026

auto-submitBot removed the autosubmit Merge PR when tree becomes green via auto submit App label Aug 6, 2026

flutter-zl added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 6, 2026

auto-submitBot removed the autosubmit Merge PR when tree becomes green via auto submit App label Aug 6, 2026

auto-submitBot removed the autosubmit Merge PR when tree becomes green via auto submit App label Aug 7, 2026

Merge branch 'master' into issue_189744_fix
432742c

flutter-zl added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 7, 2026

Merge branch 'master' into issue_189744_fix
29d2356

auto-submitBot removed the autosubmit Merge PR when tree becomes green via auto submit App label Aug 7, 2026

Merge branch 'master' into issue_189744_fix
5d9797b

flutter-zl added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 7, 2026

auto-submitBot removed the autosubmit Merge PR when tree becomes green via auto submit App label Aug 7, 2026

flutter-zl added 2 commits August 7, 2026 13:59

Merge branch 'master' into issue_189744_fix
b11bd55

Merge branch 'master' into issue_189744_fix
dafb466

flutter-zl added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 10, 2026

auto-submitBot added this pull request to the merge queue Aug 10, 2026

Merged via the queue into flutter:master with commit 347dff3Aug 10, 2026
21 of 22 checks passed

flutter-dashboardBot removed the autosubmit Merge PR when tree becomes green via auto submit App label Aug 10, 2026

engine-flutter-autoroll mentioned this pull request Aug 11, 2026
Roll Flutter from 27b098811f3b to 24240702e683 (123 revisions) flutter/packages#12431
Closed

jtmcdole added the revert Autorevert PR (with "Reason for revert:" comment) label Aug 11, 2026

flutteractionsbot mentioned this pull request Aug 11, 2026
Revert: [web] Keep the keyboard up during an iOS caret drag #190926
Merged

flutteractionsbot removed the revert Autorevert PR (with "Reason for revert:" comment) label Aug 11, 2026

This was referenced Aug 11, 2026
Roll Flutter from 27b098811f3b to dc0a602f0ed1 (124 revisions) flutter/packages#12433
Closed
Roll Flutter from 27b098811f3b to 4f85c1701be3 (128 revisions) flutter/packages#12434
Closed

flutter-zl mentioned this pull request Aug 11, 2026
Reland "[web] Keep the keyboard up during an iOS caret drag" #190942
Open

herdiyana256 mentioned this pull request Aug 12, 2026
flutter_tools: validate plugin identifiers before generating registrant code #190462
Merged

sero583 mentioned this pull request Aug 21, 2026
[web] Fix password-manager autofill not reaching text fields #190126
Open
10 tasks

	/// Overrides the result of [domDocument.visibilityState] for testing.
	@visibleForTesting
	String? debugDocumentVisibilityStateOverride;

	boolget _documentHasFocus => debugDocumentHasFocusOverride ?? domDocument.hasFocus();

	Stringget _documentVisibilityState =>
	debugDocumentVisibilityStateOverride ?? domDocument.visibilityState;

Uh oh!

Conversation

flutter-zl commented Jul 24, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gemini-code-assistBot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Renzo-Olivares left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Renzo-Olivares left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Renzo-Olivares left a comment

Choose a reason for hiding this comment

Uh oh!

auto-submitBot commented Aug 6, 2026

Uh oh!

auto-submitBot commented Aug 7, 2026

Uh oh!

auto-submitBot commented Aug 7, 2026

Uh oh!

auto-submitBot commented Aug 7, 2026

Uh oh!

Uh oh!

jtmcdole commented Aug 11, 2026

Uh oh!

flutteractionsbot commented Aug 11, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

flutter-zl commented Jul 24, 2026•
edited
Loading