Skip to content

Enable Gradle cache for a single test target - #190474

Merged
auto-submit[bot] merged 3 commits into
flutter:masterfrom
mboetger:enable-cache
Aug 5, 2026
Merged

Enable Gradle cache for a single test target#190474
auto-submit[bot] merged 3 commits into
flutter:masterfrom
mboetger:enable-cache

Conversation

@mboetger

@mboetgermboetger commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

Enables Gradle CI Cache for single test target.

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [AI contribution guidelines] and understand my responsibilities, or I am not using AI tools.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • I followed the [breaking change policy] and added [Data Driven Fixes] where supported.
  • All existing and new tests are passing.

@mboetger
mboetger marked this pull request as ready for review August 3, 2026 21:44
@mboetger
mboetger requested a review from jtmcdoleAugust 3, 2026 21:45
gemini-code-assist[bot]
gemini-code-assistBot reviewed Aug 3, 2026
View reviewed changes

@gemini-code-assistgemini-code-assistBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds a gradle_dists dependency to the tool_tests_commands target in .ci.yaml. A review comment points out a missing comma on the preceding line, which will cause a YAML parsing error and break the CI configuration.

Comment thread.ci.yaml Outdated
@PiinksPiinks added team-android Owned by Android platform team fyi-infra For the attention of Infrastructure team labels Aug 3, 2026
@github-actionsgithub-actionsBot removed the team-android Owned by Android platform team label Aug 3, 2026
jtmcdole
jtmcdole requested changes Aug 3, 2026
View reviewed changes
Comment thread.ci.yaml Outdated
@mboetger
mboetger requested a review from jtmcdoleAugust 3, 2026 21:50
@mboetgermboetger changed the title Enable cache for a single test targetEnable Gradle cache for a single test targetAug 3, 2026
jtmcdole
jtmcdole approved these changes Aug 5, 2026
View reviewed changes

@jtmcdolejtmcdole left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

infrastructure bridge sunset outrun 2 lgtm_640_24

@mboetgermboetger added autosubmit Merge PR when tree becomes green via auto submit App CICD Run CI/CD labels Aug 5, 2026
@auto-submit
auto-submitBot added this pull request to the merge queueAug 5, 2026
Merged via the queue into flutter:master with commit c964975Aug 5, 2026
29 checks passed
@flutter-dashboardflutter-dashboardBot removed the autosubmit Merge PR when tree becomes green via auto submit App label Aug 5, 2026
@mboetgermboetger added the revert Autorevert PR (with "Reason for revert:" comment) label Aug 5, 2026
@flutteractionsbot

flutteractionsbot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

A reason for requesting a revert of flutter/flutter/190474 could not be found or the reason was not properly formatted. Begin a comment with 'Reason for revert:' to tell the bot why this issue is being reverted.

@flutteractionsbotflutteractionsbot removed the revert Autorevert PR (with "Reason for revert:" comment) label Aug 5, 2026
@mboetger

mboetger commented Aug 5, 2026

Copy link
Copy Markdown
ContributorAuthor

Reason for revert: broke the tree with spaces.

@mboetgermboetger added the revert Autorevert PR (with "Reason for revert:" comment) label Aug 5, 2026
@flutteractionsbot

flutteractionsbot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Successfully created revert PR: #190629

@flutteractionsbotflutteractionsbot mentioned this pull request Aug 5, 2026
Merged
10 tasks
@flutteractionsbotflutteractionsbot removed the revert Autorevert PR (with "Reason for revert:" comment) label Aug 5, 2026
pullBot pushed a commit to chunfengyao/flutter that referenced this pull request Aug 5, 2026
@flutteractionsbot
Revert: Enable Gradle cache for a single test target (flutter#190629)
07ab4d3
Reverts: [Enable Gradle cache for a single test
target](flutter#190474)
Initiated by: @mboetger
Reason for reverting: broke the tree with spaces.
Original PR Author: @mboetger
Reviewed By: @jtmcdole
The original PR description is provided below:
Enables Gradle CI Cache for single test target. ## Pre-launch Checklist
- [X] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [X] I read the [AI contribution guidelines] and understand my
responsibilities, or I am not using AI tools.
- [X] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [X] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [X] I signed the [CLA].
- [X] I listed at least one issue that this PR fixes in the description
above.
- [X] I updated/added relevant documentation (doc comments with `///`).
- [X] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [X] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [X] All existing and new tests are passing.
@mboetgermboetger mentioned this pull request Aug 5, 2026
Merged
10 tasks
@engine-flutter-autorollengine-flutter-autoroll mentioned this pull request Aug 6, 2026
Closed
@engine-flutter-autorollengine-flutter-autoroll mentioned this pull request Aug 6, 2026
Closed
Vi-debug pushed a commit to Vi-debug/flutter that referenced this pull request Aug 7, 2026
@mboetger
[Reland] Enable Gradle cache for CI on single test target (flutter#19…
68bd116
…0635)
This is a reland of flutter#190474. Now using ':' - which should not break the
validate luci test.
In
https://cs.opensource.google/flutter/infra/+/main:config/lib/ci_yaml/ci_yaml.star;l=93-95
the swarming cache names are created. This is what broke on the last go
- the cache names did not fit the
[regex](https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8674277389276279873/+/u/luci_validate/stdout):
`^[a-z0-9_]+$`
Before:
`flutter_main_gradle_dists_8_4_bin, 8_13_rc_1_bin, 8_14_bin, 9_3_1_bin,
9_3_1_all` ❌ does not match
After:
`flutter_main_gradle_dists_8_4_bin_8_13_rc_1_bin_8_14_bin_9_3_1_bin_9_3_1_all`
✅ does match
## Pre-launch Checklist
- [X] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [X] I read the [AI contribution guidelines] and understand my
responsibilities, or I am not using AI tools.
- [X] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [X] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [X] I signed the [CLA].
- [X] I listed at least one issue that this PR fixes in the description
above.
- [X] I updated/added relevant documentation (doc comments with `///`).
- [X] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [X] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [X] All existing and new tests are passing.
This was referenced Aug 7, 2026
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jtmcdolejtmcdolejtmcdole approved these changes
+1 more reviewer
@gemini-code-assistgemini-code-assist[bot]gemini-code-assist[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

CICDRun CI/CDfyi-infraFor the attention of Infrastructure team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mboetger@flutteractionsbot@jtmcdole@Piinks