Skip to content

Revert "Reduce the number of gtest-parallel workers when running Impeller tests on Mac Minis used by CI (#189813)" - #190560

Merged
auto-submit[bot] merged 1 commit into
flutter:masterfrom
jason-simmons:pr_189813_revert
Aug 5, 2026
Merged

Revert "Reduce the number of gtest-parallel workers when running Impeller tests on Mac Minis used by CI (#189813)"#190560
auto-submit[bot] merged 1 commit into
flutter:masterfrom
jason-simmons:pr_189813_revert

Conversation

@jason-simmons

@jason-simmonsjason-simmons commented Aug 4, 2026

Copy link
Copy Markdown
Member

This reverts commit 285bf67.

This was an experiment that tried to reduce the frequency of flakes when running Impeller OpenGLESSDF rendering tests. It is obsolete now that these tests were disabled by #190469

@jason-simmons
Revert "Reduce the number of gtest-parallel workers when running Impe…
7279983
…ller tests on Mac Minis used by CI (flutter#189813)"
This reverts commit 285bf67.
This was an experiment that tried to reduce the frequency of flakes
when running Impeller OpenGLESSDF rendering tests. It is obsolete now
that these tests were disabled by flutter#190469
@flutter-dashboardflutter-dashboardBot added the CICD Run CI/CD label Aug 4, 2026
@github-actionsgithub-actionsBot added the engine flutter/engine related. See also e: labels. label Aug 4, 2026
gemini-code-assist[bot]
gemini-code-assistBot reviewed Aug 4, 2026
View reviewed changes

@gemini-code-assistgemini-code-assistBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the mac_hardware_model function and the logic that limits the number of workers for Impeller test cases on Mac Mini hardware in engine/src/flutter/testing/run_tests.py. I have no feedback to provide.

@jason-simmonsjason-simmons added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 5, 2026
@auto-submit
auto-submitBot added this pull request to the merge queueAug 5, 2026
@github-merge-queue
github-merge-queueBot removed this pull request from the merge queue due to no response for status checks Aug 5, 2026
@flutter-dashboardflutter-dashboardBot removed the autosubmit Merge PR when tree becomes green via auto submit App label Aug 5, 2026
@jtmcdolejtmcdole added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 5, 2026
@auto-submit
auto-submitBot added this pull request to the merge queueAug 5, 2026
Merged via the queue into flutter:master with commit 9386648Aug 5, 2026
33 checks passed
@flutter-dashboardflutter-dashboardBot removed the autosubmit Merge PR when tree becomes green via auto submit App label Aug 5, 2026
This was referenced Aug 6, 2026
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gaaclarkegaaclarkegaaclarke approved these changes
+1 more reviewer
@gemini-code-assistgemini-code-assist[bot]gemini-code-assist[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

CICDRun CI/CDengineflutter/engine related. See also e: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jason-simmons@gaaclarke@jtmcdole